From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 27D513858D35 for ; Mon, 14 Mar 2022 18:16:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27D513858D35 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22EI92MO015204; Mon, 14 Mar 2022 18:16:52 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3et60r90m2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Mar 2022 18:16:51 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22EIFvxD163923; Mon, 14 Mar 2022 18:16:50 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2108.outbound.protection.outlook.com [104.47.55.108]) by aserp3030.oracle.com with ESMTP id 3et64t5d4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Mar 2022 18:16:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hT6VbMv4tX9GHIWuqwPloPlHjGUZmXq4vFyrbbFA1sh9eMtyEkpZyc45+E9R37M3ciLwaxevRyGpwlCeiUYVj1/1haY/pYKC6PPzJKpf48q0YstL2ui3p0TKcOlsriOtFySlAjXXuYDTVpi7ITi/wnWqwx5+kzXwZK0c0uB+FQBfb2yyWz4GaDceYShAhQbiZpuWbCDjSfa0NURSzpZ9NM43ZoJRsEVKKpz4e7GebNwE5WRuy9PYHd/9HUVoTv6/7eL+/peu9xB2eT0Niw5sxDQKvP7swk5k7webTDQzb+Cxgc1SrIeR2Y3QHsIRBnzvLB0uU/m3x5hVasDLMkJbBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fhg7bj6L6qpnzIp18kQIVVS7x0I0hFY/CZVDVDbroZc=; b=FI7OfiRcIEaYOXDRxsjtu/Dssjdma6DQLrdNSo70oSwR35uOdB0bQBoY5KqwF+lW80DgmQpfHd7QEBnVxKJ6YJN1Tt362db7KbMEFK1WtNRWVTLPFCWEPkN8sEP4toWZh/OfMAoCkPZSsxjE4dIOGOlyEaiBYrICdj0PlSPgVv5MWQME8nrkH5Z0+qKpeuH3nH/IWTEqzYD0uGUHD/r6o20AGR2TXHTpxBrlWizGB/FATI5iIFcJWobT506h7zlVtaaq2xe2UKtFvob13T453kHuyr6fdrLX7017ysuk0C/9wxKVVnHmVqepbWV6YCD3ZoFEK2Xmflshg0cWz1gGfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by SJ0PR10MB5598.namprd10.prod.outlook.com (2603:10b6:a03:3d9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.25; Mon, 14 Mar 2022 18:16:48 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::f901:29d2:1b8c:4306]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::f901:29d2:1b8c:4306%9]) with mapi id 15.20.5061.028; Mon, 14 Mar 2022 18:16:48 +0000 Message-ID: Date: Mon, 14 Mar 2022 11:16:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: =?UTF-8?Q?Re=3a_Build_issues_due_to_patch_=22gprofng=3a_a_new_GNU_p?= =?UTF-8?Q?rofiler=22_=e2=80=93_CLOCK=5fMONOTONIC=5fRAW_not_defined?= Content-Language: en-US To: Tobias Burnus , Binutils , Nick Clifton References: From: Vladimir Mezentsev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BY3PR05CA0009.namprd05.prod.outlook.com (2603:10b6:a03:254::14) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a4f182b-5204-42cc-43b2-08da05e6cdf2 X-MS-TrafficTypeDiagnostic: SJ0PR10MB5598:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4i0jZdf9DWefa/O26gu3Vr3BBbYpyXMH3wHudi79eZigAWpc4lfavFuN1XTrOOqZUQtWu8jRMG1cFDZHciuGNgvMJI8AaXFXFA4FXeZisq0MrqZkzARltTJ/XomoronGE4gVUUamAwP3yWxSHX0H8OYe3PxEPwVAnX56JWX+4ygAUeICAqbFVKffevkv2fuO+sja71ABZrUGfYcTSrlnqHEMUYTeYHOQ09xN64pGAhH5eUKXo8zuzTzYGORmpTbAd9O3LxYtxPX4s3vCTcht33cGdwxHukhMIMb0zjaSO9RaypwJa8Pc0uydjQSGw5ZcKswgDzgRpRhvYl8aCRRntGgqSCC+vcvkJWKmzfEnriJ/naRjl7jvPb2mLyAJdKjJ6H7anwhJH8fqpzLcBz554BVX8CgvPvGydcmFUiLn+pJH1A5AIZQcZ9sXqGwnvyszxa+FhPpZ132RWz/kGbdlFLRm8z75EI9mU8ERmnCr15eYuTWpg7Pf4ld/WnhZNTlKIWRkAy4LZXYQajDGsh/nzSEIOkF/HPNMSk2w46pKTglSa+HqELSluF1ZsdEZ0vrcNDYkFa/PrZzGANjwxpEHbVgATKfYhgBjwvDIt883HSYA/ZrkapJBimKMKhmUGxl7/sJJ1Y0wqfsAp+QPjk8LT3AsI/9/n7i6HZPbiLrsGtsq8SsuVKJ3jylgsJb/a66ZnFp5wndawntNLcYRg4FgCs7Gb197ZdexmgvgroI4ivewVibWJO+TA+dM5cq211ITITbhvW6bu20wp/0GuR1E9Wnbwlg3c0OdAglCynh4I7rG8LfgxvGwKsFBvLyXVYYviOfm+U9gApVDLdWtG2TRVDan7Fw7uDifNv5a8i+NaXw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(38100700002)(508600001)(2906002)(5660300002)(6486002)(966005)(53546011)(31696002)(6506007)(8936002)(6666004)(6512007)(86362001)(66476007)(66556008)(66946007)(31686004)(36756003)(110136005)(316002)(83380400001)(66574015)(186003)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWlKOTMwcGM0WCtLcjUwbUtDUGRKMnlVU29CbE8xenh2TUZ2WW9lOUVGemZ6?= =?utf-8?B?Wm42K2JXYlFVazJXdzQrdmtRcmJVWXgyMVZRMWRwa05wamxjVkxsS1I2Sk4r?= =?utf-8?B?alh4L2c1aVMwSklFdVV1VmMzR1NSQ1VVVVFBM0JNY0JaTkdqOWl3c2FNWGYv?= =?utf-8?B?YTlqaW45UjkyYmdiRUJzaUFCVzJTMms3NFFVSUdKWWxCU3VWdkYvM0Y1azI2?= =?utf-8?B?Z0kwekovaEFEdlpvaUVmdmRtWUZXMVJWQ1BwMFRaTFZhUmpPUDkwZUtDL3RZ?= =?utf-8?B?ekMvb2ZZVmFpVXl0cVFEUnhQbGJyc2txK1UwVWxsRU1EV1EyRFhLQ3dqbVhz?= =?utf-8?B?ZHpZcDM4eVh4UmNzK3VuTHUzTFNUNm9TY0srcmpGWkRSUWFjY3EveFp6a1lC?= =?utf-8?B?VDI4TkliTGZIUHJTQVh0UjIyQjJINFVQaEtTWW5uWmxNL21CQzVhbnFYRkFY?= =?utf-8?B?NVVMS0Z6NmR1eXVHYmYxRTdCdkUzV2NzSVhwSHVKUFBFOG9zcERDVDYrOXZy?= =?utf-8?B?U2pQd3orZjVCTVFnM25EcmY1L1VSNEF0RTVQSk1MbitJdkdRN0VlbXRUTEZ4?= =?utf-8?B?TjZJQ1BhU2NxY242akd6c042dGN5cGQvaGxyN0VLWHpFa0JYM1lyM3kvVDha?= =?utf-8?B?aGdjTHVGZGpab2hOZ2JEU2NLanc4T0VRV1c2TzlXTTlFSEtOcm04OGxvRjRU?= =?utf-8?B?WktZeGdEQVF3WGVVVGZVK252WXNNMWRDMjRuVStRaGNKZUtOa3k3ZkJ2RENW?= =?utf-8?B?WjJZMFUvTEhXQnZpTWpMU2Rmb0pFNmQ1L28waDREdkI2N3BvS0tCV1JLdlcv?= =?utf-8?B?WHVNOWd4K3g0U1NYNUJkNVJQbXlTb3pObGEvYVZyNFJjR3FNRUVwUTlpa21r?= =?utf-8?B?S3dMTnV6NjRoWU9LRnVHWmlGRExnQkJWQjVESzBHU2dZZ3NuaGlzWGZaSU9T?= =?utf-8?B?WlI2RnZvV2FtYWUvM1ZKT1FHNUlIdVhHTS9OZEJBeElVaU0xb3Z5U2ZENlFp?= =?utf-8?B?NVVjNE02VXNBV1JzMFA0dm40Y0o4amU4M29wdTRvT3c4bUQxQi9IeVpVNVEx?= =?utf-8?B?VVBMRUN4MTZxdjFXdUwzSHk3N3hMTTRleGxLTnVtZ1hNMW5LU2tHMFliRkZF?= =?utf-8?B?bGJWZzRZb2luSlltTG45YW1Wc0RUQmhabnI1d1F5RlRiK09tTWIvMzZqMEZV?= =?utf-8?B?cnE1a2VPUlJlQW1oa3BUQ2ZPelNuKzFlUU1CZStKUjJLRkxYeUQ4d1htbmI1?= =?utf-8?B?cjkwWENPbXF6MVNrUWpQZHk0MEFHaUxHTlJFRWpMUEJDcFYvSkwrbnpSS0ty?= =?utf-8?B?SWtyTkRFUk9EZXV3ekpjaXE2aVo0WnVlMXFFbzhWQWpNUVFwVFA1WG00VTRj?= =?utf-8?B?emFINjhWQmZJTHp5Mlh6OEpVVmJBcFJmemNPREY0R0haekQ5dDZxODM4dXJu?= =?utf-8?B?NUt1aTFObHFRUEhzMXE1aXhkOE9zZVZkUzV0MzlPT3k0YjU5MGcvMFd0UlF6?= =?utf-8?B?bThvTFhjTFRtREYzd2Zjb3U5NkN4NWRFZ1hJaVFsRGwzR2FTdVB3VHIzS1d1?= =?utf-8?B?V3F0a01XcGVWVW1icmNvRXVzQWxwcXZhYklBRnVMb2h3dWc1dTNKWjIrZlRx?= =?utf-8?B?bS9EUnEwMkxHZW0xOUFrSzFpQnRCRkk3U1dLSlRTdzJCQzZyL0Exbk5QNmlB?= =?utf-8?B?eHU0c0NPREwxOGN5K01IdUhtV25ocllXWTJDVE1HZytQSlM4Ny9vdndBUVY0?= =?utf-8?B?bGQ1M0l5Wk1kT3gwc2VSWFNOZStpNzNueml4VVo1VW5KMy9Dd21CcDNNbUp2?= =?utf-8?B?ZGFhOVYxY3d4NklWV3FTb3dzdm9CNW5mM0JJSUpldEU4N003NjBVY1VGNDRK?= =?utf-8?B?YWh4Y014RDUvdlp2ZEtVcXl4ZjNhVFBoN3AwRmlMKzRabXlnVFdRcWZzSStm?= =?utf-8?B?YkJFcjVLNG5GSWk0ejRWN0EvQ3VFd3hnZzE4Y2VxZ2VWN1JXTzg3bU1CQVBK?= =?utf-8?B?ZWZkTGRCb3lLSFJiOWRqR2hUOFBrV05xMGk0b0t5NXgzcVlFYm1xZlNkVFVD?= =?utf-8?Q?NVJGp3?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a4f182b-5204-42cc-43b2-08da05e6cdf2 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2022 18:16:48.4044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0BshMg1ftONPFZGvLk3Wk9u+up2A2LdZnR63kcnMpZXigK44uIK+tghxGKxXd2Fe9GtFxywXEYSY4FHEPvJFGOx6h6kNblQBEYmEn3du1To= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5598 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10286 signatures=693139 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203140110 X-Proofpoint-GUID: Gps9NI_RxkFSD811mE-XMGv9kNBly5h0 X-Proofpoint-ORIG-GUID: Gps9NI_RxkFSD811mE-XMGv9kNBly5h0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 18:16:58 -0000 On 3/14/22 03:57, Tobias Burnus wrote: > Hi Vladimir, hi Nick, > > Friday's commit "gprofng: a new GNU profiler", > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=bb368aad297fe3ad40cf397e6fc85aa471429a28 > > > broke the build here (build server using on purpose an older > Linux/glibc): > > gprofng/libcollector/gethrtime.c:35:26: error: 'CLOCK_MONOTONIC_RAW' > undeclared (first use in this function); did you mean 'CLOCK_MONOTONIC'? >    int r = clock_gettime (CLOCK_MONOTONIC_RAW, &tp); >                           ^~~~~~~~~~~~~~~~~~~ >                           CLOCK_MONOTONIC > > According to https://linux.die.net/man/2/clock_gettime: > >   CLOCK_MONOTONIC_RAW (since Linux 2.6.28; Linux-specific) >     Similar to CLOCK_MONOTONIC, but provides access to a raw > hardware-based >     time that is not subject to NTP adjustments or the incremental >     adjustments performed by adjtime(3). > > Thus, it seems as if either a config check or a much > simpler patch as the following is needed: > > --- a/gprofng/libcollector/gethrtime.c > +++ b/gprofng/libcollector/gethrtime.c > @@ -34,3 +34,7 @@ linux_gethrtime () >    hrtime_t rc = 0; > +#ifdef CLOCK_MONOTONIC_RAW >    int r = clock_gettime (CLOCK_MONOTONIC_RAW, &tp); > +#else > +  int r = clock_gettime (CLOCK_MONOTONIC, &tp); > +#endif >    if (r == 0) > > --- a/gprofng/src/gethrtime.c > +++ b/gprofng/src/gethrtime.c > @@ -161,3 +161,7 @@ gethrtime (void) >     */ > +#ifdef CLOCK_MONOTONIC_RAW >    int r = clock_gettime (CLOCK_MONOTONIC_RAW, &tp); > +#else > +  int r = clock_gettime (CLOCK_MONOTONIC, &tp); > +#endif >    if (r == 0) > >  * * * > > Additionally, the build fails with the link error: >    gprofng/src/gethrtime.c:131: undefined reference to `clock_gettime' > > The problem seems to be what the 'clock_gettime(3)' man page states: >        Link with -lrt (only for glibc versions before 2.17). > > Please consider as fix to copy the following check from > libbacktrace/configure.ac: > > # Check for the clock_gettime function. > AC_CHECK_FUNCS(clock_gettime) > ... > AC_SUBST(CLOCK_GETTIME_LINK)  Hi Tobia, Your fixes look good to me. Could you apply these fixes. I can prepare a patch but I cannot  build on your configuration. Thank you, -Vladimir > > > Thanks, > > Tobias > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße > 201, 80634 München; Gesellschaft mit beschränkter Haftung; > Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: > München; Registergericht München, HRB 106955