From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id DA06A3858D37 for ; Thu, 18 Apr 2024 07:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA06A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA06A3858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426057; cv=pass; b=JmTS5tmbn/EPl6h9mEf3D74ZdPLUyoRh64dP/RsB07HHaTcc1Vb0qbRy2r27BqhpHAj1jtrdsXbXhAZ7P6zCANs6CzFt4lJk+FDzuo03tDLGASDJF50/vn1sRU0ScJM7o04RYwMMKRnRTJ53UvzhsxVsfkgbGE0eG/gI1GPPbas= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426057; c=relaxed/simple; bh=a3nW+4CjOvprl8bJ2PW/9Vkjns0vz6vJZ5Ezc0RutIQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=xI19BWj6bnlO09eTdKQcOmyeAjNENCkfQiPFVJWM3uPSxOOXz5HjOTO9Mk94N6qJMb0RXseC49sBarCpE3NIlJ9dFvMVRhzYg0su9oh8cOwj+2DLUGHf3xU4i0FRSp459Fg+CrvhdLzTZtjQQHmY+ZhvyYdDSnXi0hoAxlZjYiY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43I3weYE003984; Thu, 18 Apr 2024 07:40:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=f9Tad5yCJwSWZlOvG/8rDbKiTUhD36OiAAM7RcKNQmM=; b=MiisN/xWN3GG0G/eFxOurdOGoySLE9caNZcnPeU/qivSAas4FRoaFCfBvAv76WCRzjsM JqLrIt01wQqYlJbZCckrdZXjVcM+5WnTxQzgrGHV3j/2dQ7Z4M7phDg5MDIFWCwmS648 h1BOSFkB1KUb6czPK1uuMwXs/1Muc3fsyekUm4UjdVh9zzyp06WkEa/1bKVf3eOzlpQm FERAKEvjqwPhf5xQLgx+0QwXLODlgYUiG2LcRZo+gixF48bPWEPlfWWkvZG8KmjUMPk8 DazdBFl9UO/uahJ952LPWTLzjfwhlfB5T7qfiUFoO+kQp+ueT0orUgYrJ/FdQUzxftrH uQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfgujsuuh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:52 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43I5VrQC014307; Thu, 18 Apr 2024 07:40:52 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggg8yjf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Et+06sj058N3PqoneKMWUZUDMn45SrIMt8fl7TBRsWJl6gsw7DO4sMQWjaSAOVPwjBd/zkhIyyDH84IrjvKJpNf/+JyPHKLfOdGJleSgO4Fc80/IfZG8eExJj0sj3WmQvK7HhAyHX7Hs2FIC+pKJNAMn/6aZGqUhh7N5jvYCGbblHVfFDgx/V0wNYZvFUcM8ZrXFg0GagQrNHJ833/SCI9AFzMB7Neh9n65XM+rbm3q19LgopOHEFknXdnW9Km22Qcr+n4L8pQbgfvcAT25S97TwmnTfOOHfqIotHgsocVn88xgkU5lxcx1yjHkrKyGZky+Jf7V/FZ2L31TqT/1fiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f9Tad5yCJwSWZlOvG/8rDbKiTUhD36OiAAM7RcKNQmM=; b=d07c9gL6H9eJ9lWL+oE0NLFI3CSfSTHgaymFYZLhqnOfYPkiVsjPtX+mbWRnZSh8QbGCbsY0DKExR3v3htip0+YyQDdhTyV+JG3D3/6yJ6MuUhDto6OMfNsxwPEB8sQ5OcylHYHHz4H/0OnsHBC9J7Pm1cIpHO5oQaTd0YA9gRcIgnkgcy8qxrn/FYgLNmSDdm88Bmyl8VawN4/8roh9D2i1bjKV4o4H+bVtIX3yvTKvmceVic4RmYSGZRM7LR8xC5J9vvGEp0c4Bj0Ws3yr93kLihNnoKa2Wu2ZpjdlzFAde2t+LYrTcAoPoYskDv0/tbG7eDl9K13pGerr9FinoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9Tad5yCJwSWZlOvG/8rDbKiTUhD36OiAAM7RcKNQmM=; b=z+5wKxtZMiSAo5aESTEXf40CfpifRoi/L8PbKyjeGq5LcgmLFhYm445KkgHgwV09pq3hT8SfQnlFeDFaPdRKwfk6yjkaYFlK/ghTLh6iN+AtvtPtnpcxGIOjS9MYqhI3EGugIbVfvWN7ZtoVi8INc22xfPtHOu5pyEkOGzj2Wr8= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB5694.namprd10.prod.outlook.com (2603:10b6:a03:3ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Thu, 18 Apr 2024 07:40:50 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 07:40:50 +0000 Message-ID: Date: Thu, 18 Apr 2024 00:40:50 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/15] gas: Refactor SFrame CFI opcode DW_CFA_register processing Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-9-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-9-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::9) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB5694:EE_ X-MS-Office365-Filtering-Correlation-Id: bdd33056-e930-412e-8bb6-08dc5f7ade84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qH4XgkjbCYvOrtWrM6fAEgxjv3PQuo1wFh3RRPQoIblgDEz2SNcXShoLiVDUOzfgZrp92IKycx1hDbMv/qpJLZCgNTL/UcEG1P5yPMYv50YwgUWaGKBk60PiuNF6ETdOeHE/LMUZFBEv7+P1nOWkxDAa7sAl11CcuJWZ2oO974sWx5IpeQs7ZSURkZkdjzbCsjVka0z4BRwBtxCkRmctjj6klZs23J2FiqqvXhphL0KXTAnXFk8oMdhmNHMzl+HRpOkDlA5+1vr+JjR34DSwWRc3arFGc1Jf1WhbYjqGfFEW5bA9Eywy5xqqHe44IXkUwHdx63+4/xLCCWfvRN4swaQcTY7AFkQ3LB58OK54w/Ps5PHJtFPkauqojPcg+26mh39bP4sYgB93k1R3TyFzq1+wZMlSRIMouQV5H6e+n6+68suYOxZMtNposnVpACO8CVCA1+vVS6TlavKiIxvsxKaDZjdOen30RCZkp9uIoOJuMWsNuvsdAgxVzDwOKplnQzrIqFmuhStEz4l9gk3Bia5yR02dpu9/CIfMGCiwHg/COpNln26g4tNXNeMbySGZ7NXwlmZ9wRfkgbTVMBtv5JTYlBuJthQZ31Zh/NMMGjO50COWPAhFQvpLgVfUxmqL9diijMfJbBnGmfqRPAtEPatkfJ7/RovNT7X4wRPj5Zc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUxrVm0yYjl2MXJMYWlPK0huam11aFlyRTJGYTNocnp3bGFBVW9qRnhROEZ4?= =?utf-8?B?ZmxMM1FxNy9MZ1ZNY0VPVlpnR1VCNytJZ1VSUHpFa1RvNGNuSThzczBlVmJV?= =?utf-8?B?S0FUNFpXZm5kZldhczFFZEJWcE54bVN6NytKbzBuRGYwclNsNUNsQ1A5T2hz?= =?utf-8?B?c1lRcTRUOWg0b0s1eVZ4REt1NlkzRlBXOGRLTjJHQ0xZMmVLY3cvUWh3U0ow?= =?utf-8?B?MmEveldwNkI1QW13QnNJVTBKcVhISk5BOUxyc2VtV2xsNldsZTRJblpCWGJJ?= =?utf-8?B?cjRkSzNIbUJMdjhiRnk1dXNDcmJhTmJlQ3A4bEtIN3VJOVptTzRtb09iajRl?= =?utf-8?B?Z0NweWx2MVc2bEMwTkhPMGlEZGh6bGlQcFl1VWZSWFZNbzl1aDlCK1FqTGVv?= =?utf-8?B?R3QwMlpRMFBuSlA3YWZyQ1BVT1NadStKc2VFb3lPV2I2dWRycG5DTFVuUnU0?= =?utf-8?B?d1VpbExHeE8rSE9QMDZ1UEtIaWFHNG5WR0hYdWU1YytSZHlXUWl0QVpLNFAy?= =?utf-8?B?VU41RXhsK3YrZHlYVGhxNGgwdTZuTDBWMEpUakl4VkNVcU1mZXpqK1RVa3N1?= =?utf-8?B?RENzM2ttYnBiampJS2NFbUEySElEa0h0V3FMNVB4enI0VU8xZmxIQVd6akpW?= =?utf-8?B?UmJWdUhMUElKcGpSMUlQZGFIUHVOa0JySkxXZ3BnMmJKYmppU2FvdTF4L1lU?= =?utf-8?B?QWRzcU1xOU1zWjhTOXF6WGZ2dTdOaGdselJkRmpxSWZZa3hSMWQrdFh4YitJ?= =?utf-8?B?cjBHSUNEeWdONHAycUhQMlJCaFQvc2lPVUdYNi9VbTB1K3l4U0hzaU92QS80?= =?utf-8?B?OVFhMUZNWWRCRHB6SnJ5TWdja0N2cEk0UE1uLzB0Z1FMbnV5bDZjOUZFK1Fh?= =?utf-8?B?bk9ZNnlPYW1iMEUwSXJXTkpwMzdZbWw3NVJ1RUYyaHd1THUrN2diOG03QTRr?= =?utf-8?B?alRJWXg0Szl3aWZscGNnbVdta0h4MjkzcFZZWHVQVVZqdzhUVkROQWdobGUx?= =?utf-8?B?L09SVHJpRFJEc1A5bUZwdk9QeXl0UDVISjF4N3MraEQ4dzZyMWFBUlN6ZGxo?= =?utf-8?B?dEEySXNDSGVWbE9LVmNmWDV0bS9DV09aVEc0dFJBZjdLTzJGUi9KN1p0T0pZ?= =?utf-8?B?cGoybkJWNEpSRllIenNxSElRMjNBS3dOZnZ3Yzlmbmc1K05YSU5oK0FZR0p5?= =?utf-8?B?L3R0Unh6aEVFNzFUWW9ETkUyelB5WjA2RlBTcFNKZVZsRWR3Z3k5ZzJvMTlF?= =?utf-8?B?QUU5c2p6aStFbzlPeG15M1dPdnIxOC9lMEhQSEd2bzdCdGpzWnpaNUx5NzVY?= =?utf-8?B?R3J5NzJlSHkwcERzNERHV1hud2xScncyNHdnSHMyUVNHQXhXZE0ySTRscFRG?= =?utf-8?B?YXJLV3hVZTB0WXlyZW5IYkRvQm9hWlV4LzQwN2g4MFRYb2NiMzh4WnNJSjB5?= =?utf-8?B?TkMzQlRhYUw3T2dOaWFzdTdXZkJWeEJXUkRMdGtLTHF6SVFTV0gvR0ZzRWJ4?= =?utf-8?B?K0pwRGI0QjRXWW9JazVybDd6OUQ2RFlMeTdXZmYzbXIrYTRSQkM5RDN1RUYw?= =?utf-8?B?ZmRlRjBNeks1cm9GNzNUQ3EvY3pxcVNBc1Yza2VhcEhLRDNvTU40aXpUbEZK?= =?utf-8?B?T2RwblFtSzZHS2I0dTdvNnZyZkowSG1GTzRlNGhzc1ZXNzNvYk9EZXNQam80?= =?utf-8?B?eXVaeUZlUWtRaUc2RXhBM0dxUGtOWnRzeUhYZ0FUcDBxbnplWEZyb211Q0xQ?= =?utf-8?B?Wm02ZkN0Sy9RLyt0dlF0dlQzelZxdDJaRlFXWldqTEdzNE5mN1RzeG5UdVhz?= =?utf-8?B?VndsSDVSRlFlRW9xWEY2amF5ckp3VGRZQ1MvZ3ArTDlKNHVvYVl2VjBmKzBO?= =?utf-8?B?eCtSb054VTNHdnBqNTc1MzRNTXZHVUpiQXVzRXZZMVRjbGJpOHdjK0xTUmha?= =?utf-8?B?UWdNYURyYXFKZXkvSlRzSCtmODk0dVI5ZlJYLzVtem5kVHJLWTFQaXNnTFdu?= =?utf-8?B?QUhycW8yY3M2b0xlaDhBc0lOOHloOENYd2JWQXhsTUd4dnBPYjREWXFlaXpU?= =?utf-8?B?dDZldkRPS01HNE9jWGZ2NXdpdXlBTk5YZ2dMaStEZHZ6enpHc1EzTUxGY2o0?= =?utf-8?B?ZGRlbHpVV0tqT3NmcW14U0pjYms1T0FHdmJYUVhzZDZReW5Odjl2RUNBY1VM?= =?utf-8?Q?ZuAkqyHcyYC/OHArSJffv0s=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Lt/fjnctlCqSDxRYZVytXFSnN4bKIeJVrZQYZjJLrL3dcEdTXz2aNMu6x03KExuKOrj5rb/D3/k3iBAInYrroIPDQQFfMSvUJxL4vXPTyCrF5adqluecZvtwfhcSmmRAZSWfmI1joeoIePrmwpM8UIfVgmBosOY5aBt1TCeaY3l5aQE+7o0caRRx6HXj+y43r1wIZ30UN4PChBk06Ck/sXyi+4TC067B+OQhkT1SREsBdTtoydoKn86t7WjNAv6SMkQZFxi1vvfNH+acgz5LXCcYR3vBddbM0rDy9f3YIw5rGCgOttQSHOzGAqLu++ZHpqQ7xMW29OcIqFb9BK2vyOCb0i1DfXeAXl5K2yC65V+uMdZaKySD6c/3o6XDYDQmL5mDLbNZVjhwd5sUhsVB+Cu/1W22fnnI6YBZjiW5Th91j1alCyp325GoTxoAbwC4XZFW0cPqrd24KibhK0UNZnEizi3ObmbPXPcJhdWM/Y6cSE9Lp3TZ0LAfGObypzuMhH5sq+I1MVoOLXobEiSVbhqmv2qITAFxE9f+VXPrM5DxwN4YZ7cgXeZ81oOcbdvvRwrozu4lnGoOQnFY2GPL05eE1Ni4wJtlHSwmeFyfTEA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdd33056-e930-412e-8bb6-08dc5f7ade84 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 07:40:50.4387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PW9RkkiWHCAjIn+m48DbjocMStiQDz6Yc9oeoIbQ/c2UfwMvQ9xu0bQdGKJhGvXwHCM7K25p/WItD0EP4T4pmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5694 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_06,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180053 X-Proofpoint-ORIG-GUID: b3mfChoH8XofXYZeN88wGHSgn-81RMEQ X-Proofpoint-GUID: b3mfChoH8XofXYZeN88wGHSgn-81RMEQ X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > Refactor SFrame processing of CFI opcode DW_CFA_register into a separate > function. This harmonizes the CFI opcode processing. > > While at it reword the comment on CFI opcodes that are not processed. > > This is a purely mechanical change. > > gas/ > * gen-sframe.c (sframe_do_cfi_insn, sframe_xlate_do_register): > Refactor SFrame CFI opcode DW_CFA_register processing. > OK. Thanks > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. > > gas/gen-sframe.c | 37 ++++++++++++++++++++++++++----------- > 1 file changed, 26 insertions(+), 11 deletions(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index fe8b24906c1b..f47f51c7a354 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1108,6 +1108,28 @@ sframe_xlate_do_val_offset (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, > return SFRAME_XLATE_OK; > } > > +/* Translate DW_CFA_register into SFrame context. > + Return SFRAME_XLATE_OK if success. */ > + > +static int > +sframe_xlate_do_register (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, > + struct cfi_insn_data *cfi_insn) > +{ > + /* Previous value of register1 is register2. However, if the specified > + register1 is not interesting (SP, FP, or RA reg), the current DW_CFA_register > + instruction can be safely skipped without sacrificing the asynchronicity of > + stack trace information. */ > + if (cfi_insn->u.rr.reg1 == SFRAME_CFA_SP_REG > +#ifdef SFRAME_FRE_RA_TRACKING > + || (cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG) > +#endif > + || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG) > + return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ > + > + /* Safe to skip. */ > + return SFRAME_XLATE_OK; > +} > + > /* Translate DW_CFA_remember_state into SFrame context. > Return SFRAME_XLATE_OK if success. */ > > @@ -1296,19 +1318,12 @@ sframe_do_cfi_insn (struct sframe_xlate_ctx *xlate_ctx, > case DW_CFA_GNU_window_save: > err = sframe_xlate_do_gnu_window_save (xlate_ctx, cfi_insn); > break; > - /* Other CFI opcodes are not processed at this time. > - These do not impact the coverage of the basic stack tracing > - information as conveyed in the SFrame format. > - - DW_CFA_register, > - - etc. */ > case DW_CFA_register: > - if (cfi_insn->u.rr.reg1 == SFRAME_CFA_SP_REG > -#ifdef SFRAME_FRE_RA_TRACKING > - || cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG > -#endif > - || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG) > - err = SFRAME_XLATE_ERR_NOTREPRESENTED; > + err = sframe_xlate_do_register (xlate_ctx, cfi_insn); > break; > + /* Following CFI opcodes are not processed at this time. > + These do not impact the coverage of the basic stack tracing > + information as conveyed in the SFrame format. */ > case DW_CFA_undefined: > case DW_CFA_same_value: > break;