From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 533F33831BC0 for ; Fri, 9 Dec 2022 01:11:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 533F33831BC0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x434.google.com with SMTP id h10so3715084wrx.3 for ; Thu, 08 Dec 2022 17:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=PnhYxX9sIWJ2Kjl0PR+ofz0QiRw1/DseR2FtkwpyvQ4=; b=D+TzaZtBRDvsUONQhONWGc7FFoWwP+6k4hgNDjPK2mhIyyYdPtc+mIr5VxruT5FXNN 3jWjfmJf9hmJ4k+V5UNlWPYRMf6xAzc1FLJcfgTfD0frFJvd7nLlpxzpuLFf7FYgEube EIjdz7Qf3+S2zmWu76qii/z9OO//ji842shxs/2r7FsQ+JBEFqhGE+4ZbXcGUqYdu1VO O+R+J4jRSzcMORQ49W0Yk3BMoc43yQQnu7nScurtg7dI9kJd2TzJVRIKZImpoFHjCUQ3 GzNFnTHUwvzQHelAiid26DT7xkAhOdr2b3Ib92DO1rq2WH7L1IPgIRPRqdDahh7HJTn3 EKpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PnhYxX9sIWJ2Kjl0PR+ofz0QiRw1/DseR2FtkwpyvQ4=; b=fCNopv+OYzHgUrcddi10GS24xiBo2hzYBzbXzYzMvUOm2/WFq1AyRCFk4abWgQ79iX apCT0OfAMLfhMe9A+ZrKdZp5sqcQfjejfyJ5MU0JDe1jctOaxuWqdYPoK0RdMCi3ew9e i27pOM38LKVomhCBEvDDIrOnybHnq1Lh0TbHboEXEuzOno7FVk2hvo9LiwFBbv7hWSeb Ad9M0v0cd7ov0OkN0bKneaQCnNBAal20nCZdkeyZ2ztREGNdC6UILm/1z+dBQDFd5AK1 VHv2XCPouUwiiVgZuUmYUS5UQ1FXzjL1gLV6VS94yvnVNfDY5/ghnFFOynjDk/pQxqV5 9fcA== X-Gm-Message-State: ANoB5pnOKD+J1LR6MEVcOX3ynCjMoHYZcP8/Y1PMgTYfMchMJpkA6nIn G1NdfOe3BcSvqNmgX+Znh/NetLVRD30= X-Google-Smtp-Source: AA0mqf6bIA3aGLFcEYyWbGxT0NsIrmf38F6NR0PDdK4rfgO2/LLKkENxWkqgVs+Vm1G3AYlj4XOKlQ== X-Received: by 2002:a5d:500b:0:b0:236:6226:7bc1 with SMTP id e11-20020a5d500b000000b0023662267bc1mr163606wrt.68.1670548274947; Thu, 08 Dec 2022 17:11:14 -0800 (PST) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id bq8-20020a5d5a08000000b002302dc43d77sm13544436wrb.115.2022.12.08.17.11.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 17:11:14 -0800 (PST) Sender: Mark Harmstone Message-ID: Date: Fri, 9 Dec 2022 01:11:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ld: Write globals stream in PDB Content-Language: en-US To: Nick Clifton , binutils@sourceware.org References: <20221129001015.21775-3-mark@harmstone.com> <20221205015347.25781-1-mark@harmstone.com> <767534e1-60ef-9f21-46ad-ebf9411ab6e9@redhat.com> From: Mark Harmstone In-Reply-To: <767534e1-60ef-9f21-46ad-ebf9411ab6e9@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, >> +      switch (type) >> +    { >> +    case S_GPROC32: >> +    case S_LPROC32: >> +      scope_level++; >> +      break; >> + >> +    case S_END: >> +    case S_PROC_ID_END: >> +      scope_level--; >> + >> +      if (scope_level == 0) >> +        return data; >> + >> +      break; >> +    } > > Please can you add a default case for this switch.  Probably with > an error result of some kind, unless other types are expected and > can be ignored.  (There are several other switch statements like > this too). Sorry, I missed replying to this comment. Yes, that's what happens: S_GPROC32 etc. increases scope, S_END etc. decreases it, and the majority of records don't affect it. Mark