[patch, testsuite] Use Alternative version of lns-common-1 test for AVR port

[patch, testsuite] Use Alternative version of lns-common-1 test for AVR port

[Sivanupandi, Pitchumani]

Hi,

AVR target doesn't disable/ undef DWARF2_USE_FIXED_ADVANCE_PC; It generates
DW_LNS_fixed_advance_pc opcodes for line number information by default. So,
AVR target shall expect alternate output file for lns-common-1 test (lns.exp).

This patch adds avr target to the list of targets that expect alternate
output for test lns-common-1.

If Ok, Could someone commit please? I do not have commit access.

Regards,
Pitchumani

gas/ChangeLog
2016-04-29  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>

	* testsuite/gas/lns/lns.exp: Add avr to list of targets using
	DW_LNS_fixed_advance_pc.

diff --git a/gas/testsuite/gas/lns/lns.exp b/gas/testsuite/gas/lns/lns.exp
index b17e644..567db67 100644
--- a/gas/testsuite/gas/lns/lns.exp
+++ b/gas/testsuite/gas/lns/lns.exp
@@ -33,6 +33,7 @@ if {
 } {
     # Use alternate file for targets using DW_LNS_fixed_advance_pc opcodes.
     if {    [istarget am3*-*-*]
+        || [istarget avr*-*-*]
         || [istarget cr16-*-*]
         || [istarget crx-*-*]
         || [istarget mn10*-*-*]

Re: [patch, testsuite] Use Alternative version of lns-common-1 test for AVR port

[Nick Clifton]

Hi Sivanupandi,

> AVR target doesn't disable/ undef DWARF2_USE_FIXED_ADVANCE_PC; It generates
> DW_LNS_fixed_advance_pc opcodes for line number information by default. So,
> AVR target shall expect alternate output file for lns-common-1 test (lns.exp).

Technically speaking the AVR target does not need to disable DWARF2_USE_FIXED_ADVANCED_PC
since this is defined by default in dwarf2dbg.c.  The definition there uses the
value of the linkrelax global variable, and this *is* set in tc-avr.c.  The
default however is to disable linkrelax, so your patch is correct - it matches
the default behaviour of the AVR assembler.

> gas/ChangeLog
> 2016-04-29  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>
> 
> 	* testsuite/gas/lns/lns.exp: Add avr to list of targets using
> 	DW_LNS_fixed_advance_pc.

Approved and applied.

Cheers
  Nick