From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 4EE7A383236D; Mon, 14 Nov 2022 18:38:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EE7A383236D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AEHPgj5002381; Mon, 14 Nov 2022 18:38:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=impDZLhIbX1FWRMdS6aaOo9KCMk6hm5Z4PbsEmpiwqA=; b=de17m2ehwhvEdMFmBtia5Y7Ucr84t05P0YGBB3KUbk7JpAZOpL+3HE+89pbE/cGtrFtj cwQXzuyYlB54oq/iUZ0cHQJt++UTObsfOiqqrGRAyUO/oNeHWBqq9Ny7xNuzJjY7bXnf 9FLSr0xDOce+5mvmKafJnY/QXe8PQLJZi6SkLpYYyWQGl6ZvTwwjWKEx16sONEt8WpWr Hbrxwt3u8KkGuVSCUmyRw2He3g6SAl4q57LJujnfoMmmmvXsBta0rKjpJCB+3N6J4tm9 sGrtvvo8pPXUoTTPCAIMUkwczQaOsp26uyqbYOYBSx04TqLbmOO04qbTZ3RyT5IjydKL 9Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kut2f87bg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Nov 2022 18:38:06 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AEHgLVI034872; Mon, 14 Nov 2022 18:38:05 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kt1x4hvfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Nov 2022 18:38:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c58gOVijDbUf/GgVWywstvQY+kL+RgYOZc94nReZV5YvejCg5YJgN91Ysn7m/sSRIeBwGaGTs+BOGC4lAhnUQY+/lcoKTQrgipbCUChaHkznATLlQrar1+7BIpBN2pRCL2TXaX65KTr/5CyrEdytiOirYb0mNMLmFoHXzcZlhsFLTrtrftgBJK3VsWfJFzmu3WVC7bi7r+GZLSTsHeM3qBdt7KYkxdTHxa3J2VMnQ2v0ve28FtjKPNl+ClK7Jkbg/VH1L9lhZtDfXc6GCfGyh+8OKVm5WmMaUSytdotHsaUZBPozzLCuDi13u7Ywg3edZVCAkTD5F2vvELt3wdCOng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=impDZLhIbX1FWRMdS6aaOo9KCMk6hm5Z4PbsEmpiwqA=; b=nSumM8MiVHIWnwxPSLg4rUd14Kg2V0HFoJwizxPrY4zrds/YTuA0NcpySPqbIY6u1ne5ZVRRlEiBpoPYVcKBAAOUOiEhcDR6KMwsW3kOTCk3y4/yO1rjqy3vFJHadhe+ClFqKijygXlqXzQ134JR+JqfmOBcIv9blq+X9C3PbP2khUuJJKNPMHC88ccoYn7WVny4oTWlXPs/DIvFYn6aMZhYgxlNyfgKj7TNkO9tC3xjNnSCQunXnyhBWtxRZOiJd4t9hVJ2sA4pbfCZDbVwzILmT9JGA0S7rsqJWyVvwSoqpHeRdGedZ2uxtJPJd92huNoDtFLkvbWESz6QiXabhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=impDZLhIbX1FWRMdS6aaOo9KCMk6hm5Z4PbsEmpiwqA=; b=ip8qwXY5SCq1faNkPIW1lrUGCA5eW1JomgU8BhFbz7qe6Qjh4ijH/Ncx9G9AyVyu25DPQfKAnv8mFYSfCBYSCfqfowwN9+EGZ37nK5qPJ4tA9XhjiRM71pp/PBu9Mw2EPdio7Qj6KbJh5GkltAvVnNnYXo07L1DTaxueqaezK7o= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by PH8PR10MB6479.namprd10.prod.outlook.com (2603:10b6:510:22d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 18:38:03 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a491:8dcb:1259:9aff]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a491:8dcb:1259:9aff%4]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 18:38:03 +0000 Message-ID: Date: Mon, 14 Nov 2022 10:38:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: gprofng patch to review Content-Language: en-US To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , "binutils@sourceware.org" References: <603d55a9-e789-11e7-2cf0-1fde08874cdf@oracle.com> <423e14f9-6176-230f-aee3-83ce59fd4d7c@oracle.com> From: Vladimir Mezentsev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA1P222CA0010.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::12) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|PH8PR10MB6479:EE_ X-MS-Office365-Filtering-Correlation-Id: 439423af-6118-4806-cb6d-08dac66f5d5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cjC+rEuhoWAwimB4cCGgaVeAuc6SKl9ubbnaZgaGNNWb70pF5up0097XyS0/Zt5u5XUZSVKq49DwvdEdmLv0jsBsY6bIv7zYwuDm3IT3vW1A3a/2nI7AY6+5COIdICO1LgA5svJLlts9M2WO20QRvxLckdueifDtH1TjhgxcEy7flAMASMxu+CwJ0C4SBF7+EcPIfaJ/diAMZ9jqbXF9c8iynGRawpVKPS1T5jO4XoGo+KoS49m0IstiJsAhQ6C1gqtTddo13MQYFkt8+3C2xPrmGTYzcfezXq0KyUeqSb2ROw7rscG4lORlYFJNgmRj7Zr6fMfouBCP1scv04+votihVCStS5A3ltIIOOh5UzPNjJGvmg4Cl5uDUfphzLOXmXDc6a5fN1msadX/pFAI9DGiGU7yXjH4XvKzb+U+efw+RMh8yexSW5wKuZ4+rDnfmp9CV4OzKvXbSeEzagxUclCpeGvYUZQYAzTjlm5FNR9kfHZS3aIYjHN7thW+yKRcuPKBM800//wtzKXKf9q+eBGiXNdxIVvhlGMMHGnzqTJcQOO+4vRv03Oa6+vE34+sBPP2DNOXYenzuNlrM1SmmsM4TWhP/SbQoEGZyqhIR/k59Haz+jMLDvKsmTOFTf6GpuKQaOzL5xPgw9igI9uILQauD7NOsVnYSGjQhhZ64d+y4CGrOaad79DThzvSqv/sl7oziLEjpTQp8PBucrDY7vFUzKXAzL9FER5KoT0zf6/ksCT0I0tk5TOR1XIDgby78kUdiIQGJXG5ccPLNdA0+5l+4Rb/Yedr/YJT/Pw2WDg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR10MB4636.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199015)(41300700001)(186003)(5660300002)(2616005)(4744005)(36756003)(8936002)(44832011)(4326008)(316002)(54906003)(6916009)(66476007)(8676002)(66556008)(66946007)(38100700002)(31696002)(2906002)(3480700007)(478600001)(6506007)(53546011)(6512007)(6486002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGw5QzRtVmp6MjU1NklPMVFZNjN3Y1g5MWN1YU1JeHFkQ1ZtRXRsa0RQNncz?= =?utf-8?B?aTR6dUhjU1J6L2xsS1h6U0dKTmJhcFhFbXYza1pPQkUxa0xhK2N4SG4yYklv?= =?utf-8?B?cExhNFZFSnozNnhYak90eEV3R3BRMmRkRXUxSU5FUW9weHpOQzRaRE5hYUNj?= =?utf-8?B?ckJYSWttMVI5N0JQZ2VxVzN2RW0rakVFcGhTR29RQmg3YlV5TlE3UFFGT3N6?= =?utf-8?B?U1krektrSzhzVkxnUk5LR0ZSV0N2ZHA5Qmx5QWFuWTY1RUo5aHZIS2lQcDdL?= =?utf-8?B?T0lJWUc1dmhLRFBETWlLcUlPU2JRaEdMd2xtM1ZkM0NCQk9KUkRZSjFadlUx?= =?utf-8?B?cU5rbWllbFFIZGhhb3FGNjBOSlF5azBaRkZDUGMxOVZPb2dDaDRuNm9JQmtu?= =?utf-8?B?T2JUb3lJNnFIR21iNHBOajUwaHg3RmhkdUtUeVBFZGR5Nmg2ZXJuRGhHZDNv?= =?utf-8?B?dU9tenI0SFVaNGhiM2R5WFZ2dFEyYzk3UWNSakpZSDFDUFp2VmIyaExPYmd3?= =?utf-8?B?MUlYN3lzaDQweXFsVGNOM1NheHNiVWxiVnRTMlU1UHFqamZ3YktaaU1udk5p?= =?utf-8?B?UWJ2VDlocVBaRUlranRJVm9OVUVzVmZhaGg0cnMxWkVRMEZaUmNndUtXNG1l?= =?utf-8?B?Zjh0aWpZMkNsM25pUEJYSWpqTnliUjJMTkpHSm5OZVRNVzZKUkkvbk1mOHZ5?= =?utf-8?B?bnBpQ2FRVktvM3JZQTlrMzhkcjhFdEVUZkZuUDJkWXgyVXcyVnlhOFlTbHEz?= =?utf-8?B?ZkRFdTU4aTZjK0dQdWl1STVrSkt4YlZHSEdCWG0zblM4ZEsxaGJOcXJqdTF4?= =?utf-8?B?Ynd2Tng3VjNBM3VVQ0hGUW1NMloyekpFVHhLS1p6eEFYU29ZakNXaHdaTTgz?= =?utf-8?B?MFRsR1FpTGRpeTB6QmhOd0l5VVJvOGRHQkJka21iekpRZEN6UXFlWDN4dnRx?= =?utf-8?B?RDRqNGlQdWpkMEZVMDh0OS9aVVlBS1crSVF6UmhGdGt6SCtObng2OTVJWWZp?= =?utf-8?B?WnZSYlZNaXY0aFlNU0RkakdQTUpMY1QwQnc3ZzdZM2FnQTBremJRaGNndW1F?= =?utf-8?B?eDdZTkVwNENQM2p5ZWtMKytIbm5qeFBGV2dIUHEzTUFuV21hcEx2bmFzMGJn?= =?utf-8?B?OGJVeGZrT0JneWlaZnZQQVJOSkxmdkVSUERCRjJIa1FXMTFWQlNPaXhpKzR4?= =?utf-8?B?Y3l0NUxQakhXbDQ5eGtJaWJWaVVmVHhJRUk0cnpYVGM2cHJwem4vaSttOWcx?= =?utf-8?B?RFBsRzArMkovRDE5Und0d3FYNXV3d3ZkczVnV3R2bWNRdDE5U3dqTld6cFBk?= =?utf-8?B?YmFlNmZrd1NJbXZHODNoWTFjS3BPdGVQOS9GdlN5a2hJbEdQQW01QjcwVnZV?= =?utf-8?B?MkREZldYSkpTVCtkQW43WnEvZitkd3VSZEZKaXpxa3hmcHNHM040aEwrWmNE?= =?utf-8?B?K1g0S0wxSURuNU1qS1p6dU0zZE1kL0p5blFwL0FGemdPbXh2eEppWmRPMmpG?= =?utf-8?B?TXBETnc3bFV2RFJyT01uSUhRRHlRbGpKeTMwZjJod29FNGcxQ3k0alNDZXhz?= =?utf-8?B?RXB2eHhCMHhMcHlPMGM3Smp5bUMwT1Ewd1JCaE9JLy9PTWVsU1I5bVNrc1VO?= =?utf-8?B?VncwYUpyRDRvU1B6NHFxSVZITHVHUURwcmNnczFrVy92RlVYOW9kdjJRTXcz?= =?utf-8?B?WGRmZzhyLzBwOFY4UDVZSHgrMDRxRUI4SFRVdUxDZjRVTTJxcForMVdpYWZY?= =?utf-8?B?RzJDQUZVc0E0VzkraDRTa2pzT0dsVVN2dG9lZG5NZW1YV1JCbGQwMVNUUHJs?= =?utf-8?B?TVVUbWt6ME9vaS9jZVhQbUprMmtpRlZMb3pGaHpudVZhcFZiaWVqMFdDQm5H?= =?utf-8?B?Y1FIZEhqOEtGd3ZPa2d0MXkwNG5qUjBzNUJLdG0yMVRCcHQxWjNSdmp5TkxG?= =?utf-8?B?WjBHWm95cVNOKzdSV0RTMk1CVWgzK3ZnOU1LMnZCa0s3dW9BNlhJYkk3QUVw?= =?utf-8?B?V3FNU1ZISVBGQkh5QVRPS3lvVW1ZVXYrMjdmbVBiajEvSmVQQW5raXMxUzJR?= =?utf-8?B?cHdUNU1maDN3TTdqeVVkSmhnRktYaUtKaGhJNTgrRnVBZTM2cjc5WmxsbnlT?= =?utf-8?B?NFd0ZEFhVk5jTElXN2hEMERYU0MyNzJ1dUM5OGcxcHdHWmNZQUJ0QXFtWFZW?= =?utf-8?Q?hZ+vjAdcotruufkzS9iQ1t4=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ScYCqD+wCR9rJ4mf6hWBXv0fawxH3svziaWJJqQucxY/Z98y4y7mutAUpG7zNlS7aRtUOs8Q/Hn18PI+tpdrhIIafPQ97eJrXtcQ6DPDv2audT9wakCfNe2rbtvMPFpbXzDiEkb4btMr2gzrC+puE3z6Asb8dZN+gKwAKoeRR47A2MGSQvL6G30ggy7lo6s9AgIFnmPjnTkwkB9LDCDLoMsJ2gezkFJ4HvfnXmskbixHe8S3G4YE3yIg1jGnOsdJOhxT3lb53ESNRAero27Ntexf8K3l+X3LzSTKiIwMnkWLNy6YwH/4uo5goD/n1bo6IaaS2IPxpLCQwqmmby9K5dvJQv8DC/h/ZgTmDYSACY4/65HWOt9nI9qvim22fwRANpVHxxD03HyiCY9up/k2yoz/NRABdjLhKGrhJwJb4ACpYSsTXae5sanKQkUvq1kORcssHuzA2feKqAeRK8KAXvunPELzLLXomx4Z5JhLWgrdfmFQUHIb0W0IKBBSHa2ThTvzzI4iLUD4RItt+lssLfervSfThZBDlnLpQgKTxzvO4DeQSiuhak+WhZGFf5+tJI7lPGfBvT9l0e+5Db33gx4BkQ3srDMo3J/IJkbDKHC0Po4eWUNn5yYB0h9q8kRaAUxDHIgeHVbKxmrE5I5leFgAY260FRTi+ZknviU2xD84qWJzozevX5BZYqzE42rAAHLavPw7yk759kMIJGDxhu4IjG3GV62so57Ti9rB0hFORev7sjPhrxaIn5ipmNL8BD3l7bLC3TXweVAKhXL0ZCZpooL0cSEviGYoFWP121sGVcp4FKfxcBKKEzv4rZu4xFLf9KLoKSX8X9lvMfKbEw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 439423af-6118-4806-cb6d-08dac66f5d5d X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 18:38:03.8318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0t3ctfsaL3hckMrZo13xkdPJMfgVhBom6Cgy8QRM2Ek5EG8aitiqx924bM1zuFAphjFTh/J9byZXuQORNwBsiT8oReojKYik/vnl6Y9hfqo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6479 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-14_13,2022-11-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211140132 X-Proofpoint-ORIG-GUID: nqfqxhesT5AcHGjK_IPHqm4TYaSDhrfL X-Proofpoint-GUID: nqfqxhesT5AcHGjK_IPHqm4TYaSDhrfL X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Markus, On 11/14/22 03:22, Metzger, Markus T wrote: >> +#ifdef DBG_LT1 >>    TprintfT (DBG_LT1, "my_cpuid: __get_cpuid(0x%x, 0x%x, 0x%x, 0x%x, >> 0x%x) returns %d\n", >>          op, regs->eax, regs->ebx, regs->ecx, regs->edx, ret); >> +#endif >> >> >> >> I suggest to just remove TprintfT. This debug output is currently not >> used by anyone. > There are other Tprintf (no trailing T) in the ARM part. I didn't touch those > as it didn't fail on my box and I wouldn't be able to test the changes. > > Do you want me to remove those, too? Untested. yes. Please remove those too. Your Arm build will fail if you use this file. Thank you, -Vladimir