From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by sourceware.org (Postfix) with ESMTPS id 2D8F2385275E for ; Mon, 13 Jun 2022 14:55:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D8F2385275E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oo1BO0CB05w2JxNVGzV8b9jNz6/Xq72Ge39FwlzE6YpX508qAk2fCHuF9DTQbSJTPwNvNNSY+k4USCzgv6tg2bwXWkXwbiMtr7zaA88hFz4ynIjbVyo54O6yLQfXp8dXxCm+Bum/eqa+fha+sF21I1vlCcRkMFC4Vc0FG6YhPbah6vV0t06zifgLMc2vCEu2PgUrl0Bt9F5S33RGJL/b9vWsrFQnuv2O4J9cNHpx/PaSG3OiRpPE7IygpTW82jm1JvHwtGaXkJPxWhG2ZZN4hgGjJKxzWdQ8NIunmfGxfo15Z234mzQTOoBmIOrfKTQ5r3URneTtvHbGiEdixL9eaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OAH9tYlZ2MsFHZkqn0agXJdCW6iK7+2wNp6kafgDCCY=; b=ieTnmRmZSnCHzU4+sZBa9tyDSFrXGeVqA+dq8U9vCzJojFdHk8kjSoIEBgZYi+0swmnQrFNKMfbVpUWrtbW0XLnIm2QYO6Rt/jt8LiyshOGoHGzNAGONrPQEExxjwhO0tOyJC5RJiRNHVF2CXmvcZFrWulUlrkbWktBtGXe5vwQhGr37l+l6mkC9YcBUd0CNdm2vESrOZl3IgOG4MhfVBGw7y71xCpp+aHph+1jrbdBZYJhIWefnsxyP95VuwP0tkpBreVSe8gfSVbUbY17oGHyX2fTeS4Uo+ovkThMbox0tnbGdhu57plMeStT8fA2IEL0QwLAALB5IZkmDMkmRaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6460.eurprd04.prod.outlook.com (2603:10a6:10:10f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Mon, 13 Jun 2022 14:55:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5332.020; Mon, 13 Jun 2022 14:55:42 +0000 Message-ID: Date: Mon, 13 Jun 2022 16:55:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 4/4] x86: replace global scratch buffer Content-Language: en-US To: "H.J. Lu" Cc: Binutils , Andrew Burgess References: <6fd28ca0-2af4-7335-18d3-31036dea7a4f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0025.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::38) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8930590-40d5-4acb-89d4-08da4d4cc981 X-MS-TrafficTypeDiagnostic: DB8PR04MB6460:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IL/mwbhCo5XfFQmDZgn8DZMsTitvh0qSzPitWPnHxnqusyzD2FiUpSVGW8ZSGFO5qOYTT/XAjj03xPQRLe5MCffFg2VwRosktBGgJfqUhWelLy96c6b+8jFupNyPp1Z37w5XPzwJw4yWNTjUQWw9D+xGxuq4BV9PIxJE9v709nX+f5+z2FbE7lnFtpP1nUR9KnbdHgcwqYZ2FWkF3yF9SHiO7AZg+e2+/DAQQ9bwXdNRm3b6nzmMVe8TeUZt2GHqGGaoTN8kZuCuha9LkQbGmOf2ygOVQBDggQ5ci4LdPUvQKrkOiM6b5agGZ1zzIx84dn0SdctYisKg7c5CbiPk666kCmvhoCiYwg01ZHcJOYmPz5vHEUMU55ZjsanW/fCZDzZvIPRALbtT4OU2XokIlI5uPLPzRy4M8fgwrZKQOCILz2UDvHKEQ928Jq4TnFy7LW1WOY/fkVqZu37+klcYk+H9qNYlT8e+YUOBbrZr371QVUA55zGhyhWsDvtZQLjzvsNmUgDnYrjN3nIcQdZ5FpUcMhNsIbbCzQacDeO9omqlcC9RQzSpPOr6kv/grbgZuy8qZ5GlAA7HCIgQkGS7ZLdLHANbMi2gntSnkiIWxTev7FopHvfqswwVVNQxho+rXMgph/npyjybbnkxYxIIKYGT99x2gVYuzywHLjCei+f4PECI91JKqeUcky761di1c4KJr87VTJjVgEBipawpmUrW5s918YnnbnYQFqkDm29k1PSg2Ct64Qo1UJAVb/pm X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(31696002)(6512007)(26005)(53546011)(6506007)(54906003)(2616005)(66946007)(66476007)(66556008)(316002)(6486002)(86362001)(6916009)(508600001)(186003)(83380400001)(38100700002)(31686004)(5660300002)(8676002)(8936002)(2906002)(4326008)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG1TRHd0T1lhQnJHbzcxTnBRZXBwVnpwc0Q3eWVXT3lvZ2J5N28veFBFellq?= =?utf-8?B?bDFsNTlnTFRwLzJxZVBmOEQxWGx5QVd5djI3c2RBbTgzb2FvbUhlZkU4Y0RU?= =?utf-8?B?a0ZOLzdObkk4aVRvWGtDZGR3RytiUzMwbmFwWE83QzJjQ3JMa1BFa3NiVExx?= =?utf-8?B?ZEtSajExOUtlcE1kM25jdlF3UGwwOEZFRjFQZElQUWJPWVY2Ykt3TDJjR2Fy?= =?utf-8?B?aDY0SzVFdnhZRmxvSllObTh2OHJuVlpzWVZYOFJDSU96S3Fmd1E4UGxlSzNk?= =?utf-8?B?TFRvTnQyZGtCL1VpU2pUcFl0YlhyTjdMRUxZVFRFZmRmM0xRcjFiWGVZdkJu?= =?utf-8?B?ZnlYOWhwVXkzTWduYnhDYkNZcm5weWlZb0tBeHh2WjlySmVHYS9NT0ZPSTk5?= =?utf-8?B?L1hUZGR2MmRQTWR1Yk1ub2l3SGtLUExYbUE4T3JobERNbkxjRUlDM05aL3dO?= =?utf-8?B?VzF5QTAzN0xiZUFqVGs3U2V2aFBXRUc2azFpbVl1MEhWcmRYL3VlaU9CK1Qw?= =?utf-8?B?VXB5NEdiM3BWckdTVGplMDA3UG02aWZ4NzhwbmlqQi9SOENtak56QmxGbHcw?= =?utf-8?B?aGo3NXRDNGpaVzQ3WGlmM29FUkZYdlA4ZXhWQ29qSXdLd0pOVXY2U0VScXlp?= =?utf-8?B?Y20veko2UjBFeFdLbEMwNUo1bEgvREk0KzhKRjBRTkdGaFJVbkFTVEh5R2ow?= =?utf-8?B?cGRBSy9tRzFob29jOG5meU50aWFhcm1KRDFoYVNhYkEyRVJsQ3RGOXdpU0xP?= =?utf-8?B?eGZZVnlYZnVDclovM0Z2OHhFU0c0Rm1kMXFDSjdNUXpIMVNGQkd1cVA3T0Y3?= =?utf-8?B?c3NOQ29xZEpnSmpKVFM3UmFCNXNPeFhUeTRmd3AwUnc5K29RNTVFeEJuUFVw?= =?utf-8?B?Q3ZNeVAzMURqL0NyNUQybGluWUpFV2JjM3YrR3RFSU9kclBCSTJpdTRHVXpU?= =?utf-8?B?QlYveGduSUUyWXEweGJiTjhuR2F3SUNEcVpWOVlNWlhLdWdaZnR3QVRFQWtp?= =?utf-8?B?Ny9JK21TZ3FRNng5Ry9UdkdMWklpdzRiNUNYMHh5T3RRaVFRbXhHRGY0UHZ5?= =?utf-8?B?WG50ODU0OFVOVHJDQ2ZJZDZIdjdmeWpVcE9qd25rVSt0UEw0Sm1zSk5OU245?= =?utf-8?B?UGJrVitaYk03b0hkeGVCZjF4TGRwUVQ5Y3RjZlU1SjBuMVNyV0IwUGFZRXFZ?= =?utf-8?B?cFJvY1dLM0xYbEJmYXFhenlqMmg3bHp6Q2JUVkxxQmpZM1c0Qmh2V09SZVox?= =?utf-8?B?VFQ1QkFOQnR4YXdXSGF6R254OGpaRlhuRDZla0dtQ1p6UEhFc09QNDVqdm5G?= =?utf-8?B?bjh6NDJLdEZZN0padTBiVUMwcTFmM3FGU1BXcHRFKytGcG43YnJmbVRhWXBE?= =?utf-8?B?N1dxaTNaQlYwZ3RBeEp0Nm9oMW0rMnBtcTJxYXpZTDBBYmVSeXVnd2NyU1Fs?= =?utf-8?B?WEtPQjh5MU5uSytJbkRRTkpkaTFlWDlySDRxZWtqNzlSeWNoQXFsMEVMRGdh?= =?utf-8?B?MUxENkpCa2tlWEl3eTV0bEFNNnM0djVuVnd2SS9qMUZGeFVZWVp6RUhmQmZz?= =?utf-8?B?SmZqSUNhQ1hBZytIYU1tM3R2amV0YXU4VGhCK3ZodGpmUDlXeUduSHpsMzBS?= =?utf-8?B?VWFxcm4yR3ExTEJQWlF2enVua3o2SklhbkkwaGcvaGdGVy9pVDZPQ3M3dmRl?= =?utf-8?B?Ym56U043bHFsdzRWT2hUbjhIYkEyaE5wUExod1M2Z1RmVEJmdnVRV2szL3l3?= =?utf-8?B?bWtnK09wSDUrZ2g1aU5mOWxYMXM4KzBiRVF6WjYzcGxaTEt6K2c3Ynh0Z3BI?= =?utf-8?B?QmdFME5yRHAvcit1MjVGOHFHY0xPckVKL3N2TDU2UkRVOWU0VzB4eUdBTUp2?= =?utf-8?B?V2svdDdKZVNZYjlHTmU0YVorejR3ZUs5UVNIbEl0WkZaREc0azliaDhDVk9H?= =?utf-8?B?SlZTOXlEVWtXSCs4U0lhWUtGemd6VW9Ha0x6aDBBcit5OXp3ejY1SU8rYlh0?= =?utf-8?B?WUgyRDg3VzhLTFFVZG93RGgxZHN0LzM4dUdHL2hVUllocDRxS2JtQ0Y4Q3Qx?= =?utf-8?B?TUJ4cHg1VDhQaFM5Qnd6UnU1a1lXRSs4UUNEbjFGNUhuSWZmb1pDYVcwUHg2?= =?utf-8?B?OFZDdWFSWlFWdEFGOFZmVUF1Q3M5eUhxdGdOVmMydUFVSkJQVm5mOHZaY3Np?= =?utf-8?B?ZEpFSDZlN1pKdlF2ZUpIWHRUVFJHTWIrOTJHR2dmYllGdE1oTTk2WENlR3NL?= =?utf-8?B?bklMK21qaEhJNzBkMHc0ME44L1VPWXA3WHRFVjl6TVY4aVdKZW5NOUhIUG8z?= =?utf-8?B?UUlGKzgwMEFNTGlHYnJhMVlBUTdoWVhuUXpnN2FXSXpCcXBCQ29JQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8930590-40d5-4acb-89d4-08da4d4cc981 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 14:55:42.1784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pzbWpm1KoqY03w3ZsGk/ELodaL5iLkeWa6d5BHAyTd4mq+dV+oI66SeC3hSYKSKjaJbFu8q9VMsElbf0+Qix0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6460 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 14:55:47 -0000 On 13.06.2022 15:59, H.J. Lu wrote: > On Fri, Jun 10, 2022 at 6:36 AM Jan Beulich wrote: >> >> With its movement to the stack, and with the subsequent desire to >> initialize the entire instr_info instances, this has become doubly >> inefficient. Individual users have better knowledge of how big a buffer >> they need, and in a number of cases going through an intermediate buffer >> can be avoided altogether. >> >> Having got confirmation that it wasn't intentional to print memory >> operand displacements with inconsistent style, print_displacement() is >> now using dis_style_address_offset consistently (eliminating the need >> for callers to pass in a style). >> >> While touching print_operand_value() also convert its "hex" parameter to >> bool. And while altering (and moving) oappend_immediate(), fold >> oappend_maybe_intel_with_style() into its only remaining caller. Finally >> where doing adjustments, use snprintf() in favor of sprintf(). >> --- >> While doing the conversion I came to notice that print_operand_value()'s >> "hex" parameter has only ever passed "true" to it. I wonder why this >> parameter still exists. >> > > Andrew, > > Do you have follow-up patches to pass "false" to print_operand_value? I don't think that's related to Andrew's work. Even when looking at plain 2.37 (which I'm sure predates any of his work) I see only 1 ever passed as the argument. Going very far back (2.16) I see varying arguments. I therefore wonder whether the parameter simply wasn't cleaned up when the last party (possibly) passing 0 / false was removed / replaced. Jan