public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Waterman <andrew@sifive.com>,
	Jim Wilson <jim.wilson.gcc@gmail.com>,
	Nelson Chu <nelson@rivosinc.com>
Subject: [PATCH v2 43/65] RISC-V: use is_whitespace()
Date: Mon, 27 Jan 2025 17:34:44 +0100	[thread overview]
Message-ID: <b813bd6e-0175-4b6f-96b4-8a1c6597853f@suse.com> (raw)
In-Reply-To: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com>

Wherever blanks are permissible in input, tabs ought to be permissible,
too. This is particularly relevant when -f is passed to gas (alongside
appropriate input). Switch places already checking for tabs to use the
macro, too.
---
v2: Also replace ISSPACE() and a strspn() use.

--- a/gas/config/tc-riscv.c
+++ b/gas/config/tc-riscv.c
@@ -2484,7 +2484,7 @@ parse_relocation (char **str, bfd_reloc_
       {
 	size_t len = 1 + strlen (percent_op->str);
 
-	while (ISSPACE ((*str)[len]))
+	while (is_whitespace ((*str)[len]))
 	  ++len;
 	if ((*str)[len] != '(')
 	  continue;
@@ -2548,7 +2548,7 @@ my_getSmallExpression (expressionS *ep,
 
       /* Skip over whitespace and brackets, keeping count of the number
 	 of brackets.  */
-      while (*str == ' ' || *str == '\t' || *str == '(')
+      while (is_whitespace (*str) || *str == '(')
 	if (*str++ == '(')
 	  str_depth++;
     }
@@ -2577,7 +2577,7 @@ my_getSmallExpression (expressionS *ep,
   probing_insn_operands = orig_probing;
 
   /* Match every open bracket.  */
-  while (crux_depth > 0 && (*str == ')' || *str == ' ' || *str == '\t'))
+  while (crux_depth > 0 && (*str == ')' || is_whitespace (*str)))
     if (*str++ == ')')
       crux_depth--;
 
@@ -2844,7 +2844,7 @@ riscv_ip (char *str, struct riscv_cl_ins
   /* Parse the name of the instruction.  Terminate the string if whitespace
      is found so that str_hash_find only sees the name part of the string.  */
   for (asarg = str; *asarg!= '\0'; ++asarg)
-    if (ISSPACE (*asarg))
+    if (is_whitespace (*asarg))
       {
 	save_c = *asarg;
 	*asarg++ = '\0';
@@ -2891,7 +2891,8 @@ riscv_ip (char *str, struct riscv_cl_ins
       for (oparg = insn->args;; ++oparg)
 	{
 	  opargStart = oparg;
-	  asarg += strspn (asarg, " \t");
+	  while (is_whitespace (*asarg))
+	    ++asarg;
 	  switch (*oparg)
 	    {
 	    case '\0': /* End of args.  */
@@ -3520,7 +3521,7 @@ riscv_ip (char *str, struct riscv_cl_ins
 	      if (reg_lookup (&asarg, RCLASS_GPR, &regno))
 		{
 		  char c = *oparg;
-		  if (*asarg == ' ')
+		  if (is_whitespace (*asarg))
 		    ++asarg;
 
 		  /* Now that we have assembled one operand, we use the args
@@ -3554,7 +3555,7 @@ riscv_ip (char *str, struct riscv_cl_ins
 			      ? RCLASS_GPR : RCLASS_FPR), &regno))
 		{
 		  char c = *oparg;
-		  if (*asarg == ' ')
+		  if (is_whitespace (*asarg))
 		    ++asarg;
 		  switch (c)
 		    {
@@ -4963,7 +4964,7 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
   else if (strncmp (name, "arch,", 5) == 0)
     {
       name += 5;
-      if (ISSPACE (*name) && *name != '\0')
+      if (is_whitespace (*name) && *name != '\0')
 	name++;
       riscv_update_subset (&riscv_rps_as, name);
       riscv_set_arch_str (&riscv_rps_as.subset_list->arch_str);


  parent reply	other threads:[~2025-01-27 16:34 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 15:23 [PATCH v2 00/65] gas: whitespace handling Jan Beulich
2025-01-27 15:26 ` [PATCH v2 01/65] gas: consolidate whitespace recognition Jan Beulich
2025-01-31  6:02   ` Hans-Peter Nilsson
2025-01-31  8:36     ` Jan Beulich
2025-01-27 15:27 ` [PATCH v2 02/65] gas/obj-*.c: use is_whitespace() Jan Beulich
2025-01-27 15:43 ` [PATCH v2 03/65] Alpha/EVAX: use is_whitespace() / is_end_of_stmt() Jan Beulich
2025-01-27 15:44 ` [PATCH v2 04/65] arc: use is_whitespace() Jan Beulich
2025-01-27 15:50 ` [PATCH v2 05/65] Arm: " Jan Beulich
2025-01-27 16:31   ` Richard Earnshaw (lists)
2025-01-27 16:55     ` Jan Beulich
2025-01-27 17:05       ` Richard Earnshaw (lists)
2025-01-27 15:50 ` [PATCH v2 06/65] aarch64: " Jan Beulich
2025-01-27 16:31   ` Richard Earnshaw (lists)
2025-01-27 16:06 ` [PATCH v2 07/65] avr: " Jan Beulich
2025-01-27 16:07 ` [PATCH v2 08/65] bfin: " Jan Beulich
2025-01-27 16:08 ` [PATCH v2 09/65] bpf: " Jan Beulich
2025-01-28  9:21   ` Alan Modra
2025-01-28 10:31     ` Jan Beulich
2025-01-27 16:09 ` [PATCH v2 10/65] CR16: " Jan Beulich
2025-01-27 16:10 ` [PATCH v2 11/65] cris: " Jan Beulich
2025-01-27 16:22   ` Hans-Peter Nilsson
2025-01-27 16:12 ` [PATCH v2 12/65] CRx: " Jan Beulich
2025-01-27 16:13 ` [PATCH v2 13/65] C-Sky: " Jan Beulich
2025-01-27 16:14 ` [PATCH v2 14/65] d10v: " Jan Beulich
2025-01-27 16:14 ` [PATCH v2 15/65] d30v: " Jan Beulich
2025-01-27 16:15 ` [PATCH v2 16/65] dlx: " Jan Beulich
2025-01-27 16:16 ` [PATCH v2 17/65] Epiphany: " Jan Beulich
2025-01-27 16:17 ` [PATCH v2 18/65] fr30: " Jan Beulich
2025-01-27 16:19 ` [PATCH v2 19/65] ft32: " Jan Beulich
2025-01-27 16:20 ` [PATCH v2 20/65] H8/300: " Jan Beulich
2025-01-27 16:20 ` [PATCH v2 21/65] HP-PA: " Jan Beulich
2025-01-27 22:50   ` John David Anglin
2025-01-28  7:19     ` Jan Beulich
2025-01-28 18:19       ` John David Anglin
2025-01-27 16:21 ` [PATCH v2 22/65] kvx: " Jan Beulich
2025-01-31 12:34   ` Paul Iannetta
2025-01-27 16:22 ` [PATCH v2 23/65] LoongArch: " Jan Beulich
2025-01-27 16:23 ` [PATCH v2 24/65] m32c: " Jan Beulich
2025-01-27 16:23 ` [PATCH v2 25/65] m32r: " Jan Beulich
2025-01-27 16:24 ` [PATCH v2 26/65] M68HC1x: " Jan Beulich
2025-01-27 16:25 ` [PATCH v2 27/65] M68k: " Jan Beulich
2025-01-27 16:25 ` [PATCH v2 28/65] M*Core: " Jan Beulich
2025-01-27 16:26 ` [PATCH v2 29/65] metag: " Jan Beulich
2025-01-27 16:26 ` [PATCH v2 30/65] MicroBlaze: " Jan Beulich
2025-01-29 23:56   ` Michael Eager
2025-01-27 16:28 ` [PATCH v2 31/65] MIPS: " Jan Beulich
2025-02-03 14:07   ` Maciej W. Rozycki
2025-02-03 15:52     ` Jan Beulich
2025-02-03 17:50       ` Maciej W. Rozycki
2025-02-10 22:17         ` Maciej W. Rozycki
2025-01-27 16:28 ` [PATCH v2 32/65] MMIX: " Jan Beulich
2025-01-31  6:18   ` Hans-Peter Nilsson
2025-01-31  6:33   ` Hans-Peter Nilsson
2025-01-31  6:54     ` Jan Beulich
2025-01-31  7:05       ` Hans-Peter Nilsson
2025-02-03  6:54   ` Hans-Peter Nilsson
2025-02-03  7:30     ` Jan Beulich
2025-02-05  6:22       ` Hans-Peter Nilsson
2025-02-05  7:14         ` Jan Beulich
2025-01-27 16:29 ` [PATCH v2 33/65] mn10200: " Jan Beulich
2025-01-27 16:29 ` [PATCH v2 34/65] mn10300: " Jan Beulich
2025-02-07  6:55   ` Alexandre Oliva
2025-01-27 16:30 ` [PATCH v2 35/65] Moxie: " Jan Beulich
2025-01-27 16:31 ` [PATCH v2 36/65] msp430: " Jan Beulich
2025-01-27 16:31 ` [PATCH v2 37/65] nds32: " Jan Beulich
2025-01-27 16:32 ` [PATCH v2 38/65] NS32k: " Jan Beulich
2025-01-27 16:32 ` [PATCH v2 39/65] PDP11: " Jan Beulich
2025-01-27 16:33 ` [PATCH v2 40/65] PicoJava: " Jan Beulich
2025-01-27 16:33 ` [PATCH v2 41/65] PPC: " Jan Beulich
2025-01-27 22:36   ` Peter Bergner
2025-01-27 16:34 ` [PATCH v2 42/65] pru: " Jan Beulich
2025-01-27 16:34 ` Jan Beulich [this message]
2025-01-27 16:35 ` [PATCH v2 44/65] rl78: " Jan Beulich
2025-01-27 16:35 ` [PATCH v2 45/65] rx: " Jan Beulich
2025-01-27 16:36 ` [PATCH v2 46/65] s12z: " Jan Beulich
2025-01-27 16:36 ` [PATCH v2 47/65] S/390: " Jan Beulich
2025-01-30  8:38   ` Jens Remus
2025-01-30  9:11     ` Jan Beulich
2025-01-27 16:37 ` [PATCH v2 48/65] Score: " Jan Beulich
2025-01-27 16:37 ` [PATCH v2 49/65] SH: " Jan Beulich
2025-02-07  6:54   ` Alexandre Oliva
2025-01-27 16:38 ` [PATCH v2 50/65] Sparc: " Jan Beulich
2025-01-27 16:38 ` [PATCH v2 51/65] spu: " Jan Beulich
2025-01-27 16:39 ` [PATCH v2 52/65] C30: " Jan Beulich
2025-01-27 16:40 ` [PATCH v2 53/65] C4x: " Jan Beulich
2025-01-27 16:40 ` [PATCH v2 54/65] C54x: " Jan Beulich
2025-01-27 16:41 ` [PATCH v2 55/65] C6x: " Jan Beulich
2025-01-27 16:42 ` [PATCH v2 56/65] v850: " Jan Beulich
2025-01-27 16:42 ` [PATCH v2 57/65] VAX: " Jan Beulich
2025-01-27 20:46   ` Jan-Benedict Glaw
2025-01-27 16:43 ` [PATCH v2 58/65] Visium: " Jan Beulich
2025-01-27 16:43 ` [PATCH v2 59/65] wasm32: " Jan Beulich
2025-01-27 16:44 ` [PATCH v2 60/65] x86: " Jan Beulich
2025-01-27 16:45 ` [PATCH v2 61/65] xgate: " Jan Beulich
2025-01-27 16:45 ` [PATCH v2 62/65] Xtensa: " Jan Beulich
2025-01-27 16:46 ` [PATCH v2 63/65] Z80: " Jan Beulich
2025-01-27 16:46 ` [PATCH v2 64/65] Z8k: " Jan Beulich
2025-01-30 10:16   ` Christian Groessler
2025-01-27 16:47 ` [PATCH v2 65/65] gas: suppress use of ISSPACE() / ISBLANK() Jan Beulich
2025-01-28  2:50 ` [PATCH v2 00/65] gas: whitespace handling Hans-Peter Nilsson
2025-01-28  7:40   ` Jan Beulich
2025-01-28 14:47     ` Richard Earnshaw (lists)
2025-01-28 15:00       ` Jan Beulich
2025-01-28 15:27         ` Richard Earnshaw (lists)
2025-01-28 15:25     ` Hans-Peter Nilsson
2025-01-28  9:59 ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b813bd6e-0175-4b6f-96b4-8a1c6597853f@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).