From: Pedro Alves <palves@redhat.com>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Yao Qi <qiyaoltc@gmail.com>,
Alan Modra <amodra@gmail.com>,
Ulrich Weigand <uweigand@de.ibm.com>,
binutils <binutils@sourceware.org>
Subject: Re: [PATCH, v17] Add support for setting disassembler-options in GDB for POWER, ARM and S390
Date: Fri, 24 Feb 2017 17:25:00 -0000 [thread overview]
Message-ID: <b93f3c4a-25fd-7d7a-623a-1d536acf7ed9@redhat.com> (raw)
In-Reply-To: <b501b4af-dcfd-666d-3572-e4392a24def3@vnet.ibm.com>
On 02/24/2017 05:13 PM, Peter Bergner wrote:
> if (valid_options->description != NULL)
> {
> ...
> }
> else
> {
> size_t i;
> fprintf_filtered (file, " ");
> for (i = 0; valid_options->name[i] != NULL; i++)
> {
> fprintf_filtered (file, "%s", valid_options->name[i]);
> if (valid_options->name[i+1] != NULL)
> fprintf_filtered (file, ", ");
> wrap_here (" ");
> }
> fprintf_filtered (file, "\n");
> }
>
Yup, that looks fine. (with spaces around the '+' operator).
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-02-24 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 21:23 Peter Bergner
2017-02-23 12:26 ` Pedro Alves
2017-02-24 4:58 ` Peter Bergner
2017-02-24 15:06 ` Pedro Alves
2017-02-24 17:13 ` Peter Bergner
2017-02-24 17:25 ` Pedro Alves [this message]
2017-02-24 17:28 ` Peter Bergner
2017-02-28 11:24 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93f3c4a-25fd-7d7a-623a-1d536acf7ed9@redhat.com \
--to=palves@redhat.com \
--cc=amodra@gmail.com \
--cc=bergner@vnet.ibm.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).