From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1A1353858D38 for ; Mon, 12 Feb 2024 17:01:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A1353858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A1353858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707757301; cv=none; b=FMjb9IzTS25MbzT/zaMIhJpSqt9AKkyWn50AzJ1tby8W8iAS5YyO3TZwSXxmjJhAgNwYAg2VfXBc48joWKDF5lsLW/C/xyj/WuX5creCqhgbvG7qWTeUYJx7xTPyf4GH3qUVg1R2i9fQHN3KhgZO5TuCMG0gl0uBWS6sPdp+KwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707757301; c=relaxed/simple; bh=dKoASlfBCjOsAb6eO1rLMPoaduaN2B812P23BORGp+w=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VlrDZemSjgKXiIYpiz1IQmTJAV3ZylT0Zz1qAzGhyQwrw2PfvpeKdV1uGLf7My7/osdBCATUNYquPyi0mMPtUnKGG5GWoWtYK4gpIS/gfZjuL3U567OfKVfq7Iak6lOuUOiFwiKi9VchMGIq5ZbolUs7M0hBDVxFBH2lo1WNW8Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707757299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j/3H6OXRh9JoY27l09cPPtfEx8t9a/gjgm19Dj9j4B4=; b=bwEM45oyv2FQ1WdwWKmJeoLAJtRPuB03a925NpwCNGB2o/hE022nJnFQE8zmCJJ8fxIffZ TIj8/QQCgSlNr0Pm/HolPASgUSr3ry+lX9CrH5z7O0OwgbJcDhaQ8quwPfgeezUNiH7+QB asqWWqwuCt23/TRg2mrQjuTNspBZ5+U= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-3o3HXlxgMsKRU4CPv55yRg-1; Mon, 12 Feb 2024 12:01:38 -0500 X-MC-Unique: 3o3HXlxgMsKRU4CPv55yRg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6800a9505ddso657826d6.3 for ; Mon, 12 Feb 2024 09:01:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707757297; x=1708362097; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j/3H6OXRh9JoY27l09cPPtfEx8t9a/gjgm19Dj9j4B4=; b=MFSyJXdLUAmh7tu2hjG7huw1FjxEP9a0jnTkp5aGKxYsP5opvoadnAlVho3bglNLf/ 6j70Y+0jG0qGtdPzyql8EC5YcWu7r8S99iupgL+HkU7LCciLMdofnCGGC0yZeFw/uHCV 7Z9xEut+UNRUgUbGYHMSrZeTfaYCi3dpDBvi8LCSHGu4JL4xOuY4mG7eiPqq4dGTd8ap vlz9xD7YdvYtUixVxXDG/qmF/Jd8+9qsKwIjhmQ9JSIzkc2eus+2v+BB3de3zFTOoEAx wm0cW6idkjEiVBoewFvmOFBeTs2cWeHB1OpVrC81Ilw8cCeg3ZGeKmoXF9JKkm5cNyQ+ U0kg== X-Forwarded-Encrypted: i=1; AJvYcCU4wx9/iDgcN5/2YB4TBBBlknT6GhWFP0HM6k4wbC5u8t4RJ6/IEq2svlkvN1AGcF15d2w2CPGkP38CoyFpjWcFn6X8A2mldA== X-Gm-Message-State: AOJu0Yy/4/YWun39hzLAZN8IUPZgfvdVF2cZb9YWQaZaXqm1PRWdPw5x Qz35YlBzcik3NaXtmSIuLpJJ2RmsaTAlcxkFuXTzIEpb1WtkQ1N9zoaqrtAIR6yR8dCYPojlZzZ IIdA2ja9DOtw9aHnvjOUMni1vsdTsAxU1bz905jfy8qqrgAKpSiwIxLK5LHuJ40Q= X-Received: by 2002:ad4:5be5:0:b0:68d:147b:edf with SMTP id k5-20020ad45be5000000b0068d147b0edfmr2925717qvc.32.1707757297110; Mon, 12 Feb 2024 09:01:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKGdqnPoYI98rqZN3QPfl+ELdW8Ha5VPZFia1ilCuT9bZgI1T0MbKnleRjc7eK3JIHf4eRfQ== X-Received: by 2002:ad4:5be5:0:b0:68d:147b:edf with SMTP id k5-20020ad45be5000000b0068d147b0edfmr2925670qvc.32.1707757296622; Mon, 12 Feb 2024 09:01:36 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXz7lLMMsa6PdSc4t80k74tkAqAPtGYQaizpX93FbrTGIVBf1ViQHtnDLXGoxKI6yavYOcTYjRxeTQydyd/QMB4+ls9SgUFzQ== Received: from [192.168.1.5] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id ng3-20020a0562143bc300b0068d14adaab2sm332128qvb.11.2024.02.12.09.01.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 09:01:36 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 17:01:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/1] objdump: Add callx support for BPF CPU v1 To: Will Hawkins , binutils@sourceware.org References: <20240209180734.443763-1-hawkinsw@obs.cr> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <20240209180734.443763-1-hawkinsw@obs.cr> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Will, > First time patch submitter but long time GNU enthusiast. Thank you for > all the work that you all do to maintain these vital pieces of software > for the community. Welcome on board and thank you contributing. > I tried very hard to follow best practices for creating this patch > submission but I am sure that I did something wrong. Please let me know > what I can do differently or better. No, no, what you did was excellent. My only suggestions is that with your v2 patch you consider adding a new assembler test (or extending an already existing one) that checks that the instruction can be assembled and then disassembled. For example you might like to add it to gas/testsuite/gas/bpf/call.s (and the associated call.d file for the disassembly). Cheers Nick