From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2052.outbound.protection.outlook.com [40.107.14.52]) by sourceware.org (Postfix) with ESMTPS id 60FF63858D33 for ; Fri, 31 Mar 2023 10:07:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60FF63858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwfPMXqoiRky82SnTkL8RmgoDwxsf82ZSp9iXIvj2WRnuhUV8sEXig7YeDCeuU0RpyDYyVrUAA/xya/8RbAfoMrDHVFzOcdzHaDmDvLJhKXaZwmLz+oNS1uosvejg1Vm3OvrBXSRnsgGYSMhJ2ypF+JmwowkNwE1FTCVNiVTSl9R2W3uD06cMWErzH1pXNx0iQEd3EI+dxvoI4ayKYUXFXOSRbz5aI+u5x460jdZc/m53E0Rf/2x2GOtLo5SSxBCWDpjnFqkMVKfgcW5A2WdGAWGRTo6IpZCahSAis5xeI2Tj/3a37ESx29wM65YLzcVPT+jZgqtgZx0OJ3n1mdvNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cDJsrtkqPaGtPkDCzoXtQd0YbTs3jwB6n5FrfYaKGRk=; b=RY3UuJN7dZzuyvtskumDDDJuW0RK24/3M03iRmBUB2jSjv5BnBegb9eCoZ477eWGzVIYFPLgkQkwOOS1POeJOWw66GAXjpQscw0eflXfV7rkhr5pH0ZGZFPY8gOWdP6A9t6xaOyxSeJs6X+ARoEi6JACfo+y4kRltEKj57u4YB+fOeJaHU8vzNK/NPGXvZFvovm+Z2Sj+FjV02JVFc6m21smO5sd6LUJZ8KgkIZXBaJmkTf0u+ZQpciDHhjWZwdHfAkkl11oFNGP/yChMfQ0nVJLyzl0HzQ5xhMREIi2AGbJz6ZIoYKN+IvjSFN/3giowyl83Dmed1dg06J0l0E88Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cDJsrtkqPaGtPkDCzoXtQd0YbTs3jwB6n5FrfYaKGRk=; b=2edDlMx/zGGbL/V82EPbASTY8sjw8yEYapwiD+bNo/aBwqcde2NkrvxjXaUG6Lsa7g27ZFefCNTsAcdSkjUtnRaWNHDs6wnYeT4VerxT8BoW4SqUhI814jMh7Xdzm871pQHspex6O4mpZyjH5VkMTGvrHVByawtCcAcGVsS50hNS4etjATHmsWpYCxng0vBUMuIFT6l2hK/vdj7JSvlCQHt9nMMI/t/tetqR6ZKzIoNc9yNiMR8p4jGJWspzETmHxZMO0ni1kXscbBx28YewgzauP25b3M5J+Uc/GRUAv5V4hgYVm4y85vTiG2XuX0exEU7MmFU0myoqSqG2aguQAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9106.eurprd04.prod.outlook.com (2603:10a6:102:227::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.35; Fri, 31 Mar 2023 10:07:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Fri, 31 Mar 2023 10:07:06 +0000 Message-ID: Date: Fri, 31 Mar 2023 12:07:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH 3/3] gas: document that get_symbol_name() can clobber the input buffer Content-Language: en-US To: Binutils Cc: Nick Clifton , Alan Modra References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9106:EE_ X-MS-Office365-Filtering-Correlation-Id: ed74f95e-0ee4-449a-149f-08db31cfaeb2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S+1pjJeA5xe1f09MC5tqxsj2YfGzRJSHbze+Ci2H7X6XuFERlFFpVEdlnmKXr8iZdAynHFtY0b4b5BdePZ2WjUB3ESe5Vo6ve8X26jWnJnon2vaGstwnDeXNYTFAnuS32ljwMpqZZIxCjBdlnVQZPZR7zFtvIlsmK5yJVXVIdarch4zqEdLFie0QZUYt5Hwmvq+64HdVvrmf+SZogB7+ECo6MjFpBtvIu3l3COl9rqDVK8RfM39TQSqrq3ef/9f6RGeSFb/wA5T+Em8EYiOOvcNcj1tveSpCvbPp6F8NOZd5bFGsAbE16uLJrF8zl6sDBISO6GcmQM2gachzXNdX2kTWH+/LB0n6o1eCJdjM6FhRtFjLBzEROcDFmOFiOJHYP8bbnMCmWiWMmm7nYIT3hVsSwDpHm9tYBgFxuZ9ILXP8btDaPNZBScaF8usqPwGjoIS1tpc/wUnEU6oEXg8GPeg5/MdD/4kAqi40sPR+gKhJYa+JSX9MJzMpdZfNrg8DMcgHQP/48TXkbFdXKDoQq2+zjBr8E6erF/JxygljuC8LG4mURp+N0U6P+TabQaGqC6xmWWpXWyzTzUq9uRQTW0V+RlyfiQWS1xda8ScMutV4NBnwF6wgskJKFFmIxgpTilI9NQtghPdn7clmwd+q1g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199021)(31686004)(66556008)(83380400001)(26005)(6916009)(478600001)(316002)(31696002)(6506007)(36756003)(66946007)(41300700001)(8676002)(4326008)(86362001)(54906003)(66476007)(6512007)(2616005)(5660300002)(38100700002)(6486002)(2906002)(8936002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0x6OUUzYU0yU21aVlJxMXJCY2lNNDNuRVF1YjBSS1d6ekswb2g4NXdLcUlE?= =?utf-8?B?aWROU0pnZXVydnBsUm55SzhCU1NoOCs2d2pYb0xTUkI2TGhZV1VFalpyZ21F?= =?utf-8?B?NW4rSTFlQzYxbjZQem4xdzJuYUJ5OE0rSGtFUkNaRDhxVko4ekVQSzliZUtB?= =?utf-8?B?LzJienUyOXlKK1A5MnBVZVczajJwQlhHRitaeitKTDBCS1JYK3FpaFFGdHpH?= =?utf-8?B?dTBPLzVYMTVRei9UdGxLai8ydEl1ZTVmdkdpY3hPZDdTNkNxdUhSU2VsSzUy?= =?utf-8?B?bnBlS3dpZUM1aVUvcVY0OFR6dWx2ZEpVTG9pQlZtTVFxSzgwa0dPQXhPTURB?= =?utf-8?B?ZVQrcHR4b0N3bm54dU1nSDRpMnJnZGpQMExxVGhORmpORWxvTTVBN0s2RDlM?= =?utf-8?B?NWxzTWF1TUw4K0VEd21DUU9rM3FKdktyQUJFRlc5VUdPQml4ZEl5VFgzdUNl?= =?utf-8?B?SHBWS0IvTmc2YlpNT3pzeTNveEZacUJBMmdwRG5rSTBUUklTZ2RxaWJtWVRK?= =?utf-8?B?SHA1K3Nvb2hnVWJCcTFBelFIRXlnb3cyUGxOTGMreERuL2ZjVjZtU05BZURT?= =?utf-8?B?RUVjUENLL2U2N1orbERFa1RES3ZUYUFQN05GT2p6aVFzVitOMmNnRjdaS0JM?= =?utf-8?B?UU9DZjdiV3lYc2RrS3BLdXJTeXUzbmJaS21FV2U3czhpbnJMeXM5NkxWc2Uv?= =?utf-8?B?L3NQM1ZUTkFody9HNXZRa1Q2dVFJeURxY3BmNWNXQ0VKL2NNZ3hRR1ZHOTlT?= =?utf-8?B?Ynh3M1hNanI0cG0velZqbDZOQ3RrVjU5bEtFTzdZcDR0WkVWY1JpV1hhTWJV?= =?utf-8?B?dDJFbmM3RTQwVjFxdE1ERzR0S1ZIbHYzS3NLTEdYdjhKdWhjMmo2NDJBUWJQ?= =?utf-8?B?UDg0MlNFRTlTU0pkbWNNZEpPVjVmeWJHZlZOZlZod0V4dlUxQ0ttMklBa2F3?= =?utf-8?B?SWxtZzRJNHZ3d3NLTjVnMjNORzA5SWQzbTdCL1J6WGg2VHhCRlFkekJYYmhW?= =?utf-8?B?VlNyVmpkUFhYYmNNY0JVTURYZ1pSK3RUNTNWOUhVS05CeFFQVThaQ3lRWGQv?= =?utf-8?B?ZTFUY05LaHorWlo1UUwvNGxXQmFubGhTalgra0Y3eGFhL1NmVkZBdVNOVWtU?= =?utf-8?B?dURrV0lPYmF4aW0xVkZDSzlCWWlHdjVycXhKWXZuYVA5M1Rla0NxL0t3ZmRL?= =?utf-8?B?YkJLRG9ycDBkdnVZMm1kYWs4NEs4bDRjdXBKSzNFaE1vWk4va3NKQUtWZFQ5?= =?utf-8?B?cGhNcVc2RTJSbE02RTd3MXllNTZzUHNmemZZMVFCQThtVmo4dDJzWGl4cVlM?= =?utf-8?B?eUdxUnM5OXZjNWdpektyMFRlTnA4Nk1EcHl5UldUY3B4ZXlVUVBjTzZ5SnZh?= =?utf-8?B?a3BhT0pEbjg3Q0REOERnM0ZQdTJSL2VIOVlGMFh5bEh4ZktqVkp5R0RRblY1?= =?utf-8?B?S0VzQW52QlE1QzZqTzBEdzFWZ3BDamYrRGEzWGE5S2pmZkdKMnBoNjZidUpo?= =?utf-8?B?ZDBEbXRneUNZY2ora0xTN1ZjVHovR0RhWExlOWRLY1E3VndKUDdqVEF0UUM3?= =?utf-8?B?TVFycWNOR2FjWVI2eWtZUExwNnhkZndMOXUyTDk5RWFQakdPbmN1RWdISmJr?= =?utf-8?B?eUpjL2paNFMvRWRqbzZlSlRMSklQb2FMbkVkek96Und3M24xMzN2WlhYWnpz?= =?utf-8?B?MmQ2OW5wMGhKTnY1blJMbDJVQ0Y0K3dKcHZVWjNTMDN2K3cyTGZ6UlpjSXJN?= =?utf-8?B?K2V6eTFoYlJxMGFQYTNwOHlxT0FyYnJ5b1VSdVM5T3hmL2VzeHZpSDJBZ0lq?= =?utf-8?B?c25jQ29GRXlsMENPRHNyNFh6K0lBT3pGdGdhNWdrSDJzSlRhcWdJcTFzY01S?= =?utf-8?B?TW1FdzBNQm1obmVHT1lOK1BlUndoczJ3a09yMHpUd3cxdThTQVdkTE9nc25i?= =?utf-8?B?L0FjOHFFWnp3dVdWZXcxZ1BhKzIrNmIzcDZ1akZYR051ek01eW0xMU5pSjUy?= =?utf-8?B?Vi9DM1Y0YkRxQXovbVBxZmIreFp6UnRMbVAyUmJNSWltNXRuR1IwOWdoYnli?= =?utf-8?B?ckcrTkMwTXYwcFZsb3Q2ZitZMjd3NFJRMFZxUndPNmhIbmszejVMMTRnYk9G?= =?utf-8?Q?rZ+vQ3K2rV5fDAF2okeb7MKIc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed74f95e-0ee4-449a-149f-08db31cfaeb2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 10:07:06.3377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x1Ui6PsJ8Lh3nWp/nxv7j6ToxbqpdTZSDyEIzg2KPbHEnU4N07Z90Kb5vpvl1H5/QXoHH/ZF7MctTpZrNK++pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9106 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Callers which want to make further parsing attempts at the buffer passed to the function need to be aware that due to the potential of string concatenation the input buffer may be altered in ways beyond what can be undone by putting back at *input_line_pointer the character that the function returns. --- a/gas/expr.c +++ b/gas/expr.c @@ -2388,12 +2388,17 @@ resolve_expression (expressionS *express here lessens the crowd at read.c. Assume input_line_pointer is at start of symbol name, or the - start of a double quote enclosed symbol name. - Advance input_line_pointer past symbol name. - Turn that character into a '\0', returning its former value, - which may be the closing double quote. + start of a double quote enclosed symbol name. Advance + input_line_pointer past symbol name. Turn that character into a '\0', + returning its former value, which may be the closing double quote. + This allows a string compare (RMS wants symbol names to be strings) - of the symbol name. + of the symbol name. + + NOTE: The input buffer is further altered when adjacent strings are + concatenated by the function. Callers caring about the original buffer + contents will need to make a copy before calling here. + There will always be a char following symbol name, because all good lines end in end-of-line. */