From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <allan@archlinux.org>
Received: from mail.archlinux.org (mail.archlinux.org
 [IPv6:2a01:4f9:c010:3052::1])
 by sourceware.org (Postfix) with ESMTPS id 0BAF73858D37
 for <binutils@sourceware.org>; Sun, 23 Jan 2022 01:29:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BAF73858D37
Message-ID: <b9cdb903-4fc4-a609-7bf8-72e5eff903b8@archlinux.org>
Date: Sun, 23 Jan 2022 11:29:18 +1000
MIME-Version: 1.0
Subject: Re: [PATCH] dlltool: Allow inferring tmp_prefix from the dll name
 from a def file
Content-Language: en-US
To: Nick Clifton <nickc@redhat.com>, =?UTF-8?Q?Martin_Storsj=c3=b6?=
 <martin@martin.st>, binutils@sourceware.org
References: <20220111203654.1577650-1-martin@martin.st>
 <1e23ffb2-8cce-9285-a971-13f62312e019@martin.st>
 <c948b503-cbe7-7a1b-077c-8c1179752e75@redhat.com>
 <b3d2beb2-bb5d-4801-3eda-610ab1dd8b36@archlinux.org>
From: Allan McRae <allan@archlinux.org>
In-Reply-To: <b3d2beb2-bb5d-4801-3eda-610ab1dd8b36@archlinux.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jan 2022 01:29:28 -0000

On 23/1/22 11:20, Allan McRae via Binutils wrote:
> On 23/1/22 00:33, Nick Clifton via Binutils wrote:
>> Hi Martin,
>>
>>>> Move the initialization of tmp_prefix slightly later in the process,
>>>> which should allow inferring a deterministic tmp_prefix from the
>>>> dll name read from a def file, not only from the -D option.
>>
>>> Ping
>>
>> Sorry - overworked as usual.
>>
>> The patch is fine.  I have gone ahead and applied to the mainline and 
>> 2.38 branch.
>>
>> Cheers
>>    Nick
>>
> 
> Since this patch I get allocfail.so failing:
> 
> $ cat ./libbacktrace/allocfail.sh.log
> /build/binutils/src/binutils-gdb/libbacktrace/../test-driver: line 107: 
> /build/binutils/src/binutils-gdb/libbacktrace/allocfail.sh: No such file 
> or directory
> FAIL allocfail.sh (exit status: 127)
> 
> And libbacktrace/Makefile is empty below:
> 
> allocfail.sh: allocfail
> 

It looks like allocfail.sh was accidentally deleted when applying this 
patch to the binutils 2.38 branch.

Allan