From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3484C385042A; Fri, 18 Sep 2020 14:50:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3484C385042A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 08IEohxW004896 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 10:50:48 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 08IEohxW004896 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 64F871E599; Fri, 18 Sep 2020 10:50:43 -0400 (EDT) Subject: Re: [PATCH] Import mklog.py from gcc repo To: Christian Biesinger Cc: gdb-patches , binutils@sourceware.org References: <20200917202922.4179305-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: Date: Fri, 18 Sep 2020 10:50:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 18 Sep 2020 14:50:43 +0000 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-DCC: sonic: antispam2020.polymtl.ca 1254; Body=1 Fuz1=1 Fuz2=1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 14:50:54 -0000 On 2020-09-18 10:27 a.m., Christian Biesinger wrote: > I like this in principle, but the one annoying part is that no longer > prints the patch author/date line, so you have to manually create it. > I suppose one could make their own script for that (or maybe emacs > users have a macro for that or something)... I think you could add an option to the script to do this, I don't see why they would reject that. I don't know what the workflow of the gcc devs is regarding this. But it's not a problem from my point of view. I prefer to write my ChangeLog entries in the commit message without the header. I think it's pointless to put a date there, because the final date will be the date where I actually push the patch on the upstream master branch. And the name/email is redundant with the author name/email of the commit. I use a script [1] to insert the entries in the ChangeLog files and amend the commit when I'm about to push to upstream master. The script automatically generates the date/name/email line at that moment. Simon [1] https://github.com/simark/gnu-changelog-tools/blob/master/changelog-git-amend/changelog-git-amend.py