From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 988D0384B06A for ; Thu, 18 Apr 2024 20:37:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 988D0384B06A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 988D0384B06A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472646; cv=pass; b=a/UqwXzLaKWjKq4kel7T61O3UbAz5gBTTP2ghdP2TKhayvDnPSTZ1l+iUjQybozRVO8hixSlkLREDvcLTutxG+Ceh9xKZjh0qhCTlyEoSDz8HQ/8+PcZioLf2eGN7Fu/rWM0jHbEaVrLu3Rd1O4ul6hE2OAsOPwfOAIj4//ZDAA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472646; c=relaxed/simple; bh=7YmRQuujZ3u+Omt4tBDn6Dpvg9GI+Vqa9WzYr4FtBEM=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=HlEhVvG5rhZAfhvWhhYV6cmlbWcPOxlKNcMZJwKAn8FWMZEAZs+k6ZhYieDbnJ7O1HhbF51TX/HfBwDY2JhMTn0DaMME+AJYoH+sogQ78PawaaQaeD/XdUNJoBiZegwk9LV/k6txTmOwRGVy/fAfhElfzH/L2uCIJd+3wcBbvE0= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJi126012098; Thu, 18 Apr 2024 20:37:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=l9jy/WJJ4t3hymNQXETKUHVKwqhumZreG4qLhfKOd24=; b=Hjs+cEGjf0qr7X/Smsu6UvPPU4I/NTHu7AIB5eTy1gAmlBHcrWQNH2vxxl7igEHtEv2n 2JT8yueGoKouGO0k/C+6VA4U8t5Ks2j2AxMqkgnQkOdFLKBu7YQ02ghTS/ahHeR+y9Op aHj+WdSoKiRYuRxP28QknWTQbKov0xxnlBCWTqoSPdvvYmQmQ9f6GDL2FiQx6P+c2FJw f45iHymogbu5Hu+rf4xmmYvMxAtVxGfGVYq3508iUfd/TFr9V5sjeJVWJGRkSf572tv2 WYXTS7E6IHOlF1au4vBXh3UV6TqPlPTZPuEYWTQZ0rJ7ROw4yR4e5MRjxRPmY95xl0M4 Vg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfhnukmbd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:37:22 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJFNuR029185; Thu, 18 Apr 2024 20:37:21 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggaydkr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:37:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hPd/+Lv8jmgMqY2zrbzLnW2SOK0UZzLYUBxB2bXXLPWQgkTHqfR2CMTM0cN03EtCw3yOIrnG8RlOdGAH9HO8lsSe1srqsIn5VF6pBRkxR8+8ufMAAjHAiDtMAcI562WyLsicrmt8iz/7pLVCAmNHcUyzLEDbthjItuio1raZd+AQd0vvvkeppU7Ena9Ev+b3Q+5LUFV/nROOQX8fZ2QZlfFr3rETFzfnkNx2Wmni8rmNm2Bb0fjubYPL3O9plSFtIjAhJM8RxGgyQ6ZlWkM//PuHtfe3hkOe8DiKtUNhI4Z7zUc5yFa0xoUlym6HHYGxoth0Tr02ZFGW027MyMTg1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l9jy/WJJ4t3hymNQXETKUHVKwqhumZreG4qLhfKOd24=; b=UCl4E5RMgshf1EyKa74rIbea6oG3voJzriU6IOWVKE5hsQRbyR11bguhg8OEFLJj5MUrc+fqtPeDKdiIdpxsRCaJiqcV40HGdYo2r080zBlJHnvfWcnWhFI4bwErQHOH/3Avsb2UknNo8VM3MRdEweH9VI1A0vqt0IKBmqHVeTuYliaS1NLTU3TZ2BKD4q67PsfkUhvS0UVZgzI5XBHtigtFzApG/+dgGHPgoaJqxz2W5TH7hZLHvL8HLFQdchS7YJqkzW116FLd6tiCogca8g0Pg2mnwbQqQHZmPRzVFW2oRszRLjiPYXG9X7BXxpewJ1xIXKc5RpIjOAEclKiNUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l9jy/WJJ4t3hymNQXETKUHVKwqhumZreG4qLhfKOd24=; b=xbSsHjQXB63BaMCp4KhIAKKh/+c1UXsyB8asuqeSKoiLzNXf6ygTVdEKl4xlCOlu9f3tBarIPCnl/YoMqISnvcZsPwBLOjqXjXZJkPGx9L7N/g5uGpbRRh6Wi++59FdzRl5vHQ8rkm4rnS27lftbmVn5L07rH6/fuaE2cHMWJlg= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY5PR10MB5913.namprd10.prod.outlook.com (2603:10b6:930:2f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.42; Thu, 18 Apr 2024 20:37:19 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7472.037; Thu, 18 Apr 2024 20:37:18 +0000 Message-ID: Date: Thu, 18 Apr 2024 13:37:18 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/15] gas: Don't skip SFrame FDE if .cfi_register specifies SP register Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-14-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-14-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0162.namprd03.prod.outlook.com (2603:10b6:303:8d::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY5PR10MB5913:EE_ X-MS-Office365-Filtering-Correlation-Id: f6b84372-6206-4e00-b81d-08dc5fe75774 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kfsVOtRKolSl9C+Lh5CX8rcUaUJ6g+9zSfvem7nzCLThU1i+FfqjIltNxtLufG8qi8Al3+kbr2H3ih/0B+c5lsjPrIxWmz6TM9We+dLV14Ih/uosfC3bIoWSb4YjskLTGrF7PiOS6EqiTRYn/fX/Gw5EiYnvf9xSCdOka5Ueq7Qpaz4+65rA1tzj9eA+i3VQxUkGjpXThrYXYbRWbewIus0Wg7ALZsegPOgrBuHzRm46+pd1nANnxCRZIwy8vmn5fTjF+U+Msg/YgWVF9tBT2m0reDkOyYPSoN+tRZog6r9+X+BEU4ei4z8fEqa/FrMtoJm8DtchJr3S4l/3EmTPbHoMtAzVPROF6YLZqdHI0k89oYsf/X8d26eyGt6sY2wUYqzAPyvcOyTt+3lr9LEN7E6NrTQC0R0HeOxc3TDN0KIy0t3VI36WTq92TLqth53xejfRYZ5WDiO57rTozf8yUKzLAQdD9KTtPj6nF6tBPSsZ0F7xdctlQIGH4Qy2LYhyc/pKhFJPaGKNZvmhT8EMEyMLoPFxm+SYgZn2gWIg3DfK7YiLFlzzfgKtSx8DHqcORLZvtf5ibt2sN1lnlvqir6DqQSTxtwsm00R3C14eMARyqKaYV1uzPA66Mga6Og5qs0t0dXUkto7Rdafy1Aes71dzmnTChYdKbM/E2rNwy5w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTlvbmk0eGt4ZzBTTTdSZHYrNkF5TThnOE9pbitwYy82aTVtSWFUV0xndTh2?= =?utf-8?B?R1BzSXd0TGNRTk0yRDcrZ0FlVkNEeFVMb00yQWFLL3hlT0hwQkxGYkxIUzY3?= =?utf-8?B?ZjZ5V0FGUXJ4OFArZ1FLdkdJRnFKZ2R6SDh5aGZ6TjJEUVVQSVVDMG81Q09E?= =?utf-8?B?d0MxSnFpMk9JM1NhbEFaVzVyVFR6UmlpY0krR2pVOEJuTldjSGZUODlLWTRM?= =?utf-8?B?UU9BVDdpck9CNjMvZlY2SXJ2UkhLZWdWTE4rWjQySnlMOUd5Zitwai9lWEdK?= =?utf-8?B?ZkQ0U1VYWFB1TUNTcEF0OFEwbDFBVFJUTmlncmtWb3pOVm1WTEZUSjg1REVw?= =?utf-8?B?OG05VWJ1aTdpV0VkZ3Q2M0phYzEzNnYvaEVlUHhrSDlNaXNyRkszby9XckFB?= =?utf-8?B?dmlWanVFWlVwM2pFNU1RRnZ5ZXIyVlIrMjc1VDluczRtNHN0bFB1d2dTRUhF?= =?utf-8?B?SFZoT2FxdjEybzFvY2RXYUw3NWZBVTdhWk1FQnZPRTJhYy9xbmRKUGhTR0tV?= =?utf-8?B?YlFURHN4TVprbndsVFZyaWw5QmZQVzZwTGhHSC9rK21zQnNyR1M2MngyQXpj?= =?utf-8?B?NG41bENWazdqRmJMZEVQaXNudkdZUmVBczZYT1NFSnZ4ekxWZnQwaDFHUWdv?= =?utf-8?B?K2ZNN2o4ZmFPOUNrVUdJYy9RREFaNWRDRHFYOWd5OHJhandqMmdaN2hicEhn?= =?utf-8?B?bkNKbnY0b1NTdW5sSzdyWTFGbDJneVI4bnNRU2U5TnovS2VHMDQvUXJBWEZh?= =?utf-8?B?NE5CaWcyem9GMjVaWThWeVpqYkRnL2Zia1MyNkdGd2U2Q2Z2NUJic3Rid1lB?= =?utf-8?B?Y255c3VYdCtLVXo3Y1hyTVF4TW84YzNobDBFN20xbFg2ejlGaFVETGRuKzhj?= =?utf-8?B?TmNPMWJPb3hFYVZtSS9aREtxdm5XUlNWWGZqbFc5WVd2WVdzWlhqOGw4c2Qw?= =?utf-8?B?SkNpVWV4VmRkR1hRRDhyaEY0SEthb2x5SkE0S2JLN1grQlVJek9pM3h1d0pp?= =?utf-8?B?c295REpuM1djem1oZU9yTDU1TENaczVYUmx5Z3N5NDBoMVRCTCtxRHNZVkx4?= =?utf-8?B?R2NSM1R1MEdtcVl2YVRYbkpCMktCUlVEWktFWGloTCt6dkR5SFFKbk1XdFN0?= =?utf-8?B?RU5FZkt0TC83RXcwbDNtM055WE9PMi9oNXlyTWxyRDlpdkJyTVZkK01kMXFJ?= =?utf-8?B?N29uWmlVOUtpeVk0dGRsYzB1QUd3Z0h5Q21XTEJMRGdvQnZYOU1rMHZrZnYx?= =?utf-8?B?TTQwK1dtY09OSzRnbkhnNEpESThYMkhybWFweTY2QXZpV3JtQUQwZmN1WUlM?= =?utf-8?B?UjJBakFIcXB3UXhFYVlhOWloYkxrMTBlU0JHeVptYXp1U21CSkF5UzVEL0ZO?= =?utf-8?B?aUdtQXNMekN5cEZvcTVYODBMZFhtZVltVzQ5d1lVcFdlazZFWS9hQ3BCOWxw?= =?utf-8?B?K1lZQW80ei80YUZ0anZpdDh0cFh0ZDVoQWk3aDRLSWdxOVJ4dUxlZ1oyN21w?= =?utf-8?B?L09uSFJZRkVSa0NacnJZK08weWJIMDJ2eTlJcDduLzk5N3ZSNmVsaU8reWJl?= =?utf-8?B?bHZXUlB3ZWswYWRXT2hJSWNMQXFsb21jWHZ5ZDUxdVdIdllESzVZRGZXVVJq?= =?utf-8?B?SXZ5RnQ5MW5vcWRQWW1YSzZxUUQxVGVEaEVnVGpqMzNGejRZY1FiVVVzM3NG?= =?utf-8?B?WG1Kdm1Zc2RmYnFKbWFmV1Z4RUlGd0graDdycENSRzVRS3JlYy85RVBTL0hO?= =?utf-8?B?Sk1WNDRMQlFrNllxMWY0RjdIRTMra3hKUm1VS21qVVVrNG1VWnRPaFZFSVcv?= =?utf-8?B?ZVZZNG8yeEZpUm5BeUZLcEhGK1NJTFF2bU9ad3hjMHZzK0t0QlA2RVBHakEx?= =?utf-8?B?NzRhb2tLR1dwbnRmRk5CY0xUOFBTcXowY0ZIL1lEYlEwWDZ3MVFUbnAvaS9V?= =?utf-8?B?VERsSVNBY3FkZzdxeVlMa0swNmIzbTVVNDdhRmhWWGdRL0ZGUUlXSndqTG4x?= =?utf-8?B?MW1ndWIreXJjSHRhWUdpK0wybGo2SnExZjBVTUFmR1JoMmJ4SS8wS2Q2MjBm?= =?utf-8?B?MGY4NDRRT3JIMkRiTkdlcHJpTEw5VjhXcC9XeWhxMzQzQndYTEM4L2ZUQnZ0?= =?utf-8?B?aXo4YldZU21ZSUlZMnMySitUNVVyaklSb1E1cWxlN2p1SWFML2VRU05ZK2h4?= =?utf-8?Q?g3CtjxIcnAXGXheW0dNlTCQ=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Buun3qlY0MD9nUi0rWTo5ANU6AxOen6htuOPHcPvFqYTtfe/O7/tArfmFIehkv2PLf0nBQJ0Pd+wD+vQA4/Pp0724ayIsctrDwQ5Yk7AHvnJsf6mZX3g6wUunJC+yEQotNu6ChxwfNek8tB8gc0rugm5IPFOZNrwzPVEGcpZ+ufpJjP/dPJJl7O/rMkAXK1W6t2oZwpi9S+oxPe4jpdZCZTsSNmvBzQdwTuW9Hl+d6oJjBQkA2PVWzN2gbOmKkgSEB0whCq0R79h9lkWjBevREvFXL4NKHznv+DC/kZUr22MGd8l/CHiv4nj7sA/p37Z+vA0VVc+IHeXb9yKpqQcAL3rtS28+dVODoh6+XOhUcBhjMoO0pAt7bPiOtjg0DW/9Q8NpksFduPTrZ8TPQ2KSbsS/j9W74tmmsGDTJ1wVgm6rRNoAL8iYvbBVaaPZnL2RLCLab7akdiqJxH6X5eFx+DLb/TMY7EfcXw1xqESg6iLs3GFDclzazSUqMc7eze9iIIrqmI6Iz5R4UfgpU8rH7Vwr5GhEzR6G0r3zNRxAtzcsXSv/z6EGVdwxMHQMrALZ/8VwPHVZCfckUTmmcQfshFJbx4COWhia+V5IJ/cZss= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6b84372-6206-4e00-b81d-08dc5fe75774 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 20:37:18.9636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +0/PZ+DPjMvCKcg7bRbZLC1kWmmg5PpKY5JKJrNAicC/uWIeLZhDEL5yU4DoLRhT8i5nYcCeOmz7CuvtumSfAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5913 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_18,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180149 X-Proofpoint-GUID: TJ4oKCdkuL2APPGtAapGhjGXgXkSEtad X-Proofpoint-ORIG-GUID: TJ4oKCdkuL2APPGtAapGhjGXgXkSEtad X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > The stack-pointer (SP) register contents on entry can be reconstructed > from the CFA base register tracking information from the current SFrame > FRE and initial FRE from the FDE: > > 1. Compute CFA from the current CFA base register (SP or FP) and CFA > offset from the SFrame CFA base register tracking information from > the SFrame FRE for the current instruction address: > > CFA = + > > 2. Compute SP from the current CFA and the CFA offset from the SFrame > CFA tracking information from the initial SFrame FRE of the FDE: > > SP = CFA - > > While at it add a comment to the processing of .cfi_val_offset that the > SP can be reconstructed from the CFA base register tracking information. > Sorry, but I am not sure I follow. Yes, SP can be reconstructed using the means you outline, but so can FP. And also RA when applicable. In other words, I dont follow why treat SP differently from FP / RA when it comes to .cfi_register (or even .cfi_val_offset) for reporting the warning. > gas/ > * gen-sframe.c (sframe_xlate_do_register): Do not skip SFrame > FDE if .cfi_register specifies SP register. > (sframe_xlate_do_val_offset): Add comment that this is likewise. > > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. > > gas/gen-sframe.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 61c846f214ee..12b523a8d59a 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1136,6 +1136,7 @@ sframe_xlate_do_val_offset (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, > #ifdef SFRAME_FRE_RA_TRACKING > || (sframe_ra_tracking_p () && cfi_insn->u.r == SFRAME_CFA_RA_REG) > #endif > + /* Ignore SP reg, as it can be recovered from the CFA tracking info. */ > ) > { > as_warn (_("skipping SFrame FDE due to .cfi_val_offset specifying %s register"), > @@ -1155,14 +1156,15 @@ sframe_xlate_do_register (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, > struct cfi_insn_data *cfi_insn) > { > /* Previous value of register1 is register2. However, if the specified > - register1 is not interesting (SP, FP, or RA reg), the current DW_CFA_register > + register1 is not interesting (FP or RA reg), the current DW_CFA_register > instruction can be safely skipped without sacrificing the asynchronicity of > stack trace information. */ > - if (cfi_insn->u.rr.reg1 == SFRAME_CFA_SP_REG > + if (cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG > #ifdef SFRAME_FRE_RA_TRACKING > || (sframe_ra_tracking_p () && cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG) > #endif > - || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG) > + /* Ignore SP reg, as it can be recovered from the CFA tracking info. */ > + ) > { > as_warn (_("skipping SFrame FDE due to .cfi_register specifying %s register"), > sframe_register_name (cfi_insn->u.rr.reg1));