From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id A8CA23865C27 for ; Fri, 16 Sep 2022 04:17:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8CA23865C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52a.google.com with SMTP id g4so19265285pgc.0 for ; Thu, 15 Sep 2022 21:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=cdAGlbMhJ4sfUiwp0CW7/DWcmVsocDGANR0DWY7KuxE=; b=pbwHnIe/Pw+04hWxBfOUjf8Cyrp+ChYl6CPxoj1OzofZmX/F+x3XLA9vbXWDKqEaWW Y+0R+XPgdgZSrV098FxqjeV6w3gmSQHuHl5BPY55HAkgZCB3p3YJJQQe/1ioDux+3tYa fbo4sFXL5G9JEqegPlFXDlcAW2RQLpmeypl7M/CfpZB21h04+q36sgTj4FIux3Z1yVjU DWrAWvOjGlP5xe3K1EcpSmtu5muT5+t94kThjn07CluEk2Y5nryAE0pI8CBCWfFqFTow AFgLep5iMNFnksJ/wweaJU/Qde7pBOdI0lsgUyWCst0oKiXVp5DU5G28U+I9R0F5bhd0 y5Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=cdAGlbMhJ4sfUiwp0CW7/DWcmVsocDGANR0DWY7KuxE=; b=GRb6tIxIB1b7Y9mU9qZCVL3ksAJ1JzV7b3tX6fx6dHEdS/msfdKk//pLyWLqWaETxV 6TAqizTNDvtBnDq92TrCtu+bWpdnNyTsMp/ceZE82XCBCd9pXwup4UomFCN1DDBEVygI H8c3SBJLhF6F6LR/EnfPgOP/M/rXLZLcZpaScbvnhIgJhP7GXc1X//ZFFS7+Wc3av++J YuvXMA2diNhVPD8KjwbxahprGXUWI+42sUmzuDzuqTWY1ag5mIOi8K+Di5iCPEtWzeSP Eb/tLHNM9E9OVKP24yz0A9Zo3LZfN/tb9UVGtoZ7YkvIk3uS+7GQPsgk2ETUQTdi459N 1P+Q== X-Gm-Message-State: ACrzQf0lDhLJyJMiLd9Py9Jze157jYZ36fyGXFMeY/j6ttucM42XDXIl r6TGkslPjzp6d/pjBJ3q8YloKKmS7u52Cw== X-Google-Smtp-Source: AMsMyM6VFrOr7N5ApWJoh7rB7kXnwd+DZqo6hFevqqjDmNk5reiovnZxC0dBTBePeO8BuHay73S6zA== X-Received: by 2002:a63:1e16:0:b0:430:5c4a:a3b5 with SMTP id e22-20020a631e16000000b004305c4aa3b5mr2941240pge.37.1663301857533; Thu, 15 Sep 2022 21:17:37 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id g17-20020a170902d1d100b001788494b764sm3979plb.231.2022.09.15.21.17.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 21:17:36 -0700 (PDT) Message-ID: Date: Thu, 15 Sep 2022 22:17:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [committed] RISC-V: Make g imply zmmul extension. Content-Language: en-US To: Nelson Chu Cc: binutils@sourceware.org References: <20220916013903.45339-1-nelson@rivosinc.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/15/22 21:26, Nelson Chu wrote: > On Fri, Sep 16, 2022 at 10:34 AM Jeff Law via Binutils > wrote: >> >> On 9/15/22 19:39, Nelson Chu wrote: >>> bfd/ >>> * elfxx-riscv.c (riscv_implicit_subset): Moved entry of m after g, >>> so that g can imply zmmul. >>> gas/ >>> * testsuite/gas/riscv/attribute-01.d: Updated. >>> * testsuite/gas/riscv/attribute-02.d: Likewise. >>> * testsuite/gas/riscv/attribute-03.d: Likewise. >>> * testsuite/gas/riscv/attribute-04.d: Likewise. >>> * testsuite/gas/riscv/attribute-05.d: Likewise. >>> * testsuite/gas/riscv/attribute-10.d: Likewise. >>> * testsuite/gas/riscv/march-imply-g.d: Likewise. >>> * testsuite/gas/riscv/march-imply-unsupported.d: Likewise. >> Does this happen to fix this kind of failure that started showing up a >> week or two ago? >> >> /tmp/ccdAErP7.s:6522: Error: unrecognized opcode `mul a5,a4,a5', >> extension `m' or `zmmul' required > I get the same error message if I just assemble files with > -march=rv32/64g, or just use the default rv64g arch setting. I > remember gcc should always pass the expanded imafd for g to assembler, > so the errors won't happen. This error should only happen when we set > g for architecture string. Hope the patch can fix the problem you > mentioned, it seems like the same as what I meet. Just to follow-up.  That seemed to fix the problem.  The build is already well past where it was failing before. Thanks! jeff