From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by sourceware.org (Postfix) with ESMTPS id 3744E3858CD1 for ; Fri, 22 Sep 2023 07:52:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3744E3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bc0Tq+22IDZPUGUZi2a1PKGlC9QW6bM1LOCBlGVyupv68onVBaFLE5LnmJw28OXrIACDwoQZ0vEWcG1tcccxufcZ/n7/Wsbu8dnE1CxKd03h0/xRWSEPkw0sKZ+VQcoiAFnrkU8YtXdDuFcEO8ztpI9X47e/JnWHtRHJQuK+Ufq1tlnhrnDwW0RusiLviMSmgcj8EfoYGS8WGurwMpaWIofyDxmhM2QJvggi4prFdofvbQ3PjeLvHx+TIz86FJnGqDAXYhIA/lqKM3hUcA35LIH1OiR4H/x/BFgqqT4vYUym0rabTmliK5q0zRUjdTbLJ/XkPo0w8wRmIcIIdH1flQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hqBjlZGX7O0SAYd8yjA83Z9iEwYFFRf8gST6pyqTPpk=; b=T/SFAzAEbXvJ67uYm4f8T/5XxAjWPZVVvhqRtJxRt3cx8bC4vtw9BAX35JZTqY1NTQ0fTflFv+6ME11oS9DTrRPuEEmdxTb1+lNVD1aJx6ja49tWo+XWqFmVAp5OTLdEu7AKej6Q8eqIU3nxP4/Du42a3L4pIQWkvtK1VYqUzTR9Dq05EY60PcncSS73I4xcHJhugeY0cZJXFOUjnGXpeE0IPUSjQ2Aks9ygPKyBuj83WkgEuIo9nl2za3+m6PK1r2/2PgjvicMayv6GNXmZGQ1tylYIRCKO5VflRrrLezzQg0NhmySFFCUNjvX5N2Tt17yKx8jdjQaOrGaPCAmnvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hqBjlZGX7O0SAYd8yjA83Z9iEwYFFRf8gST6pyqTPpk=; b=dphORgyBVRDoSsQhqsl9AbsL4N0TOxy3eLAawo2TC2lm7cdtH/l/gpMtMGgoDC1HO8Ex0+L4cZ1U4Ff6rFXzefllRvH1erHZ0o9bb22xOyIU9c2ZRsjp+ieDLQoJvhlaE7E2jIy30pjvuW5aqD7LplbDnSSXA3Lk/3YHqtmK/HI/z7EQxF04nImPbclam0ngKloTFO0Be4ONyULRpR/dNi1k+Zt+HYrke2jYY9gdp9tar31a741gHtYInpmPmSX54nafBwi1PKrA+Q7zm3E6TAreBq2tOFtEtIcJDDGpH+luKW0x5TuvCJqlrVxLbRfvUUcqSmkIqhJZHCFBoH8v2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8919.eurprd04.prod.outlook.com (2603:10a6:10:2e2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Fri, 22 Sep 2023 07:52:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%6]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 07:52:04 +0000 Message-ID: Date: Fri, 22 Sep 2023 09:52:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: [PATCH 1/2] x86-64: fix suffix-less PUSH of symbol address Content-Language: en-US To: Binutils Cc: "H.J. Lu" , bouanto@zoho.com References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8919:EE_ X-MS-Office365-Filtering-Correlation-Id: d1d473a0-123d-41ef-38f7-08dbbb40d020 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nwncojU6tyNtyKbwbULgEaka2vRXRyGv9vCTddNqfJ7TbMyF31PU+FTjC2XdpCgCWE2xhr4rVGimgsZCvm021O1gr26EpdAe0BSDuW6LcHH8w5zKcAdwA7YGFJYxaiA0UDBY6i+J1on3D0cl4yxH1Rn4uBoT7FkdCZ5wOhvNjEnFxiMhIrXditVLzPDHFgTxDLyejK3dF/r2/+DbYQSM206pIsuprECrx0AoeyBr4BwCdFYWLXBeoiImYZI+utUdMwiMLqNKPLp6vQvAPZDpAVJQPdPHd3nwsx/IEIve4B9Oe7K3nikBlEcw5mhwm5KgonbB1s7VNhwwfPSfXs/gB/GD0eMXlmPTxxK4zryLD0pniVhtm2LHaJL7jNnnL3cXH2euEePwd/KwN01iQXDjdXB0BBeZ6NsMjziC9DkfudIUH3ik73tdugIVBADeW0e5LDxsEQZB6AdlieZ7lvZY/Oe8ShTjmjKhhEU8eucLdiqnSZ59PY7v0SBKlOIDmuPKgp/hADd1YTESnVrSTXGeZHSKfzNMWdDnNlBb+KdeN+cMIt3GBxIc1iAiZy5RDAjYdkZg8zC4gIZoipmM7bovTXCaPpx1ikJmKllFwKmUCHQNpf5pZp44qgU4yIZrL7XKcM1du0GKinmfG0YrQgT5Eg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199024)(1800799009)(186009)(38100700002)(478600001)(8676002)(41300700001)(4326008)(8936002)(5660300002)(6916009)(66899024)(66476007)(316002)(66946007)(66556008)(26005)(31686004)(2906002)(2616005)(86362001)(31696002)(36756003)(6506007)(6486002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mm4vUy9uNjZvalNGTnNTTDZ5UVBFTG9MNTN5RDdzZVZNTEdzL2I3dGgvR1Vo?= =?utf-8?B?ZHpUWTZhb1ZqMDZva0tZOG5JanI4bkhQQlpLNFRhMVpJeUdQdDM2WTdOQmhO?= =?utf-8?B?TnZkbDVKOHlJdW1lK3Uvc3FKRDR1WnF5MkhCZi96aFhEWTJIaWFvbDNkZzZu?= =?utf-8?B?elk3MWtYRzFKMHlVdXR2NWhDQmxZUUlXOEdPSHNjUk1YV0xHNUpEb29QZkt5?= =?utf-8?B?ZzVtWThBcStPTWRHYTh5VGQ0L1J4NEloNHRmZlEzaGFrdE5zT3lNcWhlRHZy?= =?utf-8?B?RmtROWxYcHMvcS9UY1NVOU14dHhldUJCak5Hb2JSRWR2a1Y5N0V5aHJYRUdR?= =?utf-8?B?L0xwUk1oZ041c2RNSWZranZlNmVGUnh5SUpENUNRUFNCVXYxaG1nSG81Wmkr?= =?utf-8?B?Q3psb3ZFZk9GMHFPUGdOVU9YUWEvNk43WFExQ0NjZm1NTzhjazVCK3FJVnE1?= =?utf-8?B?UzJ4aXJqZFNKZjh4MDAwdUlPeGU0SGpTQ0VUWmJTSVl4c21uQ0tEZjFZSEdh?= =?utf-8?B?LzJqN3c3UjFZQzAySDVYZlFHSE5Ka255RHlVUDFvbTVzbmY2WnFEVGMydWw0?= =?utf-8?B?c01BbFJFeWZMWEdWa0lZc1Q4U2pnU0V4alVSRUdlOHgwUFhLQ0VNVkEzcnlq?= =?utf-8?B?R05COWJFVUR3cWxQUTBOQzlkckQwdVZLZU1icFVyQmRoYm0vN3hTVVMxN1l1?= =?utf-8?B?MERDcUl1M3BONk12N3A4UldMU29WSGViQ0tib0M1SnZzV2ZoNjZkZ1FzNjhX?= =?utf-8?B?c3U1T3ZxQWduQkhkNkg0YVZscDBOR1owYUpubVVqOUFzdHhqbHRpSmlmelBI?= =?utf-8?B?aHA5Y1FzaUY4eXhQY3RTajIwckJNaytydUgzQ1Y3bkVIT1ZpTlZEMFV1d1Rp?= =?utf-8?B?VnpVcTRFVEZkOXE2SzRmZEIyYkIxa0crY2VYZjJucVpsNWJ3cFhFOFlKM09Q?= =?utf-8?B?RVc1eTg2OG5vVFB6T2ZJa0dITDUvd0VuSUx6VFhFTkhQd3A1aU0xdFVLdHZH?= =?utf-8?B?RWpiMHR3RnZMS2ZsdGVFNVNsck1TNlVqNUFmVlFUamZXTURacnZFVzdIUW82?= =?utf-8?B?eEVndmE5WERMTnFvM0M2RjhsZHdJSFZ3VUV3T0orUkxrSGNDV2lRdyszUVRW?= =?utf-8?B?NU5yczB4cVlQa1VmRDd5RlI3WU43dTgxaHF4RzFVcGZ3WDMzTk44bXN4bU8x?= =?utf-8?B?Y2doSmdZMUFCSjFHbGVXMmloSTFvOUJWdVRJZGhiRi9OeFZwWkpPYnVCbjY4?= =?utf-8?B?VjhYR0RhaWM1NjF2Z1ErRThlcDgwRU1heThCbEFPYTJMUjhZRUVZRHF0czJC?= =?utf-8?B?bWVkMGxUT0xaM3hRL2V0YlFmSHFscDl4OFlESlVKQ0lVRWFMKzVNZ1RuN2pZ?= =?utf-8?B?VzBLd2xEbklRRzluTFppbU13U2hRalgrYU5sWkMzb1VJazM1ZUhsRGRDQndt?= =?utf-8?B?N1ZsTVRHcWkrTG9TajQxQmo4eE1KYkJ2U05KSUtwZFVLR3lTMk04d0RBNVVq?= =?utf-8?B?M255ejNQcWhhcGo0My9aTFJyQU1Qc2tMc3hPNEVldDM1N1A2ZVI3Zk0rQnJp?= =?utf-8?B?bTMyOFpVTWM5SGNmS0dSMk5POWtXY1Bmb294NERaRS9xL05yalRWM0pZR2xa?= =?utf-8?B?OVZidTROUmVpM21JbCtFczQ1MEFqQ1dNSmlQeFNQc1hqL3k0OGhabmNCaExz?= =?utf-8?B?Z0dMTnJxSzJJM2k4d2hTcjQ0ZUZWYzhTTnZyUmhBbEhyd2drdStJeVR2Y2JK?= =?utf-8?B?M2szelU5WllNL25JanJpejFqZVRpODVDU2MyUzlweXYwUDJhWkVReHYrcEIy?= =?utf-8?B?ZkNaa1Z1L1A5K1lTbThPUEFYbDZWa3RDWWVONmY2V0czTFRVUmwzREJQd0xZ?= =?utf-8?B?cThpWXVXVjlzNVdoaktjREJFeldHVUEzdndra1lpNG9aQzBWcWc1TnRSb0RT?= =?utf-8?B?eCtqbE9iSzFaODNlWmZzc0ZsREZEenBhVWVlZ1ZEVEtxL0RHTkN4UndsUWpI?= =?utf-8?B?T2lMRlBPeHE0cWJ4My9UM1dMWU54aGJWS1ZVdUEyVFR5ZDkzU25JTUJDTTU2?= =?utf-8?B?YU1PWExwWjVqUDdLdG9yTitwbG9KYktvOVNkdUx5YmJ6eDBINUdTQzk1aDdL?= =?utf-8?Q?SpRGsKSzH1PZTW1nX/srOCni4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1d473a0-123d-41ef-38f7-08dbbb40d020 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 07:52:04.8427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A4hak4Tj3md/E5H5wTptYRH47zpeD5wEOrc45V/KQJ/xe+nP793c+pRU2eARvNOyhRaM8hR7TXoO3oy9ktqunw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8919 X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PR gas/30856 In 5cc007751cdb ("x86: further adjust extend-to-32bit-address conditions") I neglected the case of PUSH, which is the only insn allowing (proper) symbol addresses to be used as immediates (not displacements, like CALL/JMP) in the absence of any register operands. Since it defaults to 64-bit operand size, guessing an L suffix is wrong there. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -6214,7 +6214,12 @@ optimize_imm (void) } else if ((flag_code == CODE_16BIT) ^ (i.prefix[DATA_PREFIX] != 0)) guess_suffix = WORD_MNEM_SUFFIX; - else if (flag_code != CODE_64BIT || !(i.prefix[REX_PREFIX] & REX_W)) + else if (flag_code != CODE_64BIT + || (!(i.prefix[REX_PREFIX] & REX_W) + /* A more generic (but also more involved) way of dealing + with the special case(s) would be to go look for + DefaultSize attributes on any of the templates. */ + && current_templates->start->mnem_off != MN_push)) guess_suffix = LONG_MNEM_SUFFIX; for (op = i.operands; --op >= 0;) --- a/gas/testsuite/gas/i386/immed64.d +++ b/gas/testsuite/gas/i386/immed64.d @@ -24,6 +24,12 @@ Disassembly of section \.text: [ ]*[0-9a-fA-F]+:[ ]+48 b8 04 00 00 00 00 00 00 00[ ]+movabsq? +\$0x4,%rax [ ]*[0-9a-fA-F]+:[ ]+48 b8 08 00 00 00 00 00 00 00[ ]+movabsq? +\$0x8,%rax [ ]*[0-9a-fA-F]+:[ ]+48 b8 00 00 00 00 00 00 00 00[ ]+movabsq? +\$0x0,%rax +[ ]*[0-9a-fA-F]+:[ ]+6a 04[ ]+pushq? +\$0x4 +[ ]*[0-9a-fA-F]+:[ ]+68 08 00 00 00[ ]+pushq? +\$0x8 +[ ]*[0-9a-fA-F]+:[ ]+66 6a 04[ ]+pushw +\$0x4 +[ ]*[0-9a-fA-F]+:[ ]+66 68 08 00[ ]+pushw +\$0x8 +[ ]*[0-9a-fA-F]+:[ ]+6a 04[ ]+pushq? +\$0x4 +[ ]*[0-9a-fA-F]+:[ ]+68 08 00 00 00[ ]+pushq? +\$0x8 [ ]*[0-9a-fA-F]+:[ ]+04 04[ ]+addb? +\$0x4,%al [ ]*[0-9a-fA-F]+:[ ]+04 08[ ]+addb? +\$0x8,%al [ ]*[0-9a-fA-F]+:[ ]+04 00[ ]+addb? +\$0x0,%al --- a/gas/testsuite/gas/i386/immed64.s +++ b/gas/testsuite/gas/i386/immed64.s @@ -19,6 +19,12 @@ _start: movabsq $early, %rax movabsq $late, %rax movabsq $xtrn, %rax + pushq $early + pushq $late + pushw $early + pushw $late + push $early + push $late addb $early, %al addb $late, %al addb $xtrn, %al