From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 6673A3858C39 for ; Fri, 14 Jan 2022 14:08:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6673A3858C39 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-27-8sHYf-HnP9KVWn_pJSIqLg-1; Fri, 14 Jan 2022 15:08:02 +0100 X-MC-Unique: 8sHYf-HnP9KVWn_pJSIqLg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RniAFVrXohl5GCdmAgRzQWf65yTOAps5tF7in1UfPhm9P/EJc75mGEBb9p9zBw9MjnLBU/KWIeOBRQ3LgeCZuijKxWBAxAArSecSjCVvBcg3P95O8htQxvyUFwlryqjP53mzVGtrypGfC9gSNsBzJ7mG4lTghfZLXkWjtStiRQapx1i9sFz8RVFJOXw6tmhVDmmwnLZH8eWEYWb/c46Pb+VCaG7xgPm2dWmVSKEpMYs7HW2BbcGF6K3PsFgk+J8+dTyhU2YWjPysdgp6WpgszcjpbTCieVeMxwbs+c6dQMTMtm5gugQ97yXq/VO6dT+OuPJn01fNQkj0fpN29VvHXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AxXb2q1oUETyJ7PsVy401gMfDPmQTQmTFh3OQgqkoNo=; b=RNicC+FIsrgsFVtUGioHkBw2vD6kEQX9Nds5K1PmUy6unYv+xhmxDtqZdb+t+N4cFkwFAFS9mKbqNXRzUHBXKkuIdMiE1Ne4ykt0VsGSeaHyEtu1wOpV7R2ipDI/xLrsSUyu0cMCbEekeJVC/BL0OEm/ppBOz7qPXkgzFpRbAGyQmjcjgsQklVyN3ReRc/uQmNWIAqqvn+b02HgbaoXNnU0p0Lp4B+gIFCkztdTmTiuIOgZrj1heT7QyZof/WVsfBL3kVhnxpiJ4EElhXwe887LRXbMwzD0AjJD9WKREWtFtdDRPrCeQqOLCF1vJVu3ld2svUZwqBK3cJZmnw/+jag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Fri, 14 Jan 2022 14:08:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4867.012; Fri, 14 Jan 2022 14:08:01 +0000 Message-ID: Date: Fri, 14 Jan 2022 15:07:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20211229193949.146079-1-hjl.tools@gmail.com> <11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com> <5843914b-e666-3c55-2e5b-5b320d55cf51@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0069.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::46) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 540d5316-a563-470c-3199-08d9d767464a X-MS-TrafficTypeDiagnostic: VI1PR04MB4349:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BsxqZA2MxuMJjI1BsEYDy/cXoLK1QVdei2d4O2VtoHG09eiiKz9r1A7UcMXSEwNs2e9K6UjEzH7ybuPTYyvNYu3S66q+1qHnK/CbP2wdmwq8ofUpa+kB9oWgrF6oawxm6wALLS6N3T7oaM1XVJIqqevrDfgjKKSVvJutXDWK88Kd4LTxjPC+hFa0VDtth9WgxdSd33KOWAOUeRcBgHF1E/hqm4sHMAs0vcgo/6M2+Rmbm4O25V0vYFIg+wWPMzDNNmaXEqPutD3qpXxhx2iNfpqunPWipahI54pUoCGVNlsOG9ClhVcwQP92hXxY6mu/Ztfql11o9zNB2fyE/P9vZ69+rvqgbFfltbVbFjtVISA2wfj0Oi8EbKwbRvKO7QNrRbFef2VMPNp717hiYDSRUehwF70ekEHDv+3Wute7JnmisO5mdg6ny8atlrZm5srzdhmQjwrgP7IqsS+FpVSdVfYuu5eYC5cviMaZu3vcrZtaz/ZUC54I9+QdeDyHQECBpuG5Bsfd0Xgn8rVyfmbHqumHvn6jdMA7Kf2cRxuoOrVNWVInF744pCgmhu8Gj6P9afsDybvdkvPDWMMOWV0Z7w5APKGJyAjA6//lNwNgnUV2UBEdRTaIvleVGRPt0B/5wxByTl2oCeDCzev9g8xYY9RFZjjYBn5dajJp67k8pvvOKNZsSYVJKKFCEfqfRPzaRyly3uotA+BT8HIj7PeP6xvmEVKLJ2xu6pXZiN87SV4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(8676002)(31696002)(66476007)(66556008)(6512007)(6486002)(508600001)(316002)(5660300002)(38100700002)(26005)(8936002)(86362001)(6506007)(4326008)(6916009)(83380400001)(2616005)(31686004)(53546011)(66946007)(36756003)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MStYVlI3NVZvejhsOEt2VTZBZjRwN3d4bHpjSG1JZStFQ090OFdvZnpiMk1P?= =?utf-8?B?bENzY3N5U003ODFJeGRxY1d4TFhwZTc5SitRRU8rem5weHpKQmZxZWc2Y1Vp?= =?utf-8?B?cndDSjBKdU5iQVJRSStOVHFwNkFwTFdNb01IUDZWM1ovR1NIQytOcEMrdnVk?= =?utf-8?B?MitpR2srL2pRUWRJaG8vWnBxOTZ4NHBncmphSWZpNG9tdE9JZlQ3NzB5L0NI?= =?utf-8?B?REJvN20rbk82VGIxdk1vSk1yMzJ3dW0zcDVGTVVxUks4eGtpWGI0bW00ZGhI?= =?utf-8?B?QmIrQnZQYlpNUUlSY05JMS9lUnpqTG5IbjZVSHp2cWdYTXN3a2dzRjFpcFda?= =?utf-8?B?bSs3aFlXNzVJaVBsYWVsc0VLdExxZUg5NkhZSXFTRVNvd05MbXp0eEEwREFN?= =?utf-8?B?d2NaalVvTWJoaW5RaU9PUGQxaHFPNzVqNG93ckkwVUdhTHRiNWtld05lZUdq?= =?utf-8?B?UlMvTjJlSlZkcHpJS05yakd4a0dFa0p4dWpwR21ub3d3RzUyd2Z5aDAweFZk?= =?utf-8?B?d2lncmpKTVFpd1FVV0dEMGE0MEhLR3pxQmRnMlFHVWVMNC8xcVJyaXBFZFBY?= =?utf-8?B?Sk1DWU1MYUZVU0ZBUUIrUjFsNnBKck9SNXpEeVhaQ0pwdkIrNmNISWprcHFm?= =?utf-8?B?QzlCaFE3QWVQMjRmMnhJRXVVUklPODJUVnhYYVk4ZDhUdmZ0NEtXK2Z4Q0g5?= =?utf-8?B?SWdkK1pYRlIrTjBlbjgwM2M2ZzJrclF5NmRFNlRlQ3V4MzB6ZWV2QmxzZDNy?= =?utf-8?B?eUF4Smo0Wm1FM2Y2VkRia0xCaFBienhXbEFBam5pTlNRQS9oOGRBWFpkRUlv?= =?utf-8?B?bncwQ3RlWUEya2FORlluSHdkeWNIR25rbjl4ZEt0RThuK2V5SHNnMjVnUlBj?= =?utf-8?B?VDRXMFZwamxHODNuczN0NlViaXZZY3pXUUl5RUkyWXU2a2ZHRnplYUl2eEJi?= =?utf-8?B?Qk03cmZpckt3bFJTdi85c01HVnhnLy9TRTNqVXZxdlM0ZzZsMVdYS1o1Nldp?= =?utf-8?B?eEM5bVYwRUlNZFVGcXIycEkwenNWNGFZeDZpb01JY0xKdEJPbmpTNFZKRHBx?= =?utf-8?B?NnFIT0VWdU8xM0ZOOFFUYWF6bGUyOEh2U3E2RkhQcGQ3ZmV0bmJRbUgxQlg1?= =?utf-8?B?Uk1WckhJZlJMd094MzZlTWFDTVp4MEZheGx3VWlZM2lPSmtXUDg0Z2NSOUJl?= =?utf-8?B?RDZ6UGF2UUNCQmJ4L1lCRmpvYWdJS3doT00yUFM1aldFQVh0bGhuUDlHdWtp?= =?utf-8?B?Z2NlTkdDc2R5ZXBlR0RINGdBOUJGUC9IQXRCS25td0ZwdGVWR1lNMjdwMjFI?= =?utf-8?B?bndHVEU1bktTVnJUN0p3THpwMmdNOUZYbHVoSnlGa0EvVUVHZTdDd1MwTEdH?= =?utf-8?B?eW1qYlFocUdpNVhmb09kdmZJRUJUZ3JYYkhNYjcxMkNJaVRJL2F4WWRRaXFE?= =?utf-8?B?Wjlsby95QnhYaDRpR0tCaEt5ejVGOHBIcmRNYjhCcVJlT1RQb05xNTlnKzhp?= =?utf-8?B?VERERjVTZERYVVNIY2x0UkpibE4wbnIxamNQRVdpT3pGVFNjRnNkUGxhUXRm?= =?utf-8?B?TXdTeVVTdjdnNXIzQjh3VFU4K2o2YlVXSVlYR3V1RitLSTRUTDFQeVhkVHIw?= =?utf-8?B?eGc3U3M4YmhJbUpacGRuUFdsV1BGSmU5eC95eVBVbnlQMkQ3dzZ6bkFYRUtP?= =?utf-8?B?NEZlc0IrcGJvNDd3ZWxRTmZzNFNaUGZndERreituZEVXWUFnc3BwSzZhZlpH?= =?utf-8?B?UDB4V3d4cjQwTFZVS0ZnNytQa1dTZTJMZXZwVm1wVHdlM1hjeWRrNUlrN1Rz?= =?utf-8?B?ZjN6aWphaDc0YlJYTmhNWW85bHJxWjVpRUJUdUl1M1FYM3k3QWlVY2sxWmJP?= =?utf-8?B?S0o5ejFkR2F1dEkyV2JnZ21kMUowQjUrM3lrZW9mU3VteDJqcjBzZVUrVmN6?= =?utf-8?B?RW53R1dUQSt1RXNHeWc1c2pJU3pvaGxlVk9vdS9NZUt1QlNjRWJISnZDOHdy?= =?utf-8?B?Tm45ZVFZWWV0NDNKOVo2bm9NKzVwSHlDa3VUSlhPNTRyV21yRFNGVWt3ZWs0?= =?utf-8?B?NEJDZm9JelNYVFpzOFFvZlJ4VW5iSEk5OG9nZC91RzZrS1ZZK1l3ZnpNQlRS?= =?utf-8?B?T0dRelFZL1IyeWsyUDVCTGVCYWgzREE1eGY2MHcxems5NDByVDBVRlpYZjFr?= =?utf-8?Q?3aGxDM51Bk+5TIgaulmtOTI=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 540d5316-a563-470c-3199-08d9d767464a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 14:08:01.1865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dN6TLqC1U8xL8vJZd/FO+WIU4OPwgThRWoOX6pQ20lJszMTAAiF0Oq1ksb1kjpgRM6lMSazqwmkKvgSGFkuPQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349 X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 14:08:06 -0000 On 14.01.2022 15:02, H.J. Lu wrote: > On Fri, Jan 14, 2022 at 5:40 AM Jan Beulich wrote: >> >> On 14.01.2022 14:03, H.J. Lu wrote: >>> On Fri, Jan 14, 2022 at 12:27 AM Jan Beulich wrote: >>>> >>>> On 29.12.2021 20:39, H.J. Lu via Binutils wrote: >>>>> --- a/ld/testsuite/ld-elf/linux-x86.exp >>>>> +++ b/ld/testsuite/ld-elf/linux-x86.exp >>>>> @@ -185,6 +185,42 @@ run_ld_link_exec_tests [list \ >>>>> "" \ >>>>> "tmpdir/indirect-extern-access-2.so" \ >>>>> ] \ >>>>> + [list \ >>>>> + "Run p_align-1a without PIE" \ >>>>> + "$NOPIE_LDFLAGS" \ >>>>> + "" \ >>>>> + { p_align-1.c } \ >>>>> + "p_align-1a" \ >>>>> + "pass.out" \ >>>>> + "$NOPIE_CFLAGS" \ >>>>> + ] \ >>>>> + [list \ >>>>> + "Run p_align-1b with PIE" \ >>>>> + "-pie" \ >>>>> + "" \ >>>>> + { p_align-1.c } \ >>>>> + "p_align-1b" \ >>>>> + "pass.out" \ >>>>> + "-fpie" \ >>>>> + ] \ >>>>> + [list \ >>>>> + "Run p_align-1c with -Wl,-z,max-page-size=0x1000 without PIE" \ >>>>> + "$NOPIE_LDFLAGS -Wl,-z,max-page-size=0x1000" \ >>>>> + "" \ >>>>> + { p_align-1.c } \ >>>>> + "p_align-1c" \ >>>>> + "pass.out" \ >>>>> + "$NOPIE_CFLAGS" \ >>>>> + ] \ >>>>> + [list \ >>>>> + "Run p_align-1d with -Wl,-z,max-page-size=0x1000 with PIE" \ >>>>> + "-pie -Wl,-z,max-page-size=0x1000" \ >>>>> + "" \ >>>>> + { p_align-1.c } \ >>>>> + "p_align-1d" \ >>>>> + "pass.out" \ >>>>> + "-fpie" \ >>>>> + ] \ >>>>> ] >>>> >>>> The two PIE variants of this also fail for me on glibc 2.26. Looks >>>> like LOAD segments' alignment isn't being honored there, at least >>>> not if it's as big as it is here. >>>> >>> >>> The PIE alignment needs the kernel fix: >>> >>> commit ce81bb256a224259ab686742a6284930cbe4f1fa >>> Author: Chris Kennelly >>> Date: Thu Oct 15 20:12:32 2020 -0700 >>> >>> fs/binfmt_elf: use PT_LOAD p_align values for suitable start address >> >> Well, then the test needs to be skipped if that fix is not in place. >> After all you're testing binutils behavior here, not kernel or libc one. >> I'm running a variety of (largely up-to-date) kernels on all of my >> systems. But it looks like our kernel folks decided against backporting >> this particular change. And I don't think you expect people to remember >> to run the testsuite only on top of "certain" kernels? > > Care to submit a patch? I have no idea what to check for. I would really expect you to fix such an issue (or really two of them, considering the other problem) recently introduced by you. Jan