From: Nick Clifton <nickc@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>, binutils@sourceware.org
Cc: Sterling Augustine <augustine.sterling@gmail.com>,
David Weatherford <weath@cadence.com>,
Marc Gauthier <marc@cadence.com>,
linux-xtensa@linux-xtensa.org
Subject: Re: [PATCH] gas: xtensa: fix incorrect code generated with auto litpools
Date: Mon, 10 Apr 2017 12:15:00 -0000 [thread overview]
Message-ID: <bb580d8f-a1f4-5dae-aa32-bbdd13f22d54@redhat.com> (raw)
In-Reply-To: <1491427212-18970-1-git-send-email-jcmvbkbc@gmail.com>
Hi Max,
> gas/
> 2017-03-31 Max Filippov <jcmvbkbc@gmail.com>
>
> * config/tc-xtensa.c (xtensa_maybe_create_literal_pool_frag):
> Initialize lps->frag_count with auto_litpool_limit.
> (xg_promote_candidate_litpool): New function.
> (xtensa_move_literals): Extract candidate litpool promotion code
> into separate function. Call it for all possible found
> candidates.
> (xtensa_switch_to_literal_fragment): Drop 'recursive' flag and
> call to xtensa_mark_literal_pool_location that it guards.
> Replace it with call to xtensa_maybe_create_literal_pool_frag.
> Initialize pool_location with created literal pool candidate.
> * testsuite/gas/xtensa/all.exp: Add new tests.
> * testsuite/gas/xtensa/auto-litpools-first1.d: New test results.
> * testsuite/gas/xtensa/auto-litpools-first1.s: New test.
> * testsuite/gas/xtensa/auto-litpools-first2.d: New test results.
> * testsuite/gas/xtensa/auto-litpools-first2.s: New test.
> * testsuite/gas/xtensa/auto-litpools.d: Fix offsets changed due
> to additional jump instruction.
Approved and applied.
Cheers
Nick
prev parent reply other threads:[~2017-04-10 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 21:20 Max Filippov
2017-04-10 12:15 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb580d8f-a1f4-5dae-aa32-bbdd13f22d54@redhat.com \
--to=nickc@redhat.com \
--cc=augustine.sterling@gmail.com \
--cc=binutils@sourceware.org \
--cc=jcmvbkbc@gmail.com \
--cc=linux-xtensa@linux-xtensa.org \
--cc=marc@cadence.com \
--cc=weath@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).