From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59739 invoked by alias); 10 Apr 2017 12:15:58 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 46760 invoked by uid 89); 10 Apr 2017 12:15:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 12:15:27 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55FD7635E2; Mon, 10 Apr 2017 12:15:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 55FD7635E2 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 55FD7635E2 Received: from [10.36.117.92] (ovpn-117-92.ams2.redhat.com [10.36.117.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0630F90C6A; Mon, 10 Apr 2017 12:15:16 +0000 (UTC) Subject: Re: [PATCH] gas: xtensa: fix incorrect code generated with auto litpools To: Max Filippov , binutils@sourceware.org References: <1491427212-18970-1-git-send-email-jcmvbkbc@gmail.com> Cc: Sterling Augustine , David Weatherford , Marc Gauthier , linux-xtensa@linux-xtensa.org From: Nick Clifton Message-ID: Date: Mon, 10 Apr 2017 12:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491427212-18970-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00098.txt.bz2 Hi Max, > gas/ > 2017-03-31 Max Filippov > > * config/tc-xtensa.c (xtensa_maybe_create_literal_pool_frag): > Initialize lps->frag_count with auto_litpool_limit. > (xg_promote_candidate_litpool): New function. > (xtensa_move_literals): Extract candidate litpool promotion code > into separate function. Call it for all possible found > candidates. > (xtensa_switch_to_literal_fragment): Drop 'recursive' flag and > call to xtensa_mark_literal_pool_location that it guards. > Replace it with call to xtensa_maybe_create_literal_pool_frag. > Initialize pool_location with created literal pool candidate. > * testsuite/gas/xtensa/all.exp: Add new tests. > * testsuite/gas/xtensa/auto-litpools-first1.d: New test results. > * testsuite/gas/xtensa/auto-litpools-first1.s: New test. > * testsuite/gas/xtensa/auto-litpools-first2.d: New test results. > * testsuite/gas/xtensa/auto-litpools-first2.s: New test. > * testsuite/gas/xtensa/auto-litpools.d: Fix offsets changed due > to additional jump instruction. Approved and applied. Cheers Nick