From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 3A0E9385828E for ; Mon, 27 Jan 2025 15:48:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A0E9385828E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A0E9385828E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737992905; cv=none; b=lbVjMuM3p99D46QRG4jSGw/2w7PIcd2/A7ZQo7iGakLX//Piwh1p0n9XNtDIjjIc+2lTQweos44qUb1x7EjY3FXuthr2/V6DVL0tlEXz6ZHGoJpzFibl9o8Vo3pZr6kQG+W/OQ8WicYAIiQpJKJQcWMPZwp+r/uf+Dhbi1VguAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737992905; c=relaxed/simple; bh=Z5xXSSh5Qzo9beO4OOCvowyyggudpG341Biio4PqSzE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=awkjb+mJxfg61Mee1rGsX2i8L5rg/uEjsPlWwPOUd4WPsyN3DQ0VPSIMf85CJ4uqU+IuTdBn4zl62RkqVu3EXzN6z1m0lpfjxLaz4lrPIY7cwjW+tiuNaVspmJHmW0U/g7/dvF7ZMJ6MiIGD9dfJ4dX7ZwA8/+yDsNsu5B3UQ8s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A0E9385828E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=UP7b8c0m Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50REUJsG016261 for ; Mon, 27 Jan 2025 15:48:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=Sg1VV6 +IFYEHEXUHSywjfoBNQ2FVv8W9Gx0t/Wx5XiQ=; b=UP7b8c0mUvm5IJzx6kNd+s Jn+MFri+WdT2F0h31FvyRbZ1BTbY0AFuchafpnDip3S5runbnpcROxhgtUfDid1A Ct1gNeUE/hz2z50K0TmUTy3+7jbrVI8joXMa1VE/v8wnhC3DKQjhmyqEJxOCqixJ atJjP6w/KB/+7n0MQ3TuS8Lp5ygxeoIg8zEFcSkdiL2LDE7sKxBouP1+sVETomll PZ7dvRPYywYemmu5sv9PdLXgg7D9iYYyUjgPTehoNqHIzlf5qCiURDgnfX2Y5X8j dU8AjwnldnEzaHa+b/RnWc92J1F+G/v4/uKA+ymUeE8v18Xh6+nq3OVuZU91d4RQ == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44e0yyb7nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 Jan 2025 15:48:24 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50RDI36v022175 for ; Mon, 27 Jan 2025 15:48:24 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 44dcgjemex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 Jan 2025 15:48:24 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50RFmKh354264238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 15:48:20 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E352200A6; Mon, 27 Jan 2025 15:48:20 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3FE6C200A5; Mon, 27 Jan 2025 15:48:20 +0000 (GMT) Received: from [9.171.164.20] (unknown [9.171.164.20]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 27 Jan 2025 15:48:20 +0000 (GMT) Message-ID: Date: Mon, 27 Jan 2025 16:48:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] s390: Generate .eh_frame unwind information for .plt section To: Andreas Krebbel , binutils@sourceware.org Cc: Andreas Arnez References: <20250122141058.3996604-1-jremus@linux.ibm.com> From: Jens Remus Content-Language: en-US Organization: IBM Deutschland Research & Development GmbH In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: hWdr-NShvZ_cxuSQQw6DOh0aXAGnauh5 X-Proofpoint-ORIG-GUID: hWdr-NShvZ_cxuSQQw6DOh0aXAGnauh5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_07,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 malwarescore=0 mlxscore=0 impostorscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501270124 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks! Committed to mainline. Regards, Jens On 27.01.2025 10:12, Andreas Krebbel wrote: > Hi Jens, > > Patches are ok. Thank you very much! > > Andreas > > > On 1/22/25 3:10 PM, Jens Remus wrote: >> This enables the linker on s390x to generate .eh_frame unwind >> information for the .plt section.  Based on x86-64.  This enables >> e.g. perf to unwind through PLT entries.  Furthermore this lays the >> foundation to generate SFrame stack trace information in the future. >> >> Patch 1 resolves an issue in the linker s390 emulation option parsing. >> This is a prerequisite to add support for linker option >> "--[no-]ld-generated-unwind-info" in patch 3. >> >> Patch 2 adds basic PLT generation tests that are extended in patch 3. >> >> Patch 3 adds support for linker option >> "--[no-]ld-generated-unwind-info" and enables the linker to generate >> .eh_frame for .plt by default. >> >> Regards, >> Jens >> >> Jens Remus (3): >>    s390: Fix linker s390 emulation option parsing >>    s390: Add basic PLT generation tests >>    s390: Generate .eh_frame unwind information for .plt section >> >>   bfd/elf64-s390.c                         | 126 ++++++++++++++++++++++- >>   ld/NEWS                                  |   6 ++ >>   ld/emulparams/elf64_s390.sh              |   1 + >>   ld/emultempl/s390.em                     |   6 +- >>   ld/testsuite/ld-s390/plt_31-1.s          |  40 +++++++ >>   ld/testsuite/ld-s390/plt_31-1.wf         |  32 ++++++ >>   ld/testsuite/ld-s390/plt_31_non-pic-1.pd |  54 ++++++++++ >>   ld/testsuite/ld-s390/plt_31_pic-1.pd     |  57 ++++++++++ >>   ld/testsuite/ld-s390/plt_64-1.pd         |  38 +++++++ >>   ld/testsuite/ld-s390/plt_64-1.s          |  26 +++++ >>   ld/testsuite/ld-s390/plt_64-1.wf         |  33 ++++++ >>   ld/testsuite/ld-s390/plt_64-1_eh.wf      |  31 ++++++ >>   ld/testsuite/ld-s390/pltlib.s            |  16 +++ >>   ld/testsuite/ld-s390/s390.exp            |  28 ++++- >>   14 files changed, 488 insertions(+), 6 deletions(-) >>   create mode 100644 ld/testsuite/ld-s390/plt_31-1.s >>   create mode 100644 ld/testsuite/ld-s390/plt_31-1.wf >>   create mode 100644 ld/testsuite/ld-s390/plt_31_non-pic-1.pd >>   create mode 100644 ld/testsuite/ld-s390/plt_31_pic-1.pd >>   create mode 100644 ld/testsuite/ld-s390/plt_64-1.pd >>   create mode 100644 ld/testsuite/ld-s390/plt_64-1.s >>   create mode 100644 ld/testsuite/ld-s390/plt_64-1.wf >>   create mode 100644 ld/testsuite/ld-s390/plt_64-1_eh.wf >>   create mode 100644 ld/testsuite/ld-s390/pltlib.s >> -- Jens Remus Linux on Z Development (D3303) +49-7031-16-1128 Office jremus@de.ibm.com IBM IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294 IBM Data Privacy Statement: https://www.ibm.com/privacy/