Re: [PATCH 2/2] elfcpp/dwarf.h: Add new DWARF5 constants to DW_LANG enum

[Jan Beulich <jbeulich@suse.com>]

On 10.12.2024 13:23, Alexandra Hájková wrote:
> --- a/elfcpp/dwarf.h
> +++ b/elfcpp/dwarf.h
> @@ -247,6 +247,15 @@ enum DW_LANG
>    DW_LANG_C_plus_plus_14 = 0x0021,
>    DW_LANG_Fortran03 = 0x0022,
>    DW_LANG_Fortran08 = 0x0023,
> +  DW_LANG_C_plus_plus_20 = 0x002b,
> +  DW_LANG_C17 = 0x002c,
> +  DW_LANG_Ada2005 = 0x002e,
> +  DW_LANG_Ada2012 = 0x002f,
> +  DW_LANG_Assembly = 0x0031,
> +  DW_LANG_Fortran18 = 0x002d,

Why out of order?

> +  DW_LANG_C_plus_plus_23 = 0x003a,
> +  DW_LANG_C23 = 0x003e,
> +  DW_LANG_Fortran23 = 0x003fi,

You're also omitting quite a few. Why? Many certainly would fit ...

> --- a/gold/gdb-index.cc
> +++ b/gold/gdb-index.cc
> @@ -371,9 +371,13 @@ Gdb_index_info_reader::visit_top_die(Dwarf_die* die)
>  		|| this->cu_language_ == elfcpp::DW_LANG_Fortran90
>  		|| this->cu_language_ == elfcpp::DW_LANG_Java
>  		|| this->cu_language_ == elfcpp::DW_LANG_Ada95
> +		|| this->cu_language_ == elfcpp::DW_LANG_Ada2005
> +		|| this->cu_language_ == elfcpp::DW_LANG_Ada2012
>  		|| this->cu_language_ == elfcpp::DW_LANG_Fortran95
>  		|| this->cu_language_ == elfcpp::DW_LANG_Fortran03
> -		|| this->cu_language_ == elfcpp::DW_LANG_Fortran08)
> +		|| this->cu_language_ == elfcpp::DW_LANG_Fortran08
> +		|| this->cu_language_ == elfcpp::DW_LANG_Fortran18
> +		|| this->cu_language_ == elfcpp::DW_LANG_Fortran23)
>  	      {
>  		gold_warning(_("%s: --gdb-index currently supports "
>  			       "only C and C++ languages"),

... the purpose here.

Jan