From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 1CB20386102E for ; Thu, 11 Jan 2024 07:59:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CB20386102E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CB20386102E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704959991; cv=none; b=G9cipKvN8rp26HizCwkhSGC/fePtOh4GEmLy+l+FeQ9fMcPfo5YDi8qgl06SmuXg2xzT/VfXsh+yBuDVdhdvWBiW0BOprWe83IsTrE6m7ZxtJpE9DCkL/NucXY47fNdy40zXugirX4acoC0O0LFMrSh8rH/R6o7m2Y9a8TdL/lU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704959991; c=relaxed/simple; bh=sUlT5vr5un9ELK2dfaf4YEDaJ4jFWVMK3jvPUByM1GU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ebvo/m+cAYY+9HJt5d2+A+TNSuq+941s3cogSHsUw3a5LTiLJJBDAAfyICE3A6iZmv7IFBsVYjr5Z1V1Y/vlK8SEs/hFwfCfAuvE44dm253KRL5OVO3+b/Oj/Xys+AutTFoPhKY8ujd/3J+Y8H0RFs5Rt4TorFdqxuva53bNN9Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40e490c2115so23010345e9.0 for ; Wed, 10 Jan 2024 23:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704959988; x=1705564788; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VlOxGpde6mYe2yvnHbYITYCNyUPKjmmmcr69eaq54mo=; b=QvBfmGL6frp7wMyQ3/+3XsBrGo+tm/nvlbgtS1B52rCIouF7qHhiBs5R6k8h4M5f/p QmAGei41GtRqGOsLktqzshOkqHRDY6G85VsymoLtPYuPKBk/FP8otj5h1aZQDAs1N+Fs WZkCXNnQCgy8c5qjSVJcwjEmJwKh1Y8Qxh/O3svBx6NtCwaZ+C5YronBMJNWVeWZkJuI vcNvy5sjta5HHaA12Mv3nJz5BL8M5mptt/dMNsXweU6SulO9CYSNYkWtNW8p84KrYs3s cYXfaH27xH7+pHKQKaRC41zyOfHsIo9gvz/GY3Hf/oMa8t7qG0pDqlkOorro6kXScBQt 64yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704959988; x=1705564788; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VlOxGpde6mYe2yvnHbYITYCNyUPKjmmmcr69eaq54mo=; b=YK/BVquy+R/mKsJVKKn/HS8HBRH297H4hxCUQ4FL1gZ7x3Sqh1IzISWmJ8VRWUZ/Kq 9gQDmGAinCsypkabdynhQll1GKLkN0etakoXezbBkKfVz0N058jTMAhGQ0UoAXLeM/Q3 4lt8srR9VrP7uR3zwcybpoI4UjenH+H5MtDb5Nvij0YR3IkJSJnnk5f7LZCahsasM5jv MqWTK6fNm0iPiAnNFOUMBMfmnN4/xVW6cu2Yec2WhGqBYh13plYnT1CWRsAbJUVPc6xW FYGwvuI0fGfB/yT/xiQSV48exvMvXWFreN+EeoLexAzdVH9vthSks6hHH8MusIN7nRl7 x0Rw== X-Gm-Message-State: AOJu0Yx9Xb0EC0dWCdHUzNXzUVLyK0lg1pywu2MekHVVZMQAaQlN12If Ic9DgTJnQ1ed03zZ+djP3UlyItYdaNXJkRFLI7gxX9pu+w== X-Google-Smtp-Source: AGHT+IHyo/dLxXkE1qVjAuMZYeGKS4vABGZAlCgsKioaP5rDgZmvX23DsVLRZdDEIWx9hObcIBulCw== X-Received: by 2002:a7b:cbd8:0:b0:40e:5542:4a83 with SMTP id n24-20020a7bcbd8000000b0040e55424a83mr141570wmi.106.1704959987819; Wed, 10 Jan 2024 23:59:47 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id t13-20020adfe10d000000b0033668ac65ddsm511973wrz.25.2024.01.10.23.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 23:59:47 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 08:59:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V5 14/16] opcodes: i386-reg.tbl: Add a comment to reflect dependency on ordering Content-Language: en-US To: Indu Bhagat References: <20240111074820.2677826-1-indu.bhagat@oracle.com> <20240111074820.2677826-15-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240111074820.2677826-15-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.01.2024 08:48, Indu Bhagat wrote: > [New in V3. No changes since V3] > > The ginsn representation keeps the DWARF register number of the > operands. The API ginsn_dw2_regnum relies on the the relative ordering > of these register entries in the table. Add a comment to make it clear. > > opcodes/ > * i386-reg.tbl: Add a comment. Okay (not sure if I said so on an earlier version already). This is fine to go in at any time. Jan