From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by sourceware.org (Postfix) with ESMTPS id CC4D03858CDA for ; Tue, 6 Sep 2022 06:40:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC4D03858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iGai40rJ/NcqgCQ1ejz0tlsQejZMECsNCoVi23KCuo09POQCj68BJe9SdCy2Q1znbyyWwlVDzBw6EErFrOV19LzqdsharSzRpoWg5zY91OQ3rTl6Qw9urQd9zyrGsIfCtUo3vy3SK+iHZH16MdVti6A5+LuE+b3Z1iWC7henxIbqRqKUPCwp7f8BlRtFcSvVjc7He+wrN/rKe6Ofj9jYpD4XbCod2HucdzofIF+Oas4YIEnZdmb0fWalU5DVeWOKQgalWMsXXrAItPhIZwUKonBgkbYnZ9ehGdqLx+lJfYR3q13OvAaV9Axy8Ye84I6zQUugFelDF1H8iNBOssjUdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M3RYV9P2PWnrzQsjXQUdTNhyED5gp8JmSNutQ61wNI4=; b=B2jn0RxvtKJOdPI/RBjKtgbLzvuZGIBAOrOpm2vvXl3MIMiHZBCxcXHkqEQZSjpz/IPyXlkEV+3wcYOZ0H5iJY16Qy4HPotmRcws4p/uNq9awjUNoN89NkO78yJOmOLOrXiUY35igbbp5dv4TnekCGl+bB/oeFzkqJjY7Gx4yjcfjjFTjAZx/B7Wjh0hkuwL8SpyjP1LmwA713o9pl+69mOartiGhGw7n1Yk9cRURh+F9KBRor8lEiQILgvWY7gwq2PHir995ZzoNaH4TQ6s0zLNy1Kl0Oy/Y7LedIF8A8UVLE3nTYmCXW+IzZFMppDw9+jlLVaWfzhOSwMFR3Buug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M3RYV9P2PWnrzQsjXQUdTNhyED5gp8JmSNutQ61wNI4=; b=38e+c9l4Ot7BAUcrAb4vyP4QzEQ6jqmPDJpBTLaVEzFaDvpfwrbcrjbB91aYqlzkJS4FiQp0W8GoU7lQID0RtYQUjU++vvPVQ2yPayx2pYNLqMTQ65RVRrYtObp0ml6mgL8Ei0f3MkSAv9vDLxH/b1Hhd6+5Yw5+ovaRTKKUCgfP8c/h/bttPqMnOd/xvCQ576mj6996MsMoDEOgo9z9dDif6JOicHrPb97IzRwpV71C8kLI5hRLrRnKHXZHoATlUNd3IYqYrqAtsYdV1fj3jsoCM0GSo8iYVei2BpZkSqgAQr5ObcHIzF9h8o1wULpy2j7DSpiPogs51SifkY+Fjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5842.eurprd04.prod.outlook.com (2603:10a6:208:125::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 06:40:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 06:40:51 +0000 Message-ID: Date: Tue, 6 Sep 2022 08:40:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 5/7] x86: re-work insn/suffix recognition Content-Language: en-US To: "H.J. Lu" Cc: Binutils , Nick Clifton References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> <995353db-27f3-ea60-8e69-32bcc44dfd49@suse.com> <162c053b-7c68-67b8-1443-926f2ebb321d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0596.eurprd06.prod.outlook.com (2603:10a6:20b:486::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 138bc251-ebc5-4349-cc21-08da8fd2bda7 X-MS-TrafficTypeDiagnostic: AM0PR04MB5842:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VBdHvkRNobH+OtyNZ/p9X7yJ9JPq6FLWb7Ei+KGb7StpvFcM3B59qG+NNBwO1olzU7Ij/UcpH29QYU5Hl0WDDQUWn5pQh0ak7cbZ8JkskKLlpCPXv7NrMkRWNBxl/aF/45rI/aOSflTcLm+wigRSnpqQgypb8fU+35VWcKjTZAoetnSSc1s+Xr7GOSTGFKJk8uneXzNJTkfgCOCY0D5o5kdlQ6V7l7MGYspeAnEsh/Z9kLj2xR3B+WJ3uMJzeCoRLGh1hwmVmENIzKe2WwrNvfyeSSYtR9khA2koZfguDnunixiL3j6dhweQznwHh320KQ9BS1GFpEa9GlFuVNrewW/d0XhF7VrnNGulk9Sv1+sH9+XHrQjejAdE4+OkEtllOIyJT6ZkxqwXtXmsG8bSq70kTmGELFcXuIKhsd/TXcS1bcd75+wx7KhyiSd61H7t1Yo8u5A2OMVUBx+CP4iJ55iNR9cU7ewdFR7R7Krqkr0ao3LONNRG8LB+nLPc8Dm3s69ZzJBbiP7YKWJw5JTKEY5JmrFMu3UbiOg85FQrhLTmNKdWwZHhQ0Cba01MsJDjBMo/Pj/x9AAf+3awLwuYkNIVm01sOpQbEXhsv4MpAXxl7xGa3MqxBvDOfslaCFZpjvQx9k1njZVkTN4oz4frpGk+7c7VlzvKTmYptaB1U6ewvYLEqEK+eM1izoXGXAulxv5WoYE9Sf7Eo0CJGmJL3sxfxeGmIC5d6KGBoiX8YMitog9AdSZ4B1Mjut/3PIeEX84pxLSSow0yS3+AQu1wtDjhshDtDGYHwoVqq45Vz7A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(136003)(396003)(376002)(39860400002)(86362001)(53546011)(6506007)(26005)(6512007)(8676002)(31696002)(66476007)(38100700002)(66946007)(8936002)(4326008)(31686004)(5660300002)(36756003)(2906002)(66556008)(316002)(6916009)(6486002)(41300700001)(186003)(83380400001)(478600001)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGdESi9aSU1YT1JaZ0ZySWJOcXJ1YWxWWkRSVm9TU0pwcTFhVmhnQjFRMUJj?= =?utf-8?B?bjZBbVUrVzEvcitWb2JCZGRSS2ZreFYwNFZ4WjBYN3l0bU92QWQvSWpZQ2ov?= =?utf-8?B?UEljWW82NjFFUnNkRG81OG5QTGZtUHBlbENRRFlWTC9mNGl3MFgwYjJ0VVdE?= =?utf-8?B?ZFVKUTVtOGlaczJqQ21weThodXJMWjB6eUtmcXNKWXVuem9IOVFVTzZMSzVU?= =?utf-8?B?NjNsT3YvV25oVGV4UmJwdG9DdnkvTmYreW5UL3M0RnRzWXd6ZWpYTG5VcVdM?= =?utf-8?B?L3hWNDI4Qll2YXloSU1Wem1oVzJjUys0MGlURzNMU0lUOWlZZnZQWGxOOGpV?= =?utf-8?B?TVZCUE1weVNJVXpaZDFDcGs3Ti9hZTBOcE5nU2VHdmVCZkVtaDN0SGg2Umpp?= =?utf-8?B?emhQcGlvdGdMSkN1UnZ1VGdoUkNtWDcxOGlaVXNIMTJ1V3V3MlplM3g3cXp3?= =?utf-8?B?NXJneWdNc2lkT1U1Rk9NUEhJWDYrWmpvSTMvRnZjWXQzanhaVmU0RWpsTlVI?= =?utf-8?B?M0pXYkpDMm95cDBMYkhlZ0dVSWwrekJ3dkNaVjBSMy9hTURGZCtoNWR4L1hn?= =?utf-8?B?ekg0dXJLTXNsT24xSXYvLzlHNmZhWGZhSTB3aVFIVDh0N3cweENGd1E4TVNv?= =?utf-8?B?RjJMbC91TjZ0Z29WcDlsQnZzYzlNdVk3NWx0MFlTaVMxMjMvNExIVjhKbGs5?= =?utf-8?B?L2tYbmxDeEZLMERpWEhoWHFpOTNGekI1THpRZW1LNjQ5R0RJcFh1V0lDTEpN?= =?utf-8?B?bDNydFpvdEVPT2pjQWVIMlNpRnREUlhvOHhCcHQxY3JPSExqbFdKUVJkM1RS?= =?utf-8?B?eEthSGJtNjdaa1dnU09NUWRxTVhWUUlYM1V5ajFYS3QyeUlRM1VFRXQ3TEtF?= =?utf-8?B?M2JJRmdKb1JOZVpuL2pvbk8zd01jRjFaYm05RSt3dUZqMktnTWZlekZBVUNS?= =?utf-8?B?aXlhd3NudDgvTnJoNFZVdjJQRnBMd25XWkoxSDRUNURUYXA2RWkvd0s1K2lV?= =?utf-8?B?WVZQYUV2djUvREdaOXIwTkxkUzY5L0dBRlI4aVJ1eW93TFdmV05KRjc0NW43?= =?utf-8?B?YnA3VStVMHVna1VuZWU1bERBQjhDTURqL1M1dTM0LzhHVkNKV1R6UDVxK1Z6?= =?utf-8?B?bHVSNFNMMUlnbTB1Vm5SWUlDNEFQUTI4WmdTWlYzdWw1SGJ4WDRZRFJON2hC?= =?utf-8?B?a3A1YU9RdEUyNzFVRytFdUJmakY5dnB2SStadWIzdjhUZ0dIQWdCNm82TGNv?= =?utf-8?B?VHpSeE9hNUFzUFR6YitIMlhwSXZYMkZUSnV0L0xwRUJxbjJ6Z01hTjNSRkRX?= =?utf-8?B?WTNIZVg0TDhxbzFFRkNMNTQzTHh3ZGFHa2tKS25EcEkxYU9OaUFGcVZoekdv?= =?utf-8?B?VEpDR2MzSGhzWDlVaUx4cUpJM0hmV2R1V05uSExQZGFkSUIrb2l5OVBsN085?= =?utf-8?B?U1JVWnZaWlU0OHo3YXFtMkNjN0x3YjFhcDA5WHRGYmdNbnNsYWFJcWhCeEV4?= =?utf-8?B?cWIwam1TUXZuckpWaWNxSXBZWnlVWXlZMEpsSjBWNGdLY1UwRGQxc3pROFp1?= =?utf-8?B?QzdWT0NSTjc5T3krMkxpbEFzTVA0R2pFczYrMUx0SDIzbG05VUZvdHp6YWI4?= =?utf-8?B?NFFuN05WT3RhenFjTWhzTktEU3cvVG0xWkZmMkRqOS9MYjF4YzFqcUFMT1dL?= =?utf-8?B?cjEyQWY3cXdwWmtwM3VmSldOWGdaUTVqdHhlNFphM3puWWg1WE9wYVJMdmds?= =?utf-8?B?Mm9YUlZDbVFHazhady9DeUlISlBwRXZ5cTVvc0xyS1hjNXY4RHFGZTBGdjIr?= =?utf-8?B?UFdUYlVMZXlGOVFwMTVTdnptWlpDRUpMM1lVY2pZdEtIUEI5bjMxd0duN2JC?= =?utf-8?B?TUEvNVREd08wSzVTR2FTd2dRUEN6cjZHR1E2eDhVM2x1SGxUaUhvRjQ1T3l0?= =?utf-8?B?UW9lL1pJazhSNmphNlllQkg0QW1ZQWRXRzFwelNSbDQrVU9hbWFuZWZDdEEv?= =?utf-8?B?clB0OEs1eWMxTGFPRXN5SU5TbmtKSUdtQnZiTU5HSGxscCtTTlpnM3NVV3BC?= =?utf-8?B?SG5GYi8wZkZzUXc0TUNWTndRdlBXaFgyRXcyaytRa1ZLc0tmekpLQ0ppczEw?= =?utf-8?Q?a3mWr5kDCv+1qAt0cLSZ0X2ih?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 138bc251-ebc5-4349-cc21-08da8fd2bda7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 06:40:51.6328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LUWtLtoRMveI/OoxxwOu0rUzzHfTJaLWaFs9leUAjakBkUv3foK4kr5dWicbeoqRK8yJXzPIMwcj4igxnv8pAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5842 X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.08.2022 20:46, H.J. Lu wrote: > On Fri, Aug 26, 2022 at 2:26 AM Jan Beulich wrote: >> >> On 23.08.2022 04:00, H.J. Lu wrote: >>> On Fri, Aug 19, 2022 at 1:28 AM Jan Beulich wrote: >>>> >>>> On 18.08.2022 17:14, H.J. Lu wrote: >>>>> On Wed, Aug 17, 2022 at 11:24 PM Jan Beulich wrote: >>>>>> >>>>>> On 17.08.2022 22:29, H.J. Lu wrote: >>>>>>> On Tue, Aug 16, 2022 at 12:32 AM Jan Beulich wrote: >>>>>>>> >>>>>>>> x86: re-work insn/suffix recognition >>>>>>>> >>>>>>>> Having templates with a suffix explicitly present has always been >>>>>>>> quirky. Introduce a 2nd matching pass in case the 1st one couldn't find >>>>>>> >>>>>>> I don't like the second pass. What problem does it solve? >>>>>> >>>>>> It addresses the reasons we have various pretty odd (and confusing by >>>>>> their mere presence) insn templates which better would never have been >>>>>> there. If you have a better suggestion to eliminate those, I'm all ears. >>>>>> >>>>>> You can also easily see the issues this solves by looking at the >>>>>> testsuite changes. Among other things this once again is a matter of >>>>>> providing consistent and hence predictable behavior. >>>>> >>>>> Did you mean the error reporting behavior? I don't think we should add >>>>> a second pass just for it. >>>> >>>> No. Certain insns simply were not accepted previously (this is actually >>>> what finally made me think of a solution here; prior observations >>>> weren't severe enough to try to get past your possible opposition which >>>> was to be expected based on past discussions). And certain other ones >>>> were wrongly accepted. >>> >>> Please open bug reports for these cases. >> >> PR gas/29524 >> PR gas/29525 >> PR gas/29526 >> >> But really - what's the point of making me waste time on creating bug >> reports when fixes are already available? > > I don't see them as real issues and we shouldn't make assembler > more complex because of them. I sincerely disagree. As said many times - first and foremost the assembler should behave _consistently_. People should be able to predict behavior for one insn by knowing what the behavior is for sufficiently similar insns, without - as is the case twice here - having to further consider anomalies resulting from _dissimilar_ insns. I therefore also disagree with you having closed some of the entered bugs as WONTFIX. I have to admit that I really wonder in how far binutils is an open source project if (for x86) you alone take such decisions. Jan