From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2069.outbound.protection.outlook.com [40.107.104.69]) by sourceware.org (Postfix) with ESMTPS id 287B23858D33 for ; Fri, 31 Mar 2023 10:04:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 287B23858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYLLDUIrfJ0zA0F8hDPTowIhx3fD+DerEiJex2uNWgEnBx+s2KrknEzWoztV/Xrl0hQQ3di/d9vzXIzIpvuDGBHh8cLTHcWcfHObRZe2XSsgnQc/pJ0qMHJVx8nPvJh7OH6VGMPkJ1yJpAwtFFyy6D/ozuzDTbIbcAV1Kp4Eynq3qA2g0JJuSOpoqR9mejhP3J0hA/9VLs844URpq2QqDECxV/C7Mdhl7DwecKcSN6D6sTSUMgj1rrbTxwEIhbH974becZS2UnAPuZh6yO4lxtUmtjwrkVPsf6pHqeE7HjDBUs4blTd1Zac8M9xuLLp8Z1wyiEZQeg49b2gQ8DbCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rRLzbypgD0aYFZ2tmvPuPq2iRqN8BTYZB/Oh6AAop1o=; b=iQKxk//v0+VtwP0NfHa50/yIIIDby5NchHuyVXQkXsACMFE9BRUIanirq49SBUJc5Frg3SNEaVWwMx+9XtEszA79jxRTUK9jXcaXrlU82BK3veWhCBry1TXVSJYCGfsjyRZalov0XmgcfIQcS0zqlbcC2o7lM8EhV8RR4wlKXqvRBBpjq4mb0I4UfODr22fCJ3q1SJSayZ8QVgv8m2MMZHctTN4Vp/2hkKXvN4QHYMyJ4lbhP59tYnps7HK4P9JqnsgVZqzIWngtwEOYMYrybvhlPraRKQkZXLi+UW2c4eTU7wr7MWxi2YbKY/cD78/pTOVCSw9tLaayLVSkualntg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rRLzbypgD0aYFZ2tmvPuPq2iRqN8BTYZB/Oh6AAop1o=; b=fam0Cw4ZcxIY1cn0rmpN8oGgxq5tzYERdErDTmAXMufAgqpC9T5gnh14qMrk4cS16K+7akCKyeSvG/txK8kKExrX8hC6l/XxCsTCu0fEdi3WHOPFfXzGZ79gQXTC98HRHQgnvKWixVFCOPw7pOO43qPGaYVOowzSY/9+dFcOh/kS4f8vzhVhSKqJPjdgmu5fXo8RRkBKtGg5VnN7y7iCvlj4NkU3tfmE4QQYQIZGl9r3Tnz6jEIKGh2h+YSOW0p5a+wLSg2bbp6GkxuT29bW6YK86sQZKEXg4NA/w9yy07s2btCFteBXLQQoLXY8Sm6fQzlpJqi7HTPa1siNA22JqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7864.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22; Fri, 31 Mar 2023 10:04:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Fri, 31 Mar 2023 10:04:55 +0000 Message-ID: Date: Fri, 31 Mar 2023 12:04:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH 1/3] x86: parse_real_register() does not alter the parsed string Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7864:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c908eb5-aeaf-432c-92a0-08db31cf607a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hHRhq1CiL6YkJA5Q322HTv1BO11NjEn/qZeuqZpSCQ6kdDmhpzX83G7C1AcNiqiUzMDKk38W/J5CHGHMhu3ppV9UZH6vIKsd8fxfIja1cErYzanGVC0bBJz6I1xn+dLbkeksNYKBp6xqWHOKpWb5XrTvY7tmb2gr3PkETmSrxWbttUmHTHgXZVAX01ORWicS/a7UtABlUVepWy1dxSGIwRaErBFnWNx3852Zv4APzCVfZWatYofemnqvW7JSjfYnNRnEjKHLdxdoJiWvof6Te1keymS2nNlj48e7/qSCdFc20vNvJlB7u0/ctrq75tBca5GU/8OGhnwe+f9vpI0D3MnaWlzAnKMVXt/wUq+DyFaKBoumxjz+aaZI580c2goN7KWeOm71AYQttDcoJpRsONsLQYwXsTFuu2ssmXzy2aRUVmdnwu2J6n2j/dUf57ZX0rYzpb+bLsyq6awwoDptx3UJZYAqFiLfDQIu/lx1Pd9X5/HEAAkcRjaYGOe4hc/WmWw/+enlUdJRkJlckzudENizFHOz8lms0yTTES3gq11tDDesMzJxIXjuGoHyAF7WPUmDVQGME49mLUX6LZ66O8fJZUQN94Ijb78xaD+geDysob+bkfhyOa42CvA2gAubRLvpeK4vZvTbQ9ej3M6RtQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199021)(316002)(66946007)(31686004)(6506007)(26005)(4326008)(8676002)(6916009)(66476007)(6512007)(66556008)(478600001)(8936002)(2616005)(5660300002)(186003)(41300700001)(2906002)(6486002)(38100700002)(36756003)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajZCU200VEg4c3M3WUlKcjRsakwvUVlTUlR5UGxLengyNkdXVVZNZXNxNXJl?= =?utf-8?B?YUw3QWd2ZmpaRWJIeW5KQ1JKUkVveW9iVk5rd1BzaGxEUzVQcVpObVczVllT?= =?utf-8?B?aEZObVVQSmMxRmYrdDJKR2ZBUkFRYUJ1TEwvTFFPNkRtM0tQcXVDR2QrNkox?= =?utf-8?B?SWJ6KytRTXFjSDNVeVJXUW5XbjZiTEU1NlRhY1NNRW5OQUFIMzFlSDFEWFE1?= =?utf-8?B?R1ZEZjhyaTNCMWwwODFydXNqOUFET2h2bzUzRWlISWFKb2lqK25tWGVadC8z?= =?utf-8?B?SjhwaHd1OHNoU3QyNWJnRzZlek1KazRCWHpjZHgyZVpBaGVBSDRMUUZqeVlI?= =?utf-8?B?SzdZY1BCWGtWdUNpVzlUMXlVc085Rm9EWEE4eG1TVXhSdGFHa2ZoZkdQR05V?= =?utf-8?B?ZDVja21ISDJleEFZZ2V3bGZLQ3BPWjN4ckNranRnYmhtVENiQ2hvaWEva1h2?= =?utf-8?B?Q0ljZlVzSldHcjEzUFcrWWNZYWZTbnFSSncrdGNvZDVYa3cvS09pSU1FRjdD?= =?utf-8?B?dE5SKytKc0ZER09aeURrNy9KWk5FN3VwdU54Tm9sYWQ1bm10c3k3Si9ySjNj?= =?utf-8?B?SGR1RjBMdFI4cld5dXE0UFFJdUpKM0xXODRHc2txNFNjNFQ3Qkl1ckdVMG9P?= =?utf-8?B?TGlSazNNTkFLQkMrVG5QRGJnWU5GekZTRUVjdzhSOGkrQ0VpVk52VzRONnVs?= =?utf-8?B?dzBqQ1I2MUFmd28zSGtSVEF5blRPQjdyK25QeURTZDg5cVVuZnBpbS95WWJK?= =?utf-8?B?ZXo1R0NFTzZNdlFvUnN0MG0xRHN0SE1scnVqTHdCd3NSUndDb1A4YW1nTDBQ?= =?utf-8?B?SUs3K1FxWXZDZ3ZHeU9CcWJyV3BmMG1aSnE0VlJwbTltSUNYeHhSbUR6RnNv?= =?utf-8?B?U0FCWWhjcE5EOFdPZ0w1NnU2ZTVvVGY0Vk9qKyt0SDM3SUNBWW50Nm5ieStE?= =?utf-8?B?MmQwTVJBSzNrQS9MdHZjaEN0cnRBc3pSQkdBZ003bHpIRG1hMTY2ckY0b00y?= =?utf-8?B?eXZ6UFhIY3BqVndiVm9vTmpKNGEyMXN3cjZ0dytOT2NlQ0RNMG9zQkIzMW00?= =?utf-8?B?RHlncTVWUGdyeFVkRlBBT1AzRjhDamZNcTV1ck5iYURXY1Z4WG1oVTdqcG1I?= =?utf-8?B?Uk1VMGxJNkVRWU5wVHJRZ0QybWh0UmUyYkVSM0YybGhXQmQ4YkNHTTZsTllX?= =?utf-8?B?YVdYUFUyTHlTNmZCeFoxcjFxenBjU0ZzczNsSm5vY01ZQmpCR0wrb2pkQnhw?= =?utf-8?B?b21QcGt3TFpieGpOMXVWamR4SGNlUVh0c3lRZzJNZHpGL3UvaHV4OFJDVDha?= =?utf-8?B?eHFZRXFRUkNuNmVuL0daam01azVXYmhUWW40TVJiQ1IrRjhxRDVXZ0c1M2Rj?= =?utf-8?B?dk0rUTVadFdBZUc3eUhxemQyMWJHaUNpcnlIRk5JL29GOCtNTVVnd0RQblFr?= =?utf-8?B?ZjI1VFA0cE9kYmZxVWJmc2FDQU12ZGhCcUtUampUYVB6NlUrYnUzUnRMa0hG?= =?utf-8?B?L1g2dnVMQ3Q1R0xKK0MxbGg3RE9ORzJyRkpiMGtMYXovaVpVRlR2M3hacVNz?= =?utf-8?B?c1J6OTdhMTRBWk9LaURVb1R3TFhDQVBmSEJOZHBxaEE4N1QwTyszMkZLOUN1?= =?utf-8?B?MzlvVDV3NHRjblo5YlJ1R0VSKzVVcVFnZXlNbEs1dklHZ3FWb00yZk9tQ2lP?= =?utf-8?B?QWZIVmFwMTNWK25aUk1iT2d1Nk5LWWlrN3kraFF4eVRCdk1KdUF1ZnN4M25R?= =?utf-8?B?cHhGMHNnUzdiSWJPMTFtOG02UExmWDBlY1hpZ1hqUDJ5TVVXRklzd29QY2Y3?= =?utf-8?B?ZHZoRUdqWUJVK3U1UlNnYzhQZjFPcml6MFJPWlY5MURQbWk2T2lCaXVRODhZ?= =?utf-8?B?ZW4vRWNwKzJTaXZYUWt2VDY3d2xOTXJLditIUDB0YVk4OE1YZTMraFl1eGV3?= =?utf-8?B?T1kwcGdwY1hZVjBsZTZLOS8yREFLY2RMVmdleFJmdGJJRjdmbmVUakxUNFpO?= =?utf-8?B?RUhSdmc1MThyZXdSQitxQ0k3aTFqN29mVERSYjRnYzJWczQ4T0NLem1aNGVx?= =?utf-8?B?SHh2QUNqMWRWSWllZzJYTGhRMjljNi9pTVlYVS8wVzBVbUlaR3RjUFovL0RT?= =?utf-8?Q?7PMUpnzGLsTFTGCJwr6nAtD9a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c908eb5-aeaf-432c-92a0-08db31cf607a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 10:04:55.1332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zWlA2b2sJXHvOgQ0lNAT4E3cHAZW2NQKIwk/MmCB93USdkqOjyYsZ9vDMAJ93gU9kIIdsnrl2m8X+//NIxP1Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7864 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Follow the model of strtol() et al - input string is const-qualified to signal that the string isn't altered, but the returned "end" pointer is not const-qualified, requiring const to be cast away (which generally is a bad idea, but the alternative would be more convoluted code). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -13749,9 +13749,9 @@ static bool check_register (const reg_en /* REG_STRING starts *before* REGISTER_PREFIX. */ static const reg_entry * -parse_real_register (char *reg_string, char **end_op) +parse_real_register (const char *reg_string, char **end_op) { - char *s = reg_string; + const char *s = reg_string; char *p; char reg_name_given[MAX_REG_NAME_SIZE + 1]; const reg_entry *r; @@ -13774,7 +13774,7 @@ parse_real_register (char *reg_string, c if (is_part_of_name (*s)) return (const reg_entry *) NULL; - *end_op = s; + *end_op = (char *) s; r = (const reg_entry *) str_hash_find (reg_hash, reg_name_given); @@ -13802,7 +13802,7 @@ parse_real_register (char *reg_string, c ++s; if (*s == ')') { - *end_op = s + 1; + *end_op = (char *) s + 1; know (r[fpr].reg_num == fpr); return r + fpr; }