From: Jan Beulich <jbeulich@suse.com>
To: "Cui, Lili" <lili.cui@intel.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 2/4] x86/APX: respect {vex}/{vex3}
Date: Tue, 20 Feb 2024 11:30:51 +0100 [thread overview]
Message-ID: <bd6b0cf1-aaf7-4c9d-b736-33effd7964ab@suse.com> (raw)
In-Reply-To: <SJ0PR11MB560060823EB5500DD20309119E502@SJ0PR11MB5600.namprd11.prod.outlook.com>
On 20.02.2024 11:12, Cui, Lili wrote:
>> On 18.02.2024 08:55, Cui, Lili wrote:
>>>> --- a/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s
>>>> +++ b/gas/testsuite/gas/i386/x86-64-apx-egpr-inval.s
>>>> @@ -207,3 +207,13 @@
>>>> vtestpd (%r27),%ymm6
>>>> vtestps (%r27),%xmm6
>>>> vtestps (%r27),%ymm6
>>>> +# {vex}
>>>> + {vex} and %eax, %eax
>>>> + {vex} and %r8, %r8
>>>> + {vex} and %r16, %r16
>>>> + {vex} and %eax, %eax, %eax
>>>> + {vex} and %r8, %r8, %r8
>>>> + {vex} and %r16, %r16, %r16
>>>> + {vex} andn %eax, %eax, %eax
>>>> + {vex} andn %r8, %r8, %r8
>>>
>>> These two test cases are valid.
>>
>> ... reflects exactly this fact.
>>
>
> Normally we don't put valid test cases into invalid test case file, right?
Depends, I would say (and I think you'll find other examples). I view it as
pretty relevant here.
Jan
next prev parent reply other threads:[~2024-02-20 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:56 [PATCH 0/4] x86/APX: misc adjustments Jan Beulich
2024-02-16 9:57 ` [PATCH 1/4] x86: rename vec_encoding and vex_encoding_* Jan Beulich
2024-02-18 5:59 ` Cui, Lili
2024-02-19 7:54 ` Jan Beulich
2024-02-20 9:19 ` Cui, Lili
2024-02-16 9:58 ` [PATCH 2/4] x86/APX: respect {vex}/{vex3} Jan Beulich
2024-02-18 7:55 ` Cui, Lili
2024-02-19 8:00 ` Jan Beulich
2024-02-20 10:12 ` Cui, Lili
2024-02-20 10:30 ` Jan Beulich [this message]
2024-02-20 15:59 ` Michael Matz
2024-02-20 16:52 ` H.J. Lu
2024-02-16 9:58 ` [PATCH 3/4] x86/APX: correct .insn opcode space determination when REX2 is needed Jan Beulich
2024-02-16 9:59 ` [PATCH 4/4] x86/APX: optimize certain XOR and SUB forms Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6b0cf1-aaf7-4c9d-b736-33effd7964ab@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=lili.cui@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).