From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 43FC73858D33 for ; Tue, 27 Jun 2023 13:58:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43FC73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687874322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=idP2g4uq4Ivz7AL9YUPpR8tgGxvUJiPedxL9yXdQ2Sw=; b=SFmZ6aFn5mue+aH3vRo/lNlBzBq6dH4uwuezj87KCnbI+dzX7Q3frXBQd4e3PwG/D81R0q YNkI61yT0jxMnnkpjN2aFRquSglUWDxlPtQ78rZ3QCbrdbpBFRYFt0LOzzoYofjlNd9kns rPMEvwlaOYWd5SZCJ2TMsoQpK1Z6fJA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-CjAx4gBQMe-47GYO-lnZMg-1; Tue, 27 Jun 2023 09:58:40 -0400 X-MC-Unique: CjAx4gBQMe-47GYO-lnZMg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-62fe5abe808so27382216d6.1 for ; Tue, 27 Jun 2023 06:58:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687874320; x=1690466320; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=idP2g4uq4Ivz7AL9YUPpR8tgGxvUJiPedxL9yXdQ2Sw=; b=jn4Pz1mtMMVJp8pFhkQoQkoqHe87waWgrjigaLWDnVvipG22Rtgf1ooMg7vyjFZ8vK D1PVnykChlcHrvNO09QfWrcukXGxLpwL2wOniK5v6cZ3wiwkqP9EXBqpf+t+ivmKXSHb Xi+ncqbW/DDGNixRBCrzPeb7Fiur5fZq4Zv+37figwhF7ydhpFsuyX5neq8Tjxk08X5j VpESGTWCTwcrchzFUpEe5qvLNNbRHWAtx5+DFXdbM2TUEUSKkdGJXvCcVC5+D2v/Vxvn dZ0RdJW6PafF8bDWXSrZh0xlthOLhuNPJJkbcMHJ2gJQw0tWI/WFubfg8Epjp9wkkl27 Dauw== X-Gm-Message-State: AC+VfDy3HkIGSBmZn7lWHaD7h60ZxWcTWxjQoXKKA0TMP/KLspGpo9Z/ sauCljnBJo+G7oMt8XtR88l2GvkppsToFru1gG36i317yNQwad5Fb/tAV0DXs0gPckzgDWTjKJ9 FhlggmrJ+qQsxCDfRhFuGgX7eRw== X-Received: by 2002:a05:6214:21a5:b0:635:ddc7:a0fe with SMTP id t5-20020a05621421a500b00635ddc7a0femr6296172qvc.9.1687874319915; Tue, 27 Jun 2023 06:58:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ65CiSaF95iHocRs9vs46l7byKY9AlI0+nqoadkNcgFoA6V+OBoqIRAttJbj2F61rpLPFkS1g== X-Received: by 2002:a05:6214:21a5:b0:635:ddc7:a0fe with SMTP id t5-20020a05621421a500b00635ddc7a0femr6296163qvc.9.1687874319670; Tue, 27 Jun 2023 06:58:39 -0700 (PDT) Received: from [192.168.1.7] (adsl-2-solo-172-78.claranet.co.uk. [80.168.172.78]) by smtp.gmail.com with ESMTPSA id o12-20020a05620a15cc00b0075cdad9648dsm4005097qkm.25.2023.06.27.06.58.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 06:58:39 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 14:58:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Commit: Fix gas testsuite failures for non-ELF AArch64 toolchains To: "Richard Earnshaw (lists)" , binutils@sourceware.org References: <87mt0myyc2.fsf@redhat.com> From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, > This seems a little draconian (a test doesn't work so we ignore it)? True. In most cases the problem is that an assembler command line option is being used that is specific to the ELF targetted assembler. (eg -mabi=ilp32) It would certainly be possible to create PE/COFF equivalents of the tests that use appropriate alternative command line options. > I'd be much more inclined to rename the problematic .d files as -elf.d and then add variants for coff, with both using the same source .s file.  Only where the test is > specifically designed to test the ELF format (or an feature of it) should we be skipping the test entirely. Sure - any patches to do this would be most welcome. Cheers Nick