From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id B5306385E00A for ; Tue, 30 Aug 2022 07:15:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5306385E00A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.152] (unknown [10.20.4.152]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxnmsquQ1jPUUMAA--.40699S3; Tue, 30 Aug 2022 15:15:54 +0800 (CST) Subject: Re: [PATCH] opcodes/loongarch: correct parse_loongarch_dis_option To: Iru Cai , binutils@sourceware.org References: <852eda61-962e-5ef0-eb1c-304d23ad7f33@gmail.com> From: liuzhensong Message-ID: Date: Tue, 30 Aug 2022 15:15:54 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <852eda61-962e-5ef0-eb1c-304d23ad7f33@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8BxnmsquQ1jPUUMAA--.40699S3 X-Coremail-Antispam: 1UD129KBjvdXoWrKF43Kr1UZFW7Xw4UAFWUArb_yoW3uFX_W3 yfX3s5XrWxJa9rJ340yryrZ3yfWFyFgFn8AF1vyw4xGry5JFn8GFs8Ja93Ar1xKF4rJr1Y krW5ZF4fAF4YyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbx8YjsxI4VWxJwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY 02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17 MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jeXd bUUUUU= X-CM-SenderInfo: holx6xphqv003j6o00pqjv00gofq/ X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2022/8/24 上午10:29, Iru Cai 写道: > parse_loongarch_dis_option should return 0 when parsing a valid > option. > --- >  opcodes/loongarch-dis.c | 5 ++++- >  1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/opcodes/loongarch-dis.c b/opcodes/loongarch-dis.c > index 9dcf989d0df..51c1f64edb5 100644 > --- a/opcodes/loongarch-dis.c > +++ b/opcodes/loongarch-dis.c > @@ -92,7 +92,10 @@ parse_loongarch_dis_option (const char *option) >        loongarch_r_disname = loongarch_r_normal_name; >        loongarch_f_disname = loongarch_f_normal_name; >      } > -  return -1; > +  else > +    return -1; > + > +  return 0; >  } > >  static int The format of this patch seems not a unified diff output, can not be patched directly. Do you mind remake?