From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 99AEF3858D1E for ; Wed, 21 Dec 2022 21:24:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99AEF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x12b.google.com with SMTP id y2so66479ily.5 for ; Wed, 21 Dec 2022 13:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ykurwn59b7t6FjyKXVbF7ry2FerN0ZDFUFmYNBFi63E=; b=S2xl+jEyMlqffDX9g0PYps5nvz6xf63amDe2CekaVunz8jDPZ4UGhI9VBR+gQZZPpl 5XVe+5E5vkx03dw44GwnFMxoDnrAWOvKZgX4hcsBOPD2JRJtegztQxCjZAeaft1RAKnq qQO0GVGSA3EhJcw8W0rVRGKPIw4QoDbWa8XSBAtSRMP0WJj+27U5UXd1pvvYAB5FpAYU kYHU2Ir0jNAXfY1BGJABE2jLqOHuR1RXy9bGjIyiHQTWPj4drAPb8kyL8ZMxNllIgVKr RMDVORHgfzRm9UDQ46mjAdTKol+SrkxqvfphGNuvPBCcs3acDxPAH/HiC4+eaUxqXZPU sYuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ykurwn59b7t6FjyKXVbF7ry2FerN0ZDFUFmYNBFi63E=; b=tV+ZwCZmEwVx1lTBEOEscd0jrUtoGrxOdoju+mNg6mjyQ4OlmmZFJ31JD0fradi7CT 5HWSo7nFAfwGJo6buRyiZr4ggTp8lSh94DKecF9IFkIKSljrJSunbFY9jLN4ApOk+tuB ++QUYvbL1F3qbTlR7uUfAc2jShVniF/iY8C87Hm1BDcl0nN+WoMyWYvUhnIfRDz1u8P3 f7b42BL1Hxh39HmAHqXifOvzZreUTrkj0ejaiV/5qtXsdJW6gTq19Q4gTWYugyzGuAkb RDVL4NLsfzssn27j2kK9IV0cCtTVbiA3x7B9UIIQ8jLHeQYJnXh2PVdDgwZEkgGBoO5w H2Qg== X-Gm-Message-State: AFqh2koobGEI4VSLtVbFQs+Kt0rtZrd7o7mWeTjQEAPLO71GwK7kUt3/ ZXy8/ikyV74drdsjqfSS1Pg= X-Google-Smtp-Source: AMrXdXsC4dQtNIxx1zA1EapJf72C2A2WeJmm+D2dLB4DKNDC8ZEnDmygzuD2TtOoTATa3QtzV5Vd6g== X-Received: by 2002:a05:6e02:5cc:b0:30b:adf7:b9bb with SMTP id l12-20020a056e0205cc00b0030badf7b9bbmr2496343ils.2.1671657857662; Wed, 21 Dec 2022 13:24:17 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id q9-20020a02b049000000b00346a98b0a76sm5718293jah.77.2022.12.21.13.24.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 13:24:16 -0800 (PST) Message-ID: Date: Wed, 21 Dec 2022 14:24:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 3/6] RISC-V: Add Zvkh[a,b] ISA extension support Content-Language: en-US To: Christoph Muellner , binutils@sourceware.org, Nelson Chu , Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich , Aaron Durbin , Andrew de los Reyes , Eric Gouriou , Barna Ibrahim References: <20221221170706.2877188-1-christoph.muellner@vrull.eu> <20221221170706.2877188-4-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20221221170706.2877188-4-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/21/22 10:07, Christoph Muellner wrote: > From: Christoph Müllner > > This commit adds the Zvkh[a,b] ISA extension instructions, which are part > of the vector crypto extensions. > > Signed-off-by: Christoph Müllner > --- > bfd/elfxx-riscv.c | 13 +++++++++++++ > gas/testsuite/gas/riscv/zvkha.d | 12 ++++++++++++ > gas/testsuite/gas/riscv/zvkha_zvkhb.s | 3 +++ > gas/testsuite/gas/riscv/zvkhb.d | 12 ++++++++++++ > include/opcode/riscv-opc.h | 11 +++++++++++ > include/opcode/riscv.h | 3 +++ > opcodes/riscv-opc.c | 5 +++++ > 7 files changed, 59 insertions(+) > create mode 100644 gas/testsuite/gas/riscv/zvkha.d > create mode 100644 gas/testsuite/gas/riscv/zvkha_zvkhb.s > create mode 100644 gas/testsuite/gas/riscv/zvkhb.d Looks reasonable to me. Just one comment nit below... > diff --git a/opcodes/riscv-opc.c b/opcodes/riscv-opc.c > index bb716c8c9d0..35d3e653147 100644 > --- a/opcodes/riscv-opc.c > +++ b/opcodes/riscv-opc.c > @@ -1834,6 +1834,11 @@ const struct riscv_opcode riscv_opcodes[] = > /* Zvkg instructions. */ > {"vghmac.vv", 0, INSN_CLASS_ZVKG, "Vd,Vt,Vs", MATCH_VGHMACVV, MASK_VGHMACVV, match_opcode, 0}, > > +/* Xvkh[a,b] instructions. */ Are these X or Z? Jeff