From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2050.outbound.protection.outlook.com [40.107.249.50]) by sourceware.org (Postfix) with ESMTPS id 83BA53858D38 for ; Mon, 9 Jan 2023 08:15:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83BA53858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=idqtCzK/wW0IVlBoA8o4NNiysrhIZ/ssEubmhmO+x/oFszA/CuUKpDffScvH4RqCpjmWXhE7M75IyX6IP6C0hicAUCE5Zhgf4HIsVOSV5i3IszaogHKNpn4s2FMkxdwcoDePsYcjcNHSbUumNWcbSUZOOv4B4rS20OyVEmWcDzj2vOklQJbyXrNLl/CPgp/Q6CAEIPGlXxrCz8nnjaVKR8k4UbJFVdztN1fGajfaSuHJFDNGdc3fcdVqu664Fetmt6hK2C+eu/F8PWLJe1CLAntNx6nUG3/1Ng4YfaSTbv2V098W7HcT9AFT79x4MfBK5bo4BvsutSiENdr9d+vR9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UvA45FtHKPtPJNd0IykSuP33Vtmmd3lRutnGP/M5UGw=; b=OLVStKk4NdGdKaD/fpRf87kJv29tDOoOvvd0JSibSP8c0QI5dpIEtNDHGT+h8wjLBj3NukfM6SC5lcTNaPf/s1HoE2puI2KCotxZXTXeued0BOeilE5UuHo4V587jlyAx6Lmamdjghey3fKdnZKDam+H6XK5yumIkm+SPYUvbR52KQTdiQYrDF7/I1o7IuO847uO6uf4blVXu6xPsYL9AJP1Npq7oi0i8hwqQPkvMw8v+goFJCWS6M93aOnkyby0BUgrJX3XG0TTBKeNwvBWyCAPEpHnmcgQ15C+h5p6YnMWLiFZv0B3a/jXfM1VtpL5++GmKcfP5tx0RvVTRzhY3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvA45FtHKPtPJNd0IykSuP33Vtmmd3lRutnGP/M5UGw=; b=5gDK7BQozhb+UsrL+Ql7aU5EurkfqAYmC02oUzn70OuHEqB8GY2s5aOYbV97FqI+2uZ/vS6MTsh95HvHi0nfOtCXPrMu3ggaevOOe0QcST/1n/EvkapcxrjGGcFIQ7Og7RVdhl+2w8rqH3kzLPRq9RNZKA/2I00V/Kr/KeuSWtYsftYBft2t+ckP5pdzVDWfEp4C7+EjMBp7IeFrk1Nu3EXy8TkP2iojE6mKYie9HFxkO5ik/u/ivNmzyZ9iHjfxwk0y77FROuoKAIFg1phTGV2oTAOZo452Tg/ZW7vGPJjrSx2BcCG9iG/uWNqJb/AxKxEBCy7OdX4uiQ80Jmn3oQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9483.eurprd04.prod.outlook.com (2603:10a6:20b:4ec::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 08:15:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 08:15:50 +0000 Message-ID: Date: Mon, 9 Jan 2023 09:15:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] ld: Allow R_X86_64_GOTPCREL for call *__tls_get_addr@GOTPCREL(%rip) Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org, Fangrui Song References: <20230105210542.3573076-1-maskray@google.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0208.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9483:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b535889-a731-47c7-9972-08daf219b7ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wki3BH2anrI9hR4oAN+VdgQC4M6NatBVaNoqdDpwKMJvUopf14CCFJXLi73gGvjVun665YxzfNSjEJ7yqHhWPDWp7EWj/efL6czHIQziefqW0qGobC4XimAOO+gGr565hJ6NIczwxRC3JZJVOPyw2dJaHmaBp27xn2SRlEMwsZ/+8ppLlEWK1QOABDwDnE+fdJoHNUf9dg5lWdrg9SJcFkrDuIh/koMrTp7WACle4WSw9goGEva8m6Z1ChGgS12oHK+S03H7Irl/o5BsgcG4DTPfkVR0tzVO8ov6uJDefIMZPctXBfD29bhL/dlD8648z2Y7eGgQO2hJQYl4SxNzqPkPmtjRFs3Khr61QyPeN/5CIqfV1pjLbhZBCZBFmRME4NDRfj75KAOpoZQv/CG4tNhTYl4MeUFuEkpb6fK5FtsAVdNmHJ5SAc7gi61xKe3wvRJX5+oTVIkxqfVAZ/YkSTVHzMYv3QgmhT5DYszY6RB3rDTofBdCgxSS1LYjAdQDKWbb3M5pylCf2rYGAVitTvm/E1ZdHMxbxg1lPk5NZgIjJo6dR/GK2sTtHEGZHUiX1fqmE3plBZp60LD2rC99NMf4q5dU0MOSH6TbsQvzmvhRa+eOF6asq1kcH4g/fLit6khkBuYgGa/WJEJnm0KR/1sYSnw783qwMUrb6iXsts+f2stoE1Tp0W2+TWdTdUetR6GB87iCjy1iK2/AkJEdKhs7SIs1waN28xzlkme2XUg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(396003)(376002)(136003)(451199015)(31686004)(6486002)(478600001)(86362001)(31696002)(36756003)(6512007)(83380400001)(38100700002)(66946007)(66556008)(66476007)(2616005)(8936002)(6506007)(5660300002)(53546011)(26005)(186003)(2906002)(316002)(6916009)(41300700001)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGxyanhPZWNwSEdxUEZ5YnA1QUMyTFNibjhwaGV6SUo1RndpOGhIMnIzWlhy?= =?utf-8?B?Y3FqMTBRbVZvb0NhYXRGaDc1L2FwUXkyMmh5b0oxVk52VXRDM2dXYnhQOGdm?= =?utf-8?B?Yzl1ZjAxTnlMRUsrTWs3R3lscEhxSDIweTdFVE5nYmRkdW5kbXZjOEdyMFND?= =?utf-8?B?cGNBcldjRlZuQ2MvaW83d3JuTHpwVGp5anIrQjlHaENlVFhqR1pITFI5Mzlq?= =?utf-8?B?aURiaVU0RXlweFg1aEc0c1dmckFSUVFHQm5VVmxmcHBwd1E2T1hUTXlFYzc0?= =?utf-8?B?U05jNkx5VS9IM2k4S0gzWDZSYWZ3NWo0aDB5eENmbVdoMlY4OUJhSkc2Rktx?= =?utf-8?B?TzU5djdaWGUvUllaVjA3dk1wOVh3c2xNVFFpODc2VEZPY045d25rV0haOExr?= =?utf-8?B?MXRXWTZpUHd6SmJjTVBUaFAxK0JRdHZyVExYbU0vZFFEalFRNUxrcURDaFJ2?= =?utf-8?B?RE5nNlNoWkJlUDhZMFQzekl3MDBOT3hIMEFpa2JzNHVYaGFRcEovR2t4U1Nz?= =?utf-8?B?RVJodW9MOVg2MWZLWjlmajFmZ3RYTWNDZ1V3QVNkZkxXSnVMMTZtYUJ1K2Nh?= =?utf-8?B?UlFxQlVrbmRYbEVDdGRJeWt4WTV6T2NOL0FocHpsVzE5TVNhMEgra243TExN?= =?utf-8?B?MTNPNHVkQXRiQ2FneUNkbHZHd2krOWhaazAvV1kwYzEwRUFLbHdOdTlqTWkw?= =?utf-8?B?UFd6R0x6bFJvY2NaT2h4SmR0K0UveEZ4dTlxZC8zZ2NQTEZDdzJTZDRjanVM?= =?utf-8?B?Y0Viak5FQ08yMDhKalZxd3JGUzB5UVVadWx5RTBha21vekNBelo2ajRJYkVn?= =?utf-8?B?S0NZeHc2ZGtveUJ3aGlxQzFJZ1E2eDQ1TDFtRUJHL0FxOGVoQU95WWxONUpx?= =?utf-8?B?NCtrTHhPTFllNjltbVVZR0JZMHV3cDNMQ255L2lpdTdCbDlHTmhuRlBabEhZ?= =?utf-8?B?N0FMZXJYZUljQnJuTWNUZ1psVnVQTDZ2clhPK1ZDbkk3Ym5RcEptNE1OcUNI?= =?utf-8?B?emxXQjhpVjdwSEQ0Y1dKbjVXdWd2eDhWRzZSWjI3eFJ6aVQzR0N4clBwL0dj?= =?utf-8?B?bTQwcjYxQlp2SkExOXNQR1BSaDRkTUNwaGJyVnFWblZsRTFxRlQ0a3F0Zys1?= =?utf-8?B?K0hnVFd2MVRDSlNUcUdnZk1FdWF0RzZhTVQ2bEcwTkVBWU9WWjlkZjUyYitw?= =?utf-8?B?RkhtaEFKQjg1NTNEQnZPZkhRMDVVZDdQQWRFVVhmUFBpZ25UNzZkV2F5Yzhy?= =?utf-8?B?amh0ak5qTTQ3dFVXck9hRWdRZTNXTDJBeUlaaEF2YmZRWHVvRm5nM2tnSUxL?= =?utf-8?B?ZGxONzJHK2hoM2xvVEduUHNMK1R3TE1jUnRoRmc3bnl4dzdVMm5XanhmcW5X?= =?utf-8?B?TTY2ZnZKdTUrOEhwSmRVMnJGakZMclpjSnl3SkJpanNZbVdkdGpGUG9CZ0NR?= =?utf-8?B?bDZiNzJnME9IWHkwSkhJRnAvN1ZVbmoyWDhwOEN4bG9NNEUvUzR2WFEvOGRM?= =?utf-8?B?eFF4NUkwMHdlSHVHd2J6MkNCcnlUWmN2ZkRGdkNvNndQak5oeitwWlRKUHF5?= =?utf-8?B?Yno5alYxOEJ6WTd5YzNtaGd0S0wrM0hkUThTSkl0UGlWeFk2WkpTOXRmTXI0?= =?utf-8?B?bi81S2hOczRNMmQ0amxKaXNtWXdkWGYwMityVm4wT3N0SVpBMk5CYktUNllC?= =?utf-8?B?Um5XRzZPY2RaZDVRSHc0Q0l0a2I4d2xXUTUvdklDMmRUdkJGd2EwakVPNFBs?= =?utf-8?B?aGdhTlpMWE55TkJ0R1ZrWGlZTzBncnJLRjNTMDY4RjhzWDNiYzdMM3p1K3M1?= =?utf-8?B?aWlJaU1SY240ejJDT0tvT3U5VnZ0MGpsVEZZeVF4dGZ3d3YzUE1WSjVoOHhm?= =?utf-8?B?aG1TekphdFZGcWV0TWhRRXY0QmovLzJxWXJoVGVrU0MwQmw3MFdzcGVPMXd5?= =?utf-8?B?c21ZUllqRmdTZVJaZUs1VnFLWWZlZ2RYdTJtS29KT0JENE9Gd0JzcThUanRy?= =?utf-8?B?TWRFTXRkVDFZa3JnVmhhcnZrYTNBN1JKVVQ1Vi8rVm5ra3VYdTBtcVdTOVUr?= =?utf-8?B?MmJJUDc2dTNIcWZxSVB2NWxISUYvTk5TWXltMnhXcGtnUEpXeGt1ZUY1amZV?= =?utf-8?Q?rWJOfDJHK0fKw0VUjBM7tK2sA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b535889-a731-47c7-9972-08daf219b7ec X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 08:15:50.1280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yzr0aKeKzOmirlLfBvLVRmpmd/erZpXKnr5wjW4+ERGWisGj3LCYN/IZm/5H2VrSuuhfxe4ApjVy73XztvNV9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9483 X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.01.2023 18:03, H.J. Lu via Binutils wrote: > On Thu, Jan 5, 2023 at 1:06 PM Fangrui Song via Binutils > wrote: >> >> _Thread_local int a; >> int main() { return a; } >> >> % gcc -fno-plt -fpic a.c -fuse-ld=bfd -Wa,-mrelax-relocations=no >> /usr/bin/ld.bfd: /tmp/ccSSBgrg.o: TLS transition from R_X86_64_TLSGD to R_X86_64_GOTTPOFF against `a' at 0xd in section `.text' failed >> /usr/bin/ld.bfd: failed to set dynamic section sizes: bad value >> collect2: error: ld returned 1 exit status >> >> This commit fixes the issue. >> >> PR ld/24784 >> * bfd/elf64-x86-64.c (elf_x86_64_check_tls_transition): Allow >> R_X86_64_GOTPCREL. >> --- >> bfd/elf64-x86-64.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c >> index 914f82d0151..095fe2e0fe6 100644 >> --- a/bfd/elf64-x86-64.c >> +++ b/bfd/elf64-x86-64.c >> @@ -1241,7 +1241,7 @@ elf_x86_64_check_tls_transition (bfd *abfd, >> if (largepic) >> return r_type == R_X86_64_PLTOFF64; >> else if (indirect_call) >> - return r_type == R_X86_64_GOTPCRELX; >> + return (r_type == R_X86_64_GOTPCRELX || r_type == R_X86_64_GOTPCREL); >> else >> return (r_type == R_X86_64_PC32 || r_type == R_X86_64_PLT32); >> } >> -- >> 2.39.0.314.g84b9a713c41-goog >> > > Since the new TLS sequence was added after R_X86_64_GOTPCRELX was > required for call, R_X86_64_GOTPCREL should be invalid in this TLS sequence. While this may well be, would you mind pointing out (more to Fangrui than to me) what bad his proposed change would do? Jan