From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A3AB33857734 for ; Wed, 13 Dec 2023 11:57:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3AB33857734 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A3AB33857734 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702468674; cv=none; b=Ith8RBdrFwM6D3D9dhTmZvhS68N12B+w6inxeGsvYRL4mS2yWGpa2bg8L+tN4fhdwa7rwyAv0Hm/hpThwhxoQwpsVPwxVCPLAtSU5CfOwxo2PwkbwvyhRHGmQyTBHssa8rUqewAwueGfhKaUKFx/Kqqik8btxLLULLmrYlKbQzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702468674; c=relaxed/simple; bh=FJVokU4gDbBQ198Kitmc2biVeb1k3mZf6OtkkiCE3+4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p5KpCke25VpO3QMV4x4+GUC2sm0azxcYXZUM81eJgiQoYtUGuig1d7Jsddyq3G+vwxHTHY3fT4DJ9aGxwRQc7xJOvjtTqT7piWOPs/H7caH38J+GzLSZWMm1cvip7M8RD5SKi182MHfXIBQ7MECLZ9tCRX7ikv16qJNgZFfndE4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702468673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a7myal8VrLKGmRbxLcp2cHacnX7Go/WtQYc2ZYYuawk=; b=RXAMP3A9VFF4QpCDMxqOmfZu0IBxTf5xfXUhdZd996tMHhmEczg7S0D2vVkb25ZV/W31Od kyEYNETI3Nh05m+ehGPGVi51Yg4a5VG4Zh2D93cD8W3uyCNY6548xqf4dlO8au2zN4KKXC TZ0svnzIhCJQsXtAlleMl0Z08GZzZUw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-DpUmoVGWNLuVGO9d5VTAmQ-1; Wed, 13 Dec 2023 06:57:52 -0500 X-MC-Unique: DpUmoVGWNLuVGO9d5VTAmQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77dca859cdeso834386585a.0 for ; Wed, 13 Dec 2023 03:57:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702468670; x=1703073470; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a7myal8VrLKGmRbxLcp2cHacnX7Go/WtQYc2ZYYuawk=; b=uDzYFml6Isz0q7lWJrLTA6ucfVTCoYuSmgXCaUc0y1yAJwoQromLgyAPZGj0o8KFG9 4rWjqPyY2WIiIHrffbAH15cyEycKSb3n69pchjfzcKoTEQsB80HfOEdCAkn1YigGnD+H KG59lRPsH752G3/60kAV/q7kEN3R4M56HDryKVz94fqwjYtvPrB/s5S58Ug+aYua6mFv a4du+KIEvfZy75YFAqh9JxQqVogiy02rK4rY66JL5YYN91b+w78FAA9i9dMrt4ysAP8f O01rGSZzBAZXDqMcbtU78zbOA6qI1rUV7rMvTJ9GCHU1QWQpbZ1K3w4QS+XbTtCtt+Rf ZEZQ== X-Gm-Message-State: AOJu0YwbMdfDVLovsyofTga5wpfbCvOuLksLTRbyjIQ0R2NzAF2k4eVX nHP1PJAVukED3NRHpHvgEQZNsj2rvRgTY9qNvhyf2k5XFGigZ/pnD/Mg6F8jnkdfMjwzxCzYgTy vkI2a0TcmC4KTzAja7GUIyBh1Fg== X-Received: by 2002:a05:620a:cc9:b0:77e:fba3:4f18 with SMTP id b9-20020a05620a0cc900b0077efba34f18mr8863713qkj.110.1702468670487; Wed, 13 Dec 2023 03:57:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZ9qWQABAHqsM5zVJgBE+zFPi0dr5EI0j7RuiXlOwQX+0RTvHVBjdt8SYRAoEalww1F7UXMw== X-Received: by 2002:a05:620a:cc9:b0:77e:fba3:4f18 with SMTP id b9-20020a05620a0cc900b0077efba34f18mr8863707qkj.110.1702468670248; Wed, 13 Dec 2023 03:57:50 -0800 (PST) Received: from [192.168.1.11] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id b19-20020a05620a271300b0077d7eaefc08sm4422495qkp.87.2023.12.13.03.57.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 03:57:49 -0800 (PST) Message-ID: Date: Wed, 13 Dec 2023 11:57:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V3 09/13] gas: synthesize CFI for hand-written asm To: Indu Bhagat , binutils@sourceware.org References: <20231211060359.3561062-1-indu.bhagat@oracle.com> <20231211060359.3561062-10-indu.bhagat@oracle.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <20231211060359.3561062-10-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Indu, Minor hitch: CC config/tc-i386.o gas/config/tc-i386.c: In function 'i386_target_format': gas/config/tc-i386.c:16302:25: error: 'x86_elf_abi' undeclared (first use in this function) 16302 | if (flag_synth_cfi && x86_elf_abi != X86_64_ABI) | ^~~~~~~~~~~ make[3]: *** [Makefile:1470: config/tc-i386.o] Error 1 Which I am assuming comes from this frag: > @@ -15334,6 +16297,9 @@ i386_target_format (void) > else > as_fatal (_("unknown architecture")); > > + if (flag_synth_cfi && x86_elf_abi != X86_64_ABI) > + as_fatal (_("Synthesizing CFI is not supported for this ABI")); > + The trick is that I was testing with a toolchain configured as --target=x86_64-w64-mingw32 The same thing also happens with other x86 PE configurations, eg: i686-pc-mingw32, x86_64-pc-mingw64, x86_64-pc-cygwin The addition of a simple: #if defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF) [...] #endif around the offending fragment takes care of the problem, but I thought that I would alert you to the issue so that you can do your own checking and maybe choose a different solution if you think that there is a better way to handle the situation. Cheers Nick