From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 6C6713858D33 for ; Fri, 26 Jan 2024 12:29:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C6713858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6C6713858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706272159; cv=none; b=eZJwSAt6o3w9gBmDOeVrsOigPCdM7suUilH+V0ziCiaR1aJ3MOqRrH3uerWYdnNE8ZV/CAc5sHbRgdUIKLdqx3hjvMoe26LCNuLgZxQeANhYZw9C0WcFMVnfyQJj4iajODI73F/evdcxt379dKlbceXa2cE3ADK+KYnTHQo4Vrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706272159; c=relaxed/simple; bh=0bNSnpy8yuOpXpPbvzAMLS0J1B01iTVambNPILF8Jbc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=x7Bq0plprperAv9jGI6OLYUIk5T8NjbtJFGU7bF4fMIM+pSugOwB5xQlO/DAs6SP13GrIW+p7xLMM5pmrp1mCwC37nar6hKiV0+HEvZEBX6IvrZPIhBPaiFqTYwZ+qbzsXYqYjTLgEeGnW8kTYoFhaMI/R0ifRJdPARJyXoZ3eg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2cf328885b4so3287531fa.3 for ; Fri, 26 Jan 2024 04:29:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1706272155; x=1706876955; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=KyDG2FJchlzs7IRGKR0EFD8OgYPsOKf3P+fH0eHMaNA=; b=aB0THgnBoBPHGzjAGY5yDIVxmzxtki9oARYXX5ldxoCo7DWSPr6i5XVy1DiEMAJh53 EVYe8CXxHc6bMzqryVFMAHR7BDu5W0O4ry/tUYKh7bWYIly7sEJSDpNhYdiTtg92SZze btRL2QZU1r7hpBZU3z+7pDIJksSwHpRnUS/gcYyUqlKJ3hHJo3aS2WX70lMd3pcJKnJZ enMEDrlBFhC+yzZigYhpHJewh8YBx5N8NCak9RJSRnM9Tl0j6kcnZUAsc++HwAIU7DYU jbmrE0P8ONWUuv7njrwaAteMrIJ4aafz7fYmYtoYdX77I1ch2ioK9glIS15xL/vjPtUM wHEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706272155; x=1706876955; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KyDG2FJchlzs7IRGKR0EFD8OgYPsOKf3P+fH0eHMaNA=; b=d8+x/4AeOB7cF1YmtoP7ethWHbpFTw7KK1gHxOt4sPSIt2P8ParDe6gofdaK9bWlbm /BXRtcZIHGE/CHh+dDW/77AKOJbtUaKl+01dRX9XM6kahMO2MijwCsqerz/HPc6mg8Xt fM4jb1d3X69MmzR6rUzkPBfb4g2u3y440zbjhcEtATfx5oSFg866+QCeHaphTeOXWnJA QwXORUGRtMcNTUy1XYkteUgdYdLOEuwCbdZXWLIqSW3oogClyd3yeQNJiQAvIFS8mHoT Ek/1QV8f4lFUosqv/FINZ9EkV2GdDDcxLz/8kzkFUaA2k3lEDQasIKvny8b/+LNokDHN 5szA== X-Gm-Message-State: AOJu0YwMfAaoECkbrdAEl3FOrL/Hox65el4J3ZrG+ZtaX0h9hFa9bWcK Cmj9JQmSQGGbYweHa5MyR6+4WPfDTnmmXZIio9Pf5h4PYwO83wAfckuyrR+8Us7+CIevwpT88rU = X-Google-Smtp-Source: AGHT+IEhca7/NbRtFp01V21ke4QGvxEGAQcsEMqWz6pOAzL55Xe0B7fpqp7pWfvGy4VJaREgISgzSA== X-Received: by 2002:a05:651c:a0c:b0:2cd:3300:bdeb with SMTP id k12-20020a05651c0a0c00b002cd3300bdebmr890533ljq.75.1706272154831; Fri, 26 Jan 2024 04:29:14 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id f10-20020a02a80a000000b0046ee23848cfsm255306jaj.158.2024.01.26.04.29.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 04:29:14 -0800 (PST) Message-ID: Date: Fri, 26 Jan 2024 13:29:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils Cc: "H.J. Lu" From: Jan Beulich Subject: [PATCH] x86: move Q-suffix-to-REX.W translation logic Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: By pulling it ahead of the SHORT_MNEM_SUFFIX case label we can drop a part of another conditional there. While moving, also drop a pointless check: With QWORD_MNEM_SUFFIX, register operands of XCHG necessarily have both been 64-bit ones. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -9459,13 +9459,31 @@ process_suffix (void) else i.tm.base_opcode |= 1; } + + /* Set mode64 for an operand. */ + if (i.suffix == QWORD_MNEM_SUFFIX) + { + if (flag_code == CODE_64BIT + && !i.tm.opcode_modifier.norex64 + && !i.tm.opcode_modifier.vexw + /* Special case for xchg %rax,%rax. It is NOP and doesn't + need rex64. */ + && ! (i.operands == 2 + && i.tm.base_opcode == 0x90 + && i.tm.opcode_space == SPACE_BASE + && i.types[0].bitfield.instance == Accum + && i.types[1].bitfield.instance == Accum)) + i.rex |= REX_W; + + break; + } + /* fall through */ case SHORT_MNEM_SUFFIX: /* Now select between word & dword operations via the operand size prefix, except for instructions that will ignore this prefix anyway. */ - if (i.suffix != QWORD_MNEM_SUFFIX - && i.tm.opcode_modifier.mnemonicsize != IGNORESIZE + if (i.tm.opcode_modifier.mnemonicsize != IGNORESIZE && !i.tm.opcode_modifier.floatmf && (!is_any_vex_encoding (&i.tm) || i.tm.opcode_space == SPACE_EVEXMAP4) @@ -9489,21 +9507,6 @@ process_suffix (void) return 0; } - /* Set mode64 for an operand. */ - if (i.suffix == QWORD_MNEM_SUFFIX - && flag_code == CODE_64BIT - && !i.tm.opcode_modifier.norex64 - && !i.tm.opcode_modifier.vexw - /* Special case for xchg %rax,%rax. It is NOP and doesn't - need rex64. */ - && ! (i.operands == 2 - && i.tm.base_opcode == 0x90 - && i.tm.opcode_space == SPACE_BASE - && i.types[0].bitfield.instance == Accum - && i.types[0].bitfield.qword - && i.types[1].bitfield.instance == Accum)) - i.rex |= REX_W; - break; case 0: