From: Nick Clifton <nickc@redhat.com>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] MIPS: Fix Irix gas testcases about pdr section
Date: Wed, 15 Nov 2023 11:00:16 +0000 [thread overview]
Message-ID: <bf9a4b01-068e-406e-95a8-a0bdfd4f68c6@redhat.com> (raw)
In-Reply-To: <20231114100305.1501344-1-yunqiang.su@cipunited.com>
Hi YunQiang Su,
> 1. Add -mpdr option to cases, which expect .pdr section existing.
> Gas doesn't generate .pdr section for Irix objects by default.
> See `int mips_flag_pdr` in tc-mips.c.
> Add -mpdr into #as section:
> mips/mips16-e.d, mips/mips16-f.d
> mips/elf-rel26.d, mips16-hilo-match;
> Add -mpdr if target is mips*-*-irix*:
> elf/elf.exp.
>
> 2. Add irix-no-pdr.d testcase to make sure no .pdr section is
> generated for Irix by default.
Patch approved and applied, with one exception:
> +++ b/gas/testsuite/gas/mips/mips.exp
> @@ -1545,7 +1545,6 @@ if { [istarget mips*-*-vxworks*] } {
> [mips_arch_list_matching mips1 !singlefloat]
>
> run_dump_test "mips16-vis-1"
> - run_dump_test "call-nonpic-1"
> run_dump_test "mips32-sync"
> run_dump_test_arches "mips32r2-sync" [lsort -dictionary -unique [concat \
> [mips_arch_list_matching mips32r2] \
I assumed that this was a typo and that you did not really intend
to remove the call-nonpic-1 test, so I ignored this part of the patch.
Cheers
Nick
next prev parent reply other threads:[~2023-11-15 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 10:03 YunQiang Su
2023-11-15 11:00 ` Nick Clifton [this message]
2023-11-15 11:02 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf9a4b01-068e-406e-95a8-a0bdfd4f68c6@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).