From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84515 invoked by alias); 9 Jan 2018 21:09:13 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 84366 invoked by uid 89); 9 Jan 2018 21:09:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.128.194, H*RU:209.85.128.194 X-HELO: mail-wr0-f194.google.com Received: from mail-wr0-f194.google.com (HELO mail-wr0-f194.google.com) (209.85.128.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Jan 2018 21:09:11 +0000 Received: by mail-wr0-f194.google.com with SMTP id w107so15495282wrb.9 for ; Tue, 09 Jan 2018 13:09:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=X5GhOcW1v4RhQjmaHkv9jC9BQDrYJDxZoiWCg5JBQmc=; b=oSbvL7dJtJohABTADZ/kI/1677kgBWlhsGwQxtzcpGnp2ysFV1rUmCUCwG5lgakHyT GGZgvMhTGSRBzdNZbMOC5PoKgJ/j0tSMpncddQvOSlLxCkoONtifxIFOxc9DUE2IEmam rQgAla4xgfzjKNl49kNpOFQfrkcpQNJveObxP+977bPfD498LGnV4JEL3PH2qVfxTnLW LIF2pg5nCpE4eovuFWmHpKme4p5g10AK3kZ3rDr4tdTo5ktyq2+ISBa1ldtPpmG9COQr wpSNTbCEWzcXODO2iJQZXN1dJlULNF5mApIuBqkzHROSezbtNBIqAXIri5exDhTU45LS v5Xg== X-Gm-Message-State: AKGB3mK8hEudkz7UVANewPfTTi3Cc4sh3oOKzLQx3LTiGWCSjAdIaKk4 afobhkwstpGXQ8yHCezeKhcaREh0 X-Google-Smtp-Source: ACJfBovw/Xil2iZk6Y9rXDsCqY/aPskHyEzXpjkxO0moASCW/3NP3DV3aexiNk+8QSoNbLPiBjzH7w== X-Received: by 10.223.162.141 with SMTP id s13mr13911229wra.132.1515532148832; Tue, 09 Jan 2018 13:09:08 -0800 (PST) Received: from localhost ([81.141.199.69]) by smtp.gmail.com with ESMTPSA id 94sm4807268wri.48.2018.01.09.13.09.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jan 2018 13:09:08 -0800 (PST) From: Andrew Burgess To: binutils@sourceware.org Cc: Andrew Burgess Subject: [PATCH 4/4] ld: Remove unused expression state Date: Tue, 09 Jan 2018 21:09:00 -0000 Message-Id: In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00130.txt.bz2 Previous commit removed all uses of the defsym field within the linker expression union. This commit cleans up the now redundant state. ld/ChangeLog: * ldexp.h (union etree_union): Remove defsym field. * ldexp.c (exp_assop): Remove defsym parameter, and use of defsym parameter. (exp_assign): Remove passing of defsym parameter. (exp_defsym): Likewise. (exp_provide): Likewise. --- ld/ChangeLog | 9 +++++++++ ld/ldexp.c | 8 +++----- ld/ldexp.h | 1 - 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/ld/ldexp.c b/ld/ldexp.c index 9508bad4a56..832f1dfb9f6 100644 --- a/ld/ldexp.c +++ b/ld/ldexp.c @@ -1339,7 +1339,6 @@ static etree_type * exp_assop (const char *dst, etree_type *src, enum node_tree_enum class, - bfd_boolean defsym, bfd_boolean hidden) { etree_type *n; @@ -1351,7 +1350,6 @@ exp_assop (const char *dst, n->assign.type.node_class = class; n->assign.src = src; n->assign.dst = dst; - n->assign.defsym = defsym; n->assign.hidden = hidden; return n; } @@ -1361,7 +1359,7 @@ exp_assop (const char *dst, etree_type * exp_assign (const char *dst, etree_type *src, bfd_boolean hidden) { - return exp_assop (dst, src, etree_assign, FALSE, hidden); + return exp_assop (dst, src, etree_assign, hidden); } /* Handle --defsym command-line option. */ @@ -1369,7 +1367,7 @@ exp_assign (const char *dst, etree_type *src, bfd_boolean hidden) etree_type * exp_defsym (const char *dst, etree_type *src) { - return exp_assop (dst, src, etree_assign, TRUE, FALSE); + return exp_assop (dst, src, etree_assign, FALSE); } /* Handle PROVIDE. */ @@ -1377,7 +1375,7 @@ exp_defsym (const char *dst, etree_type *src) etree_type * exp_provide (const char *dst, etree_type *src, bfd_boolean hidden) { - return exp_assop (dst, src, etree_provide, FALSE, hidden); + return exp_assop (dst, src, etree_provide, hidden); } /* Handle ASSERT. */ diff --git a/ld/ldexp.h b/ld/ldexp.h index 572b703c203..d58cacba1c5 100644 --- a/ld/ldexp.h +++ b/ld/ldexp.h @@ -66,7 +66,6 @@ typedef union etree_union { node_type type; const char *dst; union etree_union *src; - bfd_boolean defsym; bfd_boolean hidden; } assign; struct { -- 2.14.3