From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by sourceware.org (Postfix) with ESMTPS id 349B03858D39 for ; Thu, 29 Sep 2022 16:06:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 349B03858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hTGb3MDUElREiBoJnZmUlfbnTEQMuFQiRLQPLYTIC3b61/4wyXOrFj0kGhaC9FBCdTt+lYSTY1L0UiATmjm9IJbY3fVxY1FR0zjo8i9f5iN+ti4hsOfwlJIMwpqO0T+D5rs72bhl0kDfNuIY6z3leIDVDhow2TlDwmtAXPBSFX/qUQWsAn8D2FGY0HnawIwgN5BuvjaaNKiNMCngeo53YUC2tQ8tBgZJ05N4UXN/kMyJd4d3dRLViu0VqrAtD1pM4YVGekJZRPyjrdRtiAgkiwFOcg7+mRTiThAvL9V4j5kH+4N86S3EBQ69TYzLytNlnO+lI/AD42J9pJ+Fu1gmnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4a26hkH/EGElMEjy+ODDyRtvFNjSKX/qijKRv58KsQg=; b=aI/jt9Qn1AIuCDYGp64V7WXKKzEy6qZnftbVEmdyWKZ80p9pQ5YyDJsKHl4Dp/pLdCAAu6oBgmxCRbRrGQuYtCuUEIjJ1xBvytK8AerkdMJLqqZBRuoWVU7/HHhN0hoo8V2sPAQNzu2LC7iVmBpHlpjbMVttLdjvVjWXNpvxgRv++f/P91mNky2tYVl8X6XvtHwtMaD4MptA63hR639GuwLSQb4rQ9mdUvV8YoICT+rTcCTV+1FJTKCi0PR856/1/EVTCf02AR+5TDSTzl3r6wCkAsYBTmRr7unuCDPLLgOOXkrXjnzrtHpeSj2ZPaHZm1kJx43pqe4kDOZs0l879w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4a26hkH/EGElMEjy+ODDyRtvFNjSKX/qijKRv58KsQg=; b=II7D2q5ZuESZ/TmAwN6G/oIhqcA+bTHQmDK/qY0Fxo96El0EDzoGG/j3hpnRV6ma8jrxFqSt/XanPz396VkvGeNWvYVd0uqx/ceFsx03hteqpl9EK9QwGRQP/uw3G88fOlx1kpF13XPfuq/CPuRXaa0Nt4e60mMnN6nAwFtiePTPXVHvmANGCrtTK6r3CPJigljZYg9mUwjywQkmV4KwBHpcQ0NuGhWlRkCKiy8htehFEf/OVe/jGTpCWS37Q/gLkHKG2jMkypBrg70srnwpwqzPbcytI95c7InBBB1geA60ixLfu/QMaH09FPW24NbI2N+IRv1YluFpL3Rr/k4fAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9518.eurprd04.prod.outlook.com (2603:10a6:102:22d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 16:06:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 16:06:49 +0000 Message-ID: Date: Thu, 29 Sep 2022 18:06:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 5/7] x86: re-work insn/suffix recognition Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> <995353db-27f3-ea60-8e69-32bcc44dfd49@suse.com> <162c053b-7c68-67b8-1443-926f2ebb321d@suse.com> <892afda8-0e6a-cc7c-df95-f5581e831fff@suse.com> <93622263-1a05-07e7-4a96-c33cffb0796b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0635.eurprd06.prod.outlook.com (2603:10a6:20b:46f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9518:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f1360d0-75c7-42fe-2b2f-08daa2349da6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +KRmeGqNSuUgAZbcpKHPZ8db3wU0lnBIZzPNMWrwsacGZtLHtuQSwGGKqJPQ2FDC+W/GjkMmbEVXZ9lnPFPSGgcSDlcq+ZVSkbqS200O+VRqHF5QCB+ierDSmzkbJqTEf2YX41NZVlfmlU0P2S76vNia2c3oMj7Nbv31L30JBnNRuUBPTzMjZ7ak2Qqlcu1BF/CqpUMBxCZ2kAU4cp5YQCleDyeETibfC/mLrPmbfa9v1cvjLjWP9AgfWCIr1osKWHbO1t1TAUgvtWgavkqa47PhZOxcQjvWd3hUk44AJG5zThp8M/oYDZkSUlHYto7y1vrwIsyyJ8At7O7/o8pyBu7uayr9ADrGHFPm4QAEJP/IGOraIOlw/mZbxjJdoNgyA3yjM752nq8azGrhLDjYhBMuKiyrFCcUH38s4Aqa0VZqlOmGAcOpA+PLKEKQpdvD2z4YDhjOxlBleQgiULTOJUX4eyWIKSJd/T+wB8uGj7EBCGEihREUGpAoa4ZanER4keiL0GO39WXqrKym4vZLb2pI47N4Zm41eMsIX446fxs/xRx/UU7fK9ZwE8FCKa8W34b8Hokh6xvjTm24AoMQe9t+WoEdfpiTtf/1pD4YTUKnGjj1RVDtQQUzPDl9Y1wCR/J9FtxDYioDDgw9PEgT1mF8G0vjwbpqZHlOeY1o4HRqqk4JmejiLvZD8kPeT0E38raEZxHUsMdsWRThxRzQ1Eq+8DJbHxlheD1yvJS//ODoqwsqH82zpXx4ORVQMsqblxzNIn6PKwdeV6CfzJOvWf3BzQlU2QV6o9AuuBp3XW4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(39860400002)(376002)(136003)(451199015)(31696002)(86362001)(6486002)(6916009)(2906002)(186003)(316002)(36756003)(6512007)(2616005)(26005)(38100700002)(41300700001)(478600001)(6506007)(5660300002)(66946007)(8676002)(66556008)(66476007)(8936002)(4326008)(83380400001)(53546011)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWRLWjRmcHR2UWNtNnV2R3BtOVp5THpHT2pMZmcxU2x5MXlubVhPaVAwL2c4?= =?utf-8?B?eCtGeGJFRE5GbGhQbEFDdll5VC9uN1Q5L3FEZkgram5ZUUZGMmQ0WkNDdTBD?= =?utf-8?B?TnJCWXJVOHVxSisrMFpHR1BVL2VxT0lXOGRQRmNqUExWLzg2cVdBeFk1YytV?= =?utf-8?B?Z3NPN0haTjVoL3pFbHdDSFAyZmdtUDFHWHVUNVVJek5peDFRQTVyc09tZlZ3?= =?utf-8?B?U05yZ083bkJpbEYvc1gwbnZGYkpLR2NQeDhKNkM5R1RrUGN4R1VLaTd2N0Nr?= =?utf-8?B?OGtrNWFrcmRzeGkxZjdkdUtxU05qMU9RVnpjSXAveEV5RWJMUDV3Y1ArMWd4?= =?utf-8?B?NDVoVjdLbXNOUGNoeXk1Z0VuR3U3d2l0T3JuUVpJLzJwMlBMQVV0Q2VHQmhr?= =?utf-8?B?L01CYzVpKzVESndrblBndGlmQmY1aWdvdklNWDhpMEhFYVd0U1czZk5BQkJt?= =?utf-8?B?emR0aDZZVFBkVXUxNVRseS8vOExMUlEyWEk4K2IwM1JibVVIK25TWWhsQ2JB?= =?utf-8?B?K0w4R1JURTdVZWJDeUZaUUxQR2xVdU1vSWlQRU5vVU5DWDJEVEIrV2xseDFJ?= =?utf-8?B?WnV3NDBUVEFuU1Nyd2JZdldjeVNoUW1CSktPaUdLOEh0K1RlckMraFRxOXl5?= =?utf-8?B?bENLWmxvWDgwaTVQcGJJcnVoNXlxYlBzYUJkN0d2dWhGeEExNUhEZXdEeWxV?= =?utf-8?B?VVp3OWhUM2VEcmorK1RNeEFRMGhkeHk3STBRaDhTMWovZlNWYVBuaWkvalMx?= =?utf-8?B?SjMzMEhtWnhkQzdXRHgxWEVLQUg1U2YyK1VFV3FlbGRjVjNyamF0T3NaUWhs?= =?utf-8?B?Q0FLT1RmaUlxc0lYY3V0VzgvZjIwajBMaWxWZWVXTU5hU2RraVpkc2RMeFhK?= =?utf-8?B?MjBlcDJGdTUvUFNaRldCNm5mOEVEc0xJcExyNmo4VlF3WGlkTjkrcGIvUnJt?= =?utf-8?B?bXBEU3dCMlhRR0pYbFZTTC9LNG1CdlZvVE9xelZwa2tqNUNrMjQrYlhEUHZ3?= =?utf-8?B?WS9HcU5SOW1DQys3cGxyUG9CbmZIVlBhRG4vQmV4elI5c3dUR1doMHNVY3Bz?= =?utf-8?B?TjhWYWpXOHJzWU5DcnN2R01oRnhBTzl6WW8zc0lvYmxiemZtbCtSOS93Zkli?= =?utf-8?B?UUk0bGpRb1lkZGErZGg4Z2xBVzFEYVNLTWhkOTd4bTRBZ3I3UlA1ZC9GUjZH?= =?utf-8?B?NDZqcGhTSXZkUlVjbHZicG0vay9obEliRjI4aE9xNnQ0c2RJNmd5bUFVbEx1?= =?utf-8?B?Vlh2UVQ3SWI4Y0N3STJBb1pNMk13TWtEUks1SjdMT21JUXQ0ZEtkTDNvZDZ5?= =?utf-8?B?b0hEOWU2ZURYb1g5d3JFSGFBQ3h0KzQxSzA0dWhpUk1zdTdzMEtXbVQxeG5M?= =?utf-8?B?VlgvVGZoeEcrajZybFYyU0hIWmc5Mm1uK0w1WnRISDVtS2lzL1FUd3pSRlJm?= =?utf-8?B?ei9xZVdETVdTVVFtR3oyMjRNYUkwYjNYWWVjT2NFQTROdTh4RFh2Zm1nbTNk?= =?utf-8?B?UjZ6NENxVkpETk5aSExzZTc2ZFZqZUt1cDZZSkxjRTJ4UmtRNUY0cVNxM1FE?= =?utf-8?B?WTZTa2FrNCtvVGlxNDFqUDI4L1h0UCtIZFk4TkhOaUYvMWpVUUlURkdyeVJw?= =?utf-8?B?SFFWdFN1T1preW5BTk13Y1k1UW01d01HUWNTWDQ2S2JtSFFaTXBRQmhNT0V3?= =?utf-8?B?b3dXUjB1RnlaYlVCL2RRMGNCZmxrUEFYME1WZjNDckgrWGhLVGhZS3dYTkpC?= =?utf-8?B?ckxQQjhQdGU3ck5ueldoWEJqNmttOStWNllYaXpRQzdJUCt2K0dGRkJHdThY?= =?utf-8?B?WnJpN0I1QlM3ZGJZN081c3kreUs0ZEUxOCsyOExrVFBZR05OcEladVM1dU9U?= =?utf-8?B?UHY5NlJYdXlQdGtCQzhUZnk1RnQrNEM1VnN2R3FqMlB2ckZqckQ4RGJuSDBz?= =?utf-8?B?NWJ6Z29uQlBtOUVaNHUxdlBBak16MVJnaS8yVUU0ZzFlOENNK1E0WCtOSlhB?= =?utf-8?B?WFhmRXJHUDIxNjcxVzV0bFFqSTlmaU9idnV2bFlOWWo1RzRpOG9DQmt5T2VX?= =?utf-8?B?QWxUdld5N200YXlSTWdCY2tZQ2tvMWdEaVRLeUdXYkw4WVVPMzJic2hTTTNB?= =?utf-8?Q?NhJjCWXESBfFG6//cz1UyguTl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f1360d0-75c7-42fe-2b2f-08daa2349da6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 16:06:49.4664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4e0dDm/jnRb9/PHAlAvXcR5WILXyWl8elqaJiA0EaAiRvgQGtVCwP24Y/xAVQr+TzNHzF/cUv6uBU814RR8Rxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9518 X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.09.2022 18:00, H.J. Lu wrote: > On Thu, Sep 29, 2022 at 1:08 AM Jan Beulich wrote: >> >> On 28.09.2022 21:33, H.J. Lu wrote: >>> On Wed, Sep 28, 2022 at 5:49 AM Jan Beulich wrote: >>>> I guess to prove (and going forward guarantee) the apparent behavior of >>>> parse_insn() I'd like to constify its first parameter. This might >>>> involve adding a cast (to drop const-ness again after the call), which >>>> I generally would like to avoid, or some "interesting" pointer >>>> arithmetic. If you have any opinion here up front, please let me know. >>> >>> Can we avoid it by adding some new entries to the opcode table? >>> I don't think we need many such entries. >> >> I'm afraid I don't see the connection between the intended constification >> and what entries there are (or not) in the opcode table. I view it as a >> desirable property of the function in the first place to express its >> behavior (of not altering the input string) by a pointer-to-const >> parameter. In fact I guess I would make such an adjustment a standalone >> (prereq for the larger change) patch. >> > > Rescan means that the first scan fails. Can we add new entries which only > do the second scan? Why would we add such redundant entries? All that could happen is them going out of sync with their counterparts processable on the 1st pass. The overall goal has been to reduce redundancy and hence the risk of inconsistencies. Jan