public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>, binutils@sourceware.org
Subject: Re: [PATCH] ld: pru: Place exception-handling sections correctly
Date: Thu, 4 May 2023 12:43:59 +0100	[thread overview]
Message-ID: <c0466d85-1806-942b-9223-a7ec5ed2fa72@redhat.com> (raw)
In-Reply-To: <20230503171124.6710-1-dimitar@dinux.eu>

Hi Dimitar,

> A recent GCC commit [1] exposed a latent bug in the PRU default linker
> script. The exception-handling sections were not described in the linker
> script. When GCC started outputting read-only EH sections, their
> contents would erroneously be placed in the instruction memory (IMEM),
> which in turn is not readable at runtime. Thus any access to the
> read-only exception-handling data results in a runtime crash.
> 
> Fix by declaring the EH output sections. Do not split in read-only and
> read-write sections because PRU has no true support for rodata. It has
> only one memory for data (DMEM).

Patch approved and applied.

Note - I extended the ChangeLog entry to also mention the updated to the
.data and .resource_table sections.

Cheers
   Nick


      reply	other threads:[~2023-05-04 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 17:11 Dimitar Dimitrov
2023-05-04 11:43 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0466d85-1806-942b-9223-a7ec5ed2fa72@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=dimitar@dinux.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).