From: Nick Clifton <nickc@redhat.com>
To: Georg-Johann Lay <avr@gjlay.de>, binutils@sourceware.org
Subject: Re: [patch, avr] PR31124: Support rodata in flash for more AVR devices
Date: Mon, 11 Dec 2023 15:41:21 +0000 [thread overview]
Message-ID: <c0536c69-1ba7-43f4-8ab5-51329be43e94@redhat.com> (raw)
In-Reply-To: <959585a4-d3b7-499a-ad6a-3a3ae7f805cc@gjlay.de>
Hi Johann,
> This patch adds two new emulations in order to support rodata in
> flash for more devices.
Patch approved - please apply. (Or let me know and I will apply it for you).
> What I am unsure about
Err - didn't you write this patch ?
> is the ABSOLUTE in avrxmega2_flmap.x:
>
> .rodata __rodata_start : AT (__rodata_load_start)
> {
> ...
> __rodata_end = ABSOLUTE(.) ;
> } > rodata
>
> No other places in the ld scripts use ABSOLUTE, e.g. for __data_end in:
>
> .data :
> {
> ...
> PROVIDE (__data_end = .) ;
> } > data AT> text
The difference is, presumably, that the symbols are going to be used
in different ways. The __data_end symbol, for example is more like a
size-of-the-data-section symbol whereas the __rodata_end symbol is more
of a no-more-read-only-data-after-this-address kind of symbol.
Cheers
Nick
next prev parent reply other threads:[~2023-12-11 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 17:37 Georg-Johann Lay
2023-12-11 15:41 ` Nick Clifton [this message]
2023-12-11 18:33 ` Georg-Johann Lay
2023-12-12 8:15 ` Georg-Johann Lay
2023-12-12 11:31 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0536c69-1ba7-43f4-8ab5-51329be43e94@redhat.com \
--to=nickc@redhat.com \
--cc=avr@gjlay.de \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).