From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 67B673858D38 for ; Thu, 25 Jan 2024 08:24:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67B673858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67B673858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706171067; cv=none; b=LFY/Mq0z+IR8JBJxsFiJATMNJO0hXhJKmiKfPxncId1OmubUm1sNaDoZVs2V1xazV9zjEQrThYS+N0X/G8uyWeSYvCZckLAun1VVl2XSqOFkBi3bt4DstKJzSNrImhRBptfoc3GvmG9iGfujeG5sq5obBBiTYPb6tbzWU1wVBfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706171067; c=relaxed/simple; bh=0ox5R4ZatGhpfJKfd7UdbY1JVG9VyTOI6vF9aO1xiFA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EiOJDZA19liDG1SOx/NnfxvV3TspCmbubB1V3XTRjgUWFkrku6aNkK+g1ZROm8H0KFD+s+2sROB0gX6lr4kImXUTR3G5AepSsaYxZ2/HjqSbk+HEC7v2XyYHGxxvd3iBXPG8JynIgOl9bPQzKob4y3WuB6Eh2X9F+INNX38lcJI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a2d7e2e7fe0so98236266b.1 for ; Thu, 25 Jan 2024 00:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1706171064; x=1706775864; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XSM1hyqPYaxpjODHi9cPYSgrwmmjL4nN+0sGDGkU5IY=; b=OTDqfbOCNH4Jbtt7us9utc042MSHsnPCclzLN5D4mj+COOWVfYpaau7mac++DxbPCC LHI8Wjxm2zb1XdfCWI/yCGo4EeSpKLonA6DeXqkCVktOOmWzwljXNZpk1Zvz0/SjPyUj 66qFAvUruOazj1PkLORO1cmbJm9dHUh5uJsOg1Vh3e986G3ce8y0HiPGi6WdSIhT5fpY g4mh4IdF+DYdJ4kwLRZR7v5e8PeseagD4UMYxyG1LpG6TehFIHLkStyWJQ6MwVQVbxM0 xaab5RcgoGf8W3te+/u1hkn9KZFGBoqlPQtBblhFb+L8jpedG69g1cDuAS3LvlbHw/pF +p0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706171064; x=1706775864; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XSM1hyqPYaxpjODHi9cPYSgrwmmjL4nN+0sGDGkU5IY=; b=XPShzDVc8csIs1HlvQ5uJucaXEObx3pNfI9pVqzfNE9Wn32ozw/LoHwFQdn8UECLR9 6641hgoXeqF5pavKKu1MqoEK/NnJupw7ICf+2M4lLBqU7AqTiiFXTmszBQZ+OJMC6VMq K1Dcfa3rvDvCWC3pRWWfudzp5aAMBFVUxvesF370em50uUycaGHXZzUnnLtr58QSvf8F MbPn3K6+OdoMf77b//Rb9mc6UckbvIAV3BY+SPAq6zFlzd2/8x8Vmfel+woQhlLAHSH8 OPNwdmwUtlPSQteqq2j0kKTYjLlIHLW69jnVCC+A0wd5+aj2qxdIzplj5p1MO0TlF8/L vydQ== X-Gm-Message-State: AOJu0Yzqa7E82IJ7IUSO81rMzXrtQNcOcqAxR8CCF/97Ta0HBDNd4r4k lpufAY8WJIDgJRK50Zg3b16iQjkti2b15p6R+ucDqp4QybTD4gDSkfw70i9pXQ== X-Google-Smtp-Source: AGHT+IGPaA2UAQtNNBb+gemu3yuxpRlb/qsvtjN71OGoetQAzo65c3SQ0QvfnnFtNhfUYldX5L9J8Q== X-Received: by 2002:a17:906:3152:b0:a31:2f87:d367 with SMTP id e18-20020a170906315200b00a312f87d367mr875165eje.29.1706171063865; Thu, 25 Jan 2024 00:24:23 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id l21-20020a02ccf5000000b0046e6063e2c0sm4516250jaq.107.2024.01.25.00.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 00:24:23 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 09:24:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ld: Improve --fatal-warnings for unknown command-line options Content-Language: en-US To: Fangrui Song , "H.J. Lu" Cc: binutils@sourceware.org, nickc@redhat.com References: <20240124225103.219222-1-hjl.tools@gmail.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.01.2024 08:58, Fangrui Song wrote: > On Wed, Jan 24, 2024 at 2:51 PM H.J. Lu wrote: >> >> There are 2 problems with --fatal-warnings for ignored command-line >> options: >> >> 1. --fatal-warnings doesn't trigger an error for an unknown command-line >> option when --fatal-warnings is the last command-line option. >> 2. When --fatal-warnings triggers an error for an unknown command-line >> option, the message says that the unknown command-line option is ignored. >> >> This patch queues unknown command-line option warnings and outputs queued >> command-line option warnings after all command-line options have been >> processed so that --fatal-warnings can work for unknown command-line >> options regardless of the order of --fatal-warnings. >> >> When --fatal-warnings is used, the linker message is changed from >> >> ld: warning: -z bad-option ignored >> >> to >> >> ld: error: unsupported option: -z bad-option >> >> The above also applies to "-z dynamic-undefined-weak" when the known >> "-z dynamic-undefined-weak" option is ignored. >> >> PR ld/31289 >> * ldelf.c (ldelf_after_parse): Use queue_unknown_cmdline_warning >> to warn the ignored -z dynamic-undefined-weak option. >> * ldmain.c (main): Call output_unknown_cmdline_warnings after >> calling ldemul_after_parse. >> * ldmisc.c (CMDLINE_WARNING_SIZE): New. >> (cmdline_warning_list): Likewise. >> (cmdline_warning_head): Likewise. >> (cmdline_warning_tail): Likewise. >> (queue_unknown_cmdline_warning): Likewise. >> (output_unknown_cmdline_warnings): Likewise. >> * ldmisc.h (queue_unknown_cmdline_warning): Likewise. >> (output_unknown_cmdline_warnings): Likewise. >> * emultempl/elf.em (gld${EMULATION_NAME}_handle_option): Use >> queue_unknown_cmdline_warning to warn unknown -z option. >> * testsuite/ld-elf/pr31289-1a.d: New file. >> * testsuite/ld-elf/pr31289-1b.d: Likewise. >> * testsuite/ld-elf/pr31289-2a.d: Likewise. >> * testsuite/ld-elf/pr31289-2b.d: Likewise. >> * testsuite/ld-elf/pr31289-3a.d: Likewise. >> * testsuite/ld-elf/pr31289-3b.d: Likewise. >> * testsuite/ld-elf/pr31289-4a.d: Likewise. >> * testsuite/ld-elf/pr31289-4b.d: Likewise. >> --- >> ld/emultempl/elf.em | 2 +- >> ld/ldelf.c | 2 +- >> ld/ldmain.c | 2 + >> ld/ldmisc.c | 75 ++++++++++++++++++++++++++++++++ >> ld/ldmisc.h | 2 + >> ld/testsuite/ld-elf/pr31289-1a.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-1b.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-2a.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-2b.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-3a.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-3b.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-4a.d | 5 +++ >> ld/testsuite/ld-elf/pr31289-4b.d | 5 +++ >> 13 files changed, 121 insertions(+), 2 deletions(-) >> create mode 100644 ld/testsuite/ld-elf/pr31289-1a.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-1b.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-2a.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-2b.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-3a.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-3b.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-4a.d >> create mode 100644 ld/testsuite/ld-elf/pr31289-4b.d > > Thanks for the patch. For newer tests, I wonder whether a descriptive > short name (in this case, fatal-warnings-*[ab].s) would be more > suitable than PR. > A descriptive name helps future readers group related tests together. > A PR number is useful as well, but it can be noted down as a comment. +1 Jan