From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2073.outbound.protection.outlook.com [40.107.103.73]) by sourceware.org (Postfix) with ESMTPS id 246063858C2C for ; Thu, 5 Jan 2023 17:01:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 246063858C2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUrj6btWnwTjzCKriwYtS6AO68dPrVLtqV/v9uuQyQK8W1KhozcifmyCiGPmWDCdp4EjdNE8wnUbhYWSLFZ4/3WY6f9yqFMFRmJGvIwmSlUYlkjst9nZlF3XGDmoO6xIhFrzj8maBs9fbOolQsUgkuDCxkN2FUs0TeyliFF57p1wJB5BQDErvPJDfmALiurdZptIUaDOrGr+EKepsIehlBqppSrkVbLCNoEwgdIig87gAItkFIWtjRD4/1sgNE/OQgGVmW/Fk/SZ1DnRSRan7FizMeCuOB0SV7PVUOdqfrKiJ7CUgWQEoQM1WDzK8TU1xhDfE9S5VgeedwaY4w3Btg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eFkKr4MJh+sQoEYtQulAlB+DqsA0raOfYUbRCM1BPDU=; b=Pr+x7dsQverjvE9N+s/XvmxfA0rz+Z5g7xfMYHhJwVqNEWPwm44mp8vb0wJ1nON/QRfKaikaTMt+8m8F85TsdMYDqfGdP1mN/JYI2vv6BYDlpZRVCV2KyM2aTndGGWbDK2QJ1LGedFzPArtKR2gQot51ziCl5XjlmapzymVX1cHy0kMnLvJSGcmkB0IIVrs3eWne3Kus+JNa06zBx2/pmvFfU5T/6cFBHDydHjrvftDUnsqW4c6ahmzgZcCoc4wyGxkwnuRhEr1F0PWN7OKXL7nMqj4gzVM8Y8xdkW1ec1zJQB1hKsnoHkxS1fwzocePgoedEDhT6hLwoPjpcVQSmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFkKr4MJh+sQoEYtQulAlB+DqsA0raOfYUbRCM1BPDU=; b=kTkGXIgV5Q03SoErKMTkrlMtgjZBVFr4MojA0L7DeL5ubfRfFyk0LSZ3iU359u8Uvtlw4fpm2pjWhXfZCoyHvaxDLWmO4uJj4RnCn+UYNgHrr0uea2VmPNSu89Gy5vstMtBoas6LiYk0SU0xz2lx1glRWW0zHXwNkwE9PVWxzkGkgfA0va/BAMyfTr397MVBrN7revCLAsvEynJKd2FiSACjQq5wNZReckGZxTs5v+4m6uZnlXlEjk6tfANilBJHckkOP4eBuHCL9g4hpxZXHTXm804vpDtPSQYAmmR9wirVMpAEA6Lcy0I3mAuU4EkOAh/SOhAq+BcHjiaTE9xGJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9190.eurprd04.prod.outlook.com (2603:10a6:20b:44d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 17:01:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 17:01:21 +0000 Message-ID: Date: Thu, 5 Jan 2023 18:01:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] x86: Remove duplicated I386_PCREL_TYPE_P/X86_64_PCREL_TYPE_P Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org References: <20230104191414.149668-1-hjl.tools@gmail.com> <707373e1-01e6-21ea-c407-db61da912e22@suse.com> <253e0337-5c05-5e56-de71-6ff890502af3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9190:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c7c9ec4-802e-426b-eb7d-08daef3e7865 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sk82b85Z+3FOeJhKhH1+XCMBfyQerIUnRaYClTegtDXh90WhsUbolp8fo+cwcnVXjDEASNGOuUVb/noSv2cx7xQ6+TYp+gEl1N5YVekG1vbMbgqZC/2mtBYAmLIPngiNCGyyezVd8CCXGuCA4kYF7bwr5L37+JOYrMnXgPCBjsKCF2u6s/LljDS7bn2AOe8X6YW8ECmgAA/lVlDLD5qzxTUpb6K/PJ5w+eN7N9+R+Vn99N5FqApV8hVKe2MrxzVeH2FdgoB5ZkwJIZ+PpLjqfep3Ev/4RYqB1xDIfIinfdpjR/RLt2oRfRcLCdGeTGlSGgSB0jc6oNCpdjh+Pn5d/XWtN6TvSbI+OASbq0zGX6b3FIwBo0r20LkzWxzHfXQloA+AIPMhVW2RvojBHPgTBKwoX3aEnQtHXuQtctzpFiDWa7nG6fblfEb3xUzbcpFIf2QRRO2S8taPlhvMZ8awKwz+5nk+5eeJPui4eiW3iatkHJw8bBoL9szfkJnDjPtCxNqPl9knmN896buY1SUhdwYApGrbGqK9bt7WhPRfklmO5HIJ5GxxAVAkzP4arn9TEbddq6pELoq3MfW0RKdoNDRI5Qc4AG02NpET23+96ayaHdpcn+TOXXAHpNXhTpfgr824sWXG2f0jVzW9pkVMRj4flQfSryAYPwx02fAXpshJ0zOTB1mol1OwzUgZGh9fn9JYOhH2U/Sar2M767OPZE4ahxLvxIm0z8RyHO3TdL0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199015)(6486002)(6506007)(53546011)(186003)(478600001)(36756003)(6666004)(31696002)(38100700002)(6512007)(26005)(86362001)(2616005)(5660300002)(31686004)(66946007)(8676002)(4326008)(8936002)(66476007)(66556008)(6916009)(41300700001)(2906002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1FyK052Tnd1WFV1Zmc4QnZEWFZQSzI1UlVoS2kxbHh5di8wMXR2cWZuMVBl?= =?utf-8?B?Q2dSTCtQa0hLY29GMUZKdXVHR1p5cWhoVmVjSzVlaFJkRkdQUlo2YldrbkZ4?= =?utf-8?B?RlBXNXJwTENmSmlxUWh4WGpqc01PdzJnZUN0Ui9nY1FobmRjSmJRYVJkZjFE?= =?utf-8?B?VkluQWs4UDlRR01ST1ZvQ1Z0c1hDU1VEajdzcUd3MkxrTjZwQ2x4T2E2YjhP?= =?utf-8?B?UFFPOXB2WWRlVWhUcU5EdEtsRm9iL0FCTjJoQk8xOStNM3J1NkV0YnM0NkhP?= =?utf-8?B?Z2pWNm1JQlhHWVhKUEZiRGMwUEMzNVQ4N0szR1RJeFZwb1dBUzk5Q2ptbjlo?= =?utf-8?B?VUZWajRjTTUzc1BVUlFhNFFibDZsdmFYclR3UG0vUE1iSExDa3JRWTJrSnE5?= =?utf-8?B?SlRnSE01eG9mMkJXV2ZuWFRhSG5FWmZMUXRuNE12NjJONUh1RjNqQTlqdXgx?= =?utf-8?B?S2x0Q1MrN2hWbjRGWFBKNDh0NTNvT1QzcEdwOTgrRXpJUTlWVzJUQ0liUUdu?= =?utf-8?B?a0MwNzhPVFFEQWZlRlNWRHhMWGZ3UEhaZVNlQ1pSbzFVWTJiNWdXRjAxOG40?= =?utf-8?B?Vk5lR2dwL05mLzYzalpxdDJHMWl4ZFp2MnRGRXVUT2NsbmM0aVkxN0tZdkxz?= =?utf-8?B?RWt0MGJKUEhzOVFvVW9oWllqL0ttYlNid0kwdldLOXIxUGNEdGlOZCtucG1p?= =?utf-8?B?QXlTTG1UTnpYcWRXWFVtd2NuYUpLVVJDMCtCWFRscEJqRytOTjR4QVRJN3Zm?= =?utf-8?B?SW1POExtaVFwTjgxR015UDc3bFZMeW9NTmNEcXNQYVBRa1V4dzFZSW5MNGRO?= =?utf-8?B?dExQVkd4UmplbFdQWmNVcWJzNWNSMUFuVnMxTklsd3M0SHRXWUpPQjdmeU5F?= =?utf-8?B?RWo0Nmk3MUQxNTFOZDQ2blUxYktSdElGTjVxRGt2c3VnSGNnN1FkbEU2KytN?= =?utf-8?B?WG1nMzdPRFlrNmpqVjE0REl1aE93dE84dEhIcW45eTFDNGNQcnVzekZhR0o3?= =?utf-8?B?L3NBOVNTYytaS2xZV0YzVkQxWHlvcmNzYlNHa20rSWdmZnhDL1dKZ2dpazFx?= =?utf-8?B?QkZwSmRjY1BDVkVRNWYyZnNmM2pydWQ4R3VNQlMyVFlpeHdsK3JvNWZtemtJ?= =?utf-8?B?RlRkY3BWWWhMTFR1R0ZxQmxtc2VUOHhsOXVmWHIxa1JzdWhWUldCRTBUTXpt?= =?utf-8?B?dFR0eXRzaHRXY2VnbU9Fa1dQalUwN3duMmFYbmlPWXJEdXgxV2dleVBXTDZF?= =?utf-8?B?d0VVVk1UVitqUjZrZDZXZmlsaDV2dHNEZ1p3VFczNFp1SUJqRSsyNlI4V0xO?= =?utf-8?B?dTZ4N0pjTUtwWTlRUGgyYmpqTDZjejQ5L28xU0RMRW15RUxwSGtRUE56K2Fm?= =?utf-8?B?bk1XbWJDL2xiM05iakpjcGhhNjhsT1VUcmpOc3VjRUw3MmRGVGZ0dStZNDhE?= =?utf-8?B?cXVscENNRU1RL0UwVW1ub0hlRGFFdFJ3eW5LNEpHcXZYaHdON1pBZ0dqMjI3?= =?utf-8?B?RHRVYWdlUytGU1l1WWJXb0g1QWkyR0hZdkZzc3JneDErOEdqTVRCOSswaXlm?= =?utf-8?B?cGp4MVpJMW9rTTdVUVJNdS9TOFFyOXc3dWoya0pXNGFIdnlESkRGSmFNK21z?= =?utf-8?B?dHlaY1g4amU4S3VOSUk0cStJOWpwc0R4WUhsemlBc21uYWN4NGFKWU9BL2ZS?= =?utf-8?B?NjRNUDdaQ1VqM1VJNWZCNU51a2RSZFd2UStOb0dZR2E5UkN1b0NGbW5nVTJa?= =?utf-8?B?MkFvRzVnL3ludDEzRTJaMWM0VVdwUEdFSEQ4RHZtbVNVSmdRaHVLWDVnTU5L?= =?utf-8?B?cmw0MXdkYWgyUDc3UStHNXdUMnRDSEtTREwvNHpqZnNyTTEwZHBVY3NpV1dh?= =?utf-8?B?N3R1VGh0UUFVTk1YYnBtd3NpTTlvV29iWXo4TUNPaEpkSytERkdmU3ZxbzNu?= =?utf-8?B?MzA5andjazBaNUhJTmlCRWRQa1hCb2hja083aExQZG5Ib1ozVk1acnI1a1Vh?= =?utf-8?B?ZnpoUmlTd2Vlb3dWVjR4TnVvUW5ydXhXS1JScnR4ekN2b2g2WDZnTUx5VENW?= =?utf-8?B?aS8yM2ZKeXdoajZpMjIyTnZLaCtSU0NpNzN2Q01sUGZ2R3ZFbzJ4UnhxQXQ3?= =?utf-8?Q?iaASnioRQeYe5dOjUzz9pLbfd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c7c9ec4-802e-426b-eb7d-08daef3e7865 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 17:01:21.4865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OLNXaXHl5+pohZXz6+Kz7deW7yrFcEpLor2bUA5pzRzYBR10wQrllX5AusOb69orY9K0uu9aljHKnD0RcSnOaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9190 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.01.2023 17:55, H.J. Lu wrote: > On Thu, Jan 5, 2023 at 8:52 AM Jan Beulich wrote: >> On 05.01.2023 17:50, H.J. Lu wrote: >>> On Wed, Jan 4, 2023 at 11:42 PM Jan Beulich wrote: >>>> On 04.01.2023 20:14, H.J. Lu via Binutils wrote: >>>>> I386_PCREL_TYPE_P and X86_64_PCREL_TYPE_P are defined twice. Remove >>>>> the duplications. >>>> >>>> I recall noticing this as well, quite some time back, but I didn't feel >>>> like touching it because I was puzzled by ... >>>> >>>>> --- a/bfd/elfxx-x86.h >>>>> +++ b/bfd/elfxx-x86.h >>>>> @@ -97,13 +97,6 @@ >>>>> #define PLT_FDE_START_OFFSET 4 + PLT_CIE_LENGTH + 8 >>>>> #define PLT_FDE_LEN_OFFSET 4 + PLT_CIE_LENGTH + 12 >>>>> >>>>> -#define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) >>>> >>>> ... this not including PC8 and PC16 when ... >>> >>> This is I386_PCREL_TYPE_P. >>> >>>>> -#define X86_64_PCREL_TYPE_P(TYPE) \ >>>>> - ((TYPE) == R_X86_64_PC8 \ >>>>> - || (TYPE) == R_X86_64_PC16 \ >>>>> - || (TYPE) == R_X86_64_PC32 \ >>>>> - || (TYPE) == R_X86_64_PC64) >>>> >>>> ... this does. >>> >>> This is X86_64_PCREL_TYPE_P, not I386_PCREL_TYPE_P. >>> >>>> Jan >>> >>> The current ones have >>> >>> #define X86_64_PCREL_TYPE_P(TYPE) \ >>> ((TYPE) == R_X86_64_PC8 \ >>> || (TYPE) == R_X86_64_PC16 \ >>> || (TYPE) == R_X86_64_PC32 \ >>> || (TYPE) == R_X86_64_PC64) >>> #define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) >>> >>> and the ones I removed are >>> >>> -#define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) >>> -#define X86_64_PCREL_TYPE_P(TYPE) \ >>> - ((TYPE) == R_X86_64_PC8 \ >>> - || (TYPE) == R_X86_64_PC16 \ >>> - || (TYPE) == R_X86_64_PC32 \ >>> - || (TYPE) == R_X86_64_PC64) >>> >>> They are identical. >> >> That wasn't the question, though. I really did ask about the 32-bit vs >> 64-bit difference, which looks suspect to me. >> > > R_386_PC8 and R_386_PC16 were never handled by linker. May I then ask why that is (or, worded differently, why the two respective types are handled for x86-64)? Is this just one of the many inconsistencies that we have? Jan