From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150045.outbound.protection.outlook.com [40.107.15.45]) by sourceware.org (Postfix) with ESMTPS id 74AFA3838644 for ; Fri, 10 Jun 2022 10:56:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74AFA3838644 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iDWRf0ZTIisRghUhLVXxNAlopSu+KB+RfjCzSD088eDVRZpvkPCGzT2FmoKjaukOmZBijIBSvm022NWTj3I2LCJ3zlZhJac1aCsAGpCB8EqHtlUsBJftnJazuAFSO/qm+nzwFRGOQhwKAbifkkd2sEVFTlrHGvuLTjjqRBAsq1wg/X5QBfMnbFasScTpAD8x3IQ7zPUC7FcyYolfbnOeP/mqLviaghioaZHdX8cuEEP4VPT7J06LxQjVfGtWiK73hJv6Zgsby9PyBdIxqiNsU7cLqPfaAH+raIgn3wb0erLRbSVMeE9BvrDBXRFKwOaJRkeYaBdK5OcRN23uwvLUsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8eFgOZkhBsfDI9pOMVS62ua6EGIGDCvL+Ayom2IaPYo=; b=LJJrvIzp7CS18p3SMSRBz4WhJ/seFvKAp6jgL8nwq5C+CKZpMPAODdj8UMMDaXMrTgeSy9rhhjlN1tvoU2FyuO+paouJitEpF2wTpvLt1jHSYaTazRc8W6wB+K0XSkVrm88MeWwcMAUXztNexZ9D/EuQdSBARI9gcBo/cdXBOltYQ7iFgpQNk8XuMo5cGB8UJUYTPdHEgX//dBC0RyArl2UkdW+mlVrYLsEDkqRWh2BYX0e3cOhNAjnvfgcQk7cc4YPLrI+yf9mhR4E6IPTfDosHj7vrect5g3lB0NMxNwIWqFA+7lcav59dyYu8Q5dYGXBrPwpKk9zpg1LnePfrgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3723.eurprd04.prod.outlook.com (2603:10a6:8:10::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Fri, 10 Jun 2022 10:56:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5332.013; Fri, 10 Jun 2022 10:56:08 +0000 Message-ID: Date: Fri, 10 Jun 2022 12:56:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCHv3] libopcodes: extend the styling within the i386 disassembler Content-Language: en-US To: Andrew Burgess References: <20220509125414.3526554-1-aburgess@redhat.com> <20220527174443.223739-1-aburgess@redhat.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220527174443.223739-1-aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0102.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::43) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2106aa9-af27-4f7c-fd2d-08da4acfd2da X-MS-TrafficTypeDiagnostic: DB3PR0402MB3723:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aFw5u7L58cYnvnyR7+7EOyYdxsPMVabkiTdvXNb83dFosuh4t8k78bysXrurqCl0COW7HKd75LRcZ88EvEHeDHjz9M10usxoFJFn6Sts0wLeMt+NcN2fvmQN+EaC3HbzooITrIbquvAlGO7hjctFxmQ/n2uAD73yHHqwBAOdkC+TpPy5KJj8yw2t7w+Y5y2YV+Ndl/aFZYcnsLz/mrGE5OH3rI9lZrCFwdn6Hu/xOxe0YiD0dxhg02l/FSe+b3rTRHivMUCkhMTouJ9DwvNQyE7KFyLAe2GqBICw/5xGIyvh5Cd7XXvCRkolWfJwM4gSMldE4DIiMggmwW3pRDjCUf+Fe/q621sG+e6wXRFWvlUlblhBmh1z+nIlNkQRFv/1S2owMDurZFqel5sPoNsdN+vMLf1nQVXEnEQIf4ewBahDDpBC1zZ4D8PuUj+r9mPdUqc9m9dZQsMKTsNjdwla7JYwz8euG3QGiI/teoYm35BwGkV/5Vnh+X6TADlbToz45t2nwtxXfs+kXcwvm1huC4FIEP8kTS4052FZAxR0Bk2zU3lrcRFHpwXomyt/s1iWpcnt3asGm0wKRVlrIoj8D7xw0KFdjI9WIheZ0awHeAnvlunWtNYDBcQEgXJlU9CRdM97Fk3Een+x/q17DAvNNCUxlUb3pLBLEZXiaMLHJWn/7DgAsW51UAHe7dzL89xZ1jHe6Dkdl07HzweuEH2Wq6ZSbmglOj0AtXChALUKY2YjobgnwWGItCcP1lw2PfuN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(26005)(6506007)(53546011)(36756003)(186003)(316002)(6486002)(6916009)(508600001)(2616005)(6512007)(66946007)(66476007)(8676002)(66556008)(4326008)(8936002)(31696002)(2906002)(4744005)(5660300002)(31686004)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnpYWjRYY3B1dGdHdG1MYTgzbVlRc3RqNVc3RGFjZGFCdVJyQ2szSVdwS2Jk?= =?utf-8?B?ajVSME9admlUcGZ2aCtqbW5OWmFhSVRUM3RzSXNUZHdvQmMzYWdxYldzdUU5?= =?utf-8?B?amF2OEN5T1ozcHhEbXZyOVllTWpSNThjaTh2UE9QeHhraFZrTzkvSDNxZEow?= =?utf-8?B?N1dFWStjZWpZY201bjVuWEt5VUZFSkI3OS9TMjA3YzVHSGFZakJ1S3JCM00y?= =?utf-8?B?TjlDMjRrYkVrN3JTbUZid2E2enNRWmN2WVkwbThHb2ZRZzdJL0RWWHp6QXJL?= =?utf-8?B?S2lWd29BWFJxWURrZTMzSnVwZ0lvdE1UUnR5bWdaa3c4SGZKQVdWbTFacDVl?= =?utf-8?B?aHZmL1d6NHFuMDByTGxhVFFKbXhzNnJRNnhGWE9wSUtBeWdKSFRRSTNnVnpp?= =?utf-8?B?aHZYQ1FMVzVFRVdsZStpMmVVTm9ZSE5Mek5URkllZ2FxNndQY1BNQllRd1lM?= =?utf-8?B?UC81S1RHMHlzVDdmb3FJM1REVVVoS2hna0ZrK24vV3hiTlVkK0N6RldJNFQ3?= =?utf-8?B?bmsyWk9zS1c1Z2RKbTYvcGNTb0dxdlRrYzl0MXNhcHVtYnlLcGtDYTVyKzd6?= =?utf-8?B?NFdGbXF6N2NWZ2g2Nlp1Mk5ROFlaREtoSU9yOTlTS3lLUmpYU0tESUFjbjlY?= =?utf-8?B?cjVTVkNVaENmckd0UnNOS1I0TUhyRWdER3pKYytnN1VpcXVaZkw1TmF4S0xj?= =?utf-8?B?WTVuTE1zc3Q5TXNHVVNmNi9ack00N0V3eVRVczU1WTlvUnpBWS9ISU91bktn?= =?utf-8?B?bk1yK0FNeitCNzI5ZlE5aXhHaHNCc1o1dTREd3ZxbFBxbUFrb1FxUkpPbnNn?= =?utf-8?B?RmVPR0dzcUtvbTVNNmZmSGd1cFNaK3FhNEREeWZYWHhyYnVIODRnRFRhZlU1?= =?utf-8?B?MGpUUlhYaVdwOGpuaWk0dFhMM0tlMU5UaTNKcXVRSGM3MXNPUXRsaXFNSW8x?= =?utf-8?B?OXQ0VUVDMEEwdTloeGtWZlAvWjNwOGoxVXEyaTRpOE9qMXBVUDBNRzI5RDRl?= =?utf-8?B?NndsRG9QV3FRendyNGtFYWMrUTNkc3ZUM3RibVd1QUJXdDZxL1dLc0ZYcEJa?= =?utf-8?B?ZTRGNU5SaWNwb1VTejlrK1NqUjJzeEpWbWR5bGFjMVVKZXhGV3lFYTZrODdj?= =?utf-8?B?d2xkYXRIY3c5L3lycktrQXFhc2tVQXdWdjZYUWFaaWdxUTlFTHBqcldNTXlv?= =?utf-8?B?SENCR2haM0RPTEttWVJwTktURVA2RWM4ZndoYWJqQlpQdGtHbzA0VlpJUTdL?= =?utf-8?B?S0FIb05SY2JGWExhTHRYRUUycktPaTBscjlqZklScWthdlB2bE5SelFnbEkr?= =?utf-8?B?UllaeWV5cWJ1YkpxQlNZbWNVOXA1VVFlaHlxN3d6dEROZFEydmcxbW40WWlG?= =?utf-8?B?b1FoQmEwQTdlWFFaL0Q4dlllNEM2dnp0NGdRZEw1SDkxeDY5WmdOL3o4SE0y?= =?utf-8?B?aTlGa3E3WVVScGVqT094MHM5N205RG9Yc0Z2eDgyREZUbXBQYXVOdGpIOUVm?= =?utf-8?B?YUpaV3hjdWNkN1FhbmZQeUxNTThHZ2JPYWl5eGpYQnV0dW0xVUJzdFVUdTdJ?= =?utf-8?B?TnVDQzBJcHpSeE45cUprZlRxOGtFd2p2TkZ3Z2JCdHNUSkVtaFl5TklKWG9p?= =?utf-8?B?VDZjUkpLZHhmVEJNM1VuNWpqTSsvOWlHRDY1UUc5Z2kwSlNFWFUzRUhZMTN2?= =?utf-8?B?S2gvMDhwa0FiTnlyRUl0am5PS29acXNZaXlSSTlWS3g4RFVGQjgyaEFJM3Bu?= =?utf-8?B?V080d3U5V2RWY01BRG9YeUdYMi9SaXhvOTJ3dHNRZSt5dklXeGJpZ1BXNmdU?= =?utf-8?B?U1RpcXRxdExWM2JaSHl1eVU5UUdSa09XY2xaTFdNL0FWdExEd3JXS1ZQcTZJ?= =?utf-8?B?Wk04NExLQ3lIVTFtdmYwRFNTMFkzUzZUU28zZXd3czNZK2RiQnJmRkFpc3lh?= =?utf-8?B?a1lUb1BabU02NkoweWo5MUhwSUxLcVFVU29JNkQ5dUEranhuNlE1QU84VUJx?= =?utf-8?B?QytWNXM0L0NVOTdKRHdyYU1WclR1VTRVUHdkWHpQalNLTmtSbllMaW9tdEdy?= =?utf-8?B?cjRodWIyekVtRE9iRy8xK2l0c0lOaXErTlBUUnJiV1FEQm1jbUw0YkwwdEJL?= =?utf-8?B?bmc0Q2hHd3VpN2NJU0h5dURrL2thQXVuYjZPaUJvd1NuTFFEcnMyalhzUUta?= =?utf-8?B?c3doemd0SGxYTUh6MFV4TUJrWmY4KzJ2alJlKzJNYkRVY05aMWFISnBZZjZN?= =?utf-8?B?QVRTWjNnVkdkYWZYd3BBcWszdXB2bU9YTk9Pd1d2R3dFazZ1bjdaUElITzVj?= =?utf-8?B?Y2w1NXQzMWM4OEFJZXpRZG4rNTgyY0tkZWJncVplSC9UbGpLU1ZhQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2106aa9-af27-4f7c-fd2d-08da4acfd2da X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 10:56:08.4474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F3v6ZUfTXgKXRHZ3/TYm4IOpejz7/j4sK7a4xCGSJu0VuazvwnUppIkKwNfgnqd0v0XGdRMHnRVySD2Rifk2vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3723 X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 10:56:13 -0000 On 27.05.2022 19:44, Andrew Burgess via Binutils wrote: > @@ -11595,11 +11750,15 @@ OP_E_memory (instr_info *ins, int bytemode, int sizeflag) > print_displacement (ins, ins->scratchbuf, disp); > else > print_operand_value (ins, ins->scratchbuf, 1, disp); > - oappend (ins, ins->scratchbuf); > + oappend_with_style (ins, ins->scratchbuf, > + dis_style_address_offset); Is there a reason you changed this to dis_style_address_offset, but not the other cases where print_displacement() is used (always for similar purposes)? I'm asking because I'm going to touch all these instances, so if dis_style_address_offset was always meant to be used there, I'd switch that around kind of as a side effect. Jan