From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2051.outbound.protection.outlook.com [40.107.104.51]) by sourceware.org (Postfix) with ESMTPS id 6C4A83858D1E for ; Fri, 30 Sep 2022 11:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C4A83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qik2lStcl0aUViEOTLkZaDyEJ2XT9ODf7IoakKFuIc1Aakp+2u+LqfhIsFUehm/yGhIqmy6ljaexMOhuCPkDnIwduPpsd0dLaHaaiyviUmi1T01RCOy9EWwHfhND79ZAJn6KZpIitVu4ocCwG+t+rMBVWobLOD2NVDJTvittHd2zAqI39N4WG2sgx3HBj2eI4HrwcboM9pmGpFuU9rxV6jNlhbI2IyIyd51EZqgfq4SRS5OfsXjlxc8faMnBGugxggXWa3Dzm6P/uFR1j+13FcaPRcqOZk9rt223gwtDsLTM3Sz4xCDG2O+n15JEVDbtMrsdvIiTUj5o41DuYJpbmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gtjH2A2qjLtwYqdMfSWfQEdQFiccYGYwpzCmKKxRuQ4=; b=FArOgDq+Ta18A4j3+c4qWYk+LRFU7Ce+JEd5M46UGlx1sLEZa6KmI8bZuUYkthhfpEUbJlGTHI11neuuWnzELw88DWyPqcRQiOU8T+OrJQF0ilkN+0i4thcuYBsfB5giSs/N1siNNvU/w7thXFBdSmLGkkQ+Mn+pkojvtrAtoMSDAgn3XRfNJGdTUsQSs8MXCTnE3D/vMOzbQCDt1blwaNv5tDrHIp/PKkfWtLpOkTb5eHpuL31LdtXqkXnIUKrnNv6Zdr3FcoAPDfueQNd9ju1bAJdYWXCU/CX+d7Cq33J3aFs+wYVyNI65UhTHTHDfk4yrumlCXs58uq404sgrlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gtjH2A2qjLtwYqdMfSWfQEdQFiccYGYwpzCmKKxRuQ4=; b=kMae3VqgHe6xnk0dc/sF5TjT68f49tTSa/cweYIB+KXKUzYAdNoo0Bhzbin1+o3KKk4356tM+/db3haViRoxGiuHtPFYU/93pmgXtRXN3vRFW8lqRXk9HZc/1Bw0aKBYW9R/9xpv0Y8gOVJUFseHLsQIx5HJYcmvtdDWYp+4yzS+iO//A6x1plYGpI71wBlefMfi8tj6KkeLd7O7baGbwX4AoJtHNSu3hC5Z+m384YCYKkwhf/tSTwgeYBKL8/RVh7OHB0APE4Wk43gOQhh/CWjy5IOxv/pDU6CrC0OUqBRozdM34aIYzYFg8vXwGhPI2iFMD1baFUFVMS/Okz0hOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8009.eurprd04.prod.outlook.com (2603:10a6:10:1ef::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 11:59:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 11:59:05 +0000 Message-ID: Date: Fri, 30 Sep 2022 13:59:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 1/4] RISC-V/gas: drop riscv_subsets static variable Content-Language: en-US To: Binutils References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8009:EE_ X-MS-Office365-Filtering-Correlation-Id: ab1dea26-6c1b-4bf2-9aa2-08daa2db2c66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6325TeCRC1URy5aKtquU2XrSSPYEi70m2FDXaKGexo3qAhozPTaEcHrbA31KZBBQnV5b5gxhiYfc9rys1Zv1dn+nXcR/zyCB/+NxKF/y9HbPB68J3eaXMKVrB2TxWH9qzcbSUv0AtPborLZu+Q+aH+4bZ+WblZDW4tKRUAzuR6nIcw2APgrWoxqzJGJQGqcH89UwNr7JilF/PhRoSuwlf4J4oQI2X+0zjbneFILNFrmeIheTPPgwtT0Q2fB+/ejsAYEBky8KBN8+2LQvbYjNn3rZPejw/2S14S8jHvjCyw5R334mQyZGztX9Hc3qvmeADcckXBi8ys25AHDhsIP+Sxx8cnXBNocbkXApGSbw1zZwV3xhGhQEfDwIjiSKE7g+prU3l9crZKPG669HUAfKXyuDKUJ2gnSXxVxODZwQalV+u8yUcDg0PbGpaAAaHgPb5boC8fOT56WDjiNqXWdH8L3iDe1bv8sL/b3VrmMU7Ua0AndE5EtXMsoyqP4Qv+tEI2ADXCeW1zKtp8CaAvxW4Ir09zXEwj2yrgVnuBIej2xIhANXlyg3kPJnQIsZ7R60jq+wq8/Qu5iAIcHyOumK23aH+Un+4Jl6jIMdaNB+xbcH2EGzecQQUC/8sy7iveYBVGyZsY2roVh/UZs1QdQArr0pN4Ezo2LjMfuaVSnuMdxbyxfT9t/tidm9kPF5lsIUWeLZWcezt31WLDlTNj4l9fIiiqxf8WBEpJ1xrOVRO2JmNfy/j5hwxcXkePyGlgBcWh/pzttwXjUOG2MvCzIWDs1sHQiqA8Ovg2cYG5Zjo3c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(31686004)(2906002)(5660300002)(36756003)(8936002)(38100700002)(66476007)(66556008)(41300700001)(6916009)(8676002)(316002)(66946007)(2616005)(6512007)(26005)(186003)(6506007)(86362001)(478600001)(31696002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVJ2TkZkbW90c3FGdEkyc2xKNkppY1VkV3hhYklEN3JwaUVUU2wvR1hjWUlp?= =?utf-8?B?bDNEV3JzQTNVcTJ6QkNxRFNQcDU5c2o0bHY1WnZHYVJFUkdMS0NmSEQzQkVu?= =?utf-8?B?TlpVQ3lONXoxQkZ6Q0pNZFR2c00xejM5ZjA1NzM3NGlSaURFZGtCQU94Ulhq?= =?utf-8?B?TUNZWHpaWVMzRGF1b2JtT0s2U214WFVqa2plaEhlSjVxNmFjclJROE13M1JX?= =?utf-8?B?Yjl5UVpreHo5NWlQZXpXVEl0azQ4a2sra0JKZUpVbWloQ2Z3cnJzUmowREhO?= =?utf-8?B?a2lmRzJsUzVmcE0wQjFGemw3Rk9MU0tMOXJncHpsS0o0WjZGUERsM2dxRFdr?= =?utf-8?B?OG52eUJ3ckRIblM0TkdaL2duallrOVhDQ3dyNTdNbTVXNitKNEZCSTlhaXB6?= =?utf-8?B?bHVpY1h4VzVIR1Z3V3dTQk1FYXlsUWE3QjdVYzl6OG12cTNraERzQWVrbnVr?= =?utf-8?B?amEwV3Z5UUFIMW55UUk5SENlMTNwU011Vk9UcmxWTGFBZ0Y5ZG82R0ZoOU4x?= =?utf-8?B?bTc2MHVBOFlvVU1nejlkMm1wOTgxRjRKTkpLTGNpd0NPWmhKSE9OV3FtOEt6?= =?utf-8?B?ZC9yajlIcmdLM2ZuSDJFbE41MzU3cVZBK1czUUxjaERCOHhaMG9jVHdlVkVC?= =?utf-8?B?aG5qbVgyMEVhNHRLWlRCN0hnUTQ2QVk4aTZsd0czMGl4ZkJwdXhRNzVVdERm?= =?utf-8?B?SHA2MDRDamwwemxIU2xkMWR1M1NHd0g2SXNsTVRTOWJwaHJJSU9ETjhIWnpT?= =?utf-8?B?TDBVbGR1TmN6alk5ak45b1hTazZNUFlXZjNSeGpRcFROVEFvZ2Mrbzlvay9J?= =?utf-8?B?UXJKbzN5NEhmT1gwMnZUZGRhdkNZWDcrVDJxUlRpdTNGUjl2S1dDaEJISHhp?= =?utf-8?B?SUltN3l3SHZ4LzhxSm5DQy8wdjVNZElpNDVKb3YxbTJXS3oyZGY5R2xHM1dB?= =?utf-8?B?c0pNMWd4ZURpVFNJWG13OXlHWG1rQ1ZGbGRDYW5OS0lFbldYaHpUaDZITmV3?= =?utf-8?B?NHJuQ3JMZDRnVTZ3ZHpHdmVXR2VQV3NmejllMjlTbEZtemJVRlhDeFhLbGlk?= =?utf-8?B?QU1aaVpEa1hJK3hkTG5xcG0yNHgwSSswVkJKSFNJL2d6K253a0c4OHlNMEJu?= =?utf-8?B?MzB2SXR2cGZYbEpJLzdickc1QkYrMEdWZkwzTnRVc1FHWVA4ckNLdHRVbENG?= =?utf-8?B?N2dSSytidnhJaUhmMzRPdEdkL0dPOElNQmZnZkpvSzhFZFhNK3VYb2NIc3do?= =?utf-8?B?VVF0ZEh1TUhNVy85endreG1LTXhDRjRyZys2VzNONE15a3BiNjVGdk50Ully?= =?utf-8?B?N2R4c0lOSHRJamFqY3FiZGlYN1dvZ0FYNEppZWQ2UVZTa24xcTZwSER1UmNa?= =?utf-8?B?MWtUR0o4UFlUVkNsajdXR2lCK2J2aStHNW82R1JkUit1bUdhK2pKU1JNeVVa?= =?utf-8?B?YnFnQ2xxL1RGT0dmZ01Db0d0UzI4NDFUY2tjR25iMmxqNDV2eU1vTzh1N3Jk?= =?utf-8?B?L1Bmb3BiRnh5NEx4Vy9reEdWMXplUUt4cHQ2MW9KMjM2amdoOXZtYlJLZ3Fj?= =?utf-8?B?Z0NzZStPenJBNnhlbHNPZHRFd1ZwWjZzYVdrSUR3bmxObkxvazJSdW9ZMkZt?= =?utf-8?B?R0phUEpidHVQMlBUdXBoYTFDajFPN1ltT3drKzNQRlZtcENoS21EU2Q3R0Yr?= =?utf-8?B?TlMvZXhJZ1RpWCtvOVVnRVNpNkl2Zlo3Z0dIclZFcy9jL01FTkwwN250MmM4?= =?utf-8?B?NndxMkVFUjQ0L0twZzBKQmFGT3Q2NXNXQkprNWE4eDU2YUJZWmF5VnRHVTZT?= =?utf-8?B?WTBmQ0NjeG1EUTZMR1BvREtjdk5YWURoMUNvTytyM3VKdVNhOUJEMXFGZTkr?= =?utf-8?B?cnBUR1oxME5CRVVONkpmdzRub2E1dXR0TXJHVkRMUEdxeXJ3WkN0NVNveTR2?= =?utf-8?B?MitReGljMlVQbUc1MVB4UlJtQTZ4VkZYRHdoeitybENJNGxjNGFtRGZmbE5F?= =?utf-8?B?ZlBUZlI5TEJsZGNXcHE1Y2xXeUpPaDBVWkhMczR3bjJRcGRRNHFHWUh0TTZm?= =?utf-8?B?dDhBUEIxa0JMbm1NM3V6dE8rc09XNjlUV1hFYlFYbXQwakp0dGhpRmZ0dWhO?= =?utf-8?Q?KqovIObS+gJHhi2jj6sDNWPEC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab1dea26-6c1b-4bf2-9aa2-08daa2db2c66 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 11:59:05.4055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5qSnUZuKdC4Gs6C6JclFcepxxnkrK/N+djimamKU2f5Qea8f4kDoAjoNTZWbH0Ps3YeAyrk//nBFDDlSN/ZPLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8009 X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It's fully redundant with the subset_list member of riscv_rps_as. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -265,11 +265,10 @@ riscv_set_tso (void) elf_flags |= EF_RISCV_TSO; } -/* This linked list records all enabled extensions, which are parsed from - the architecture string. The architecture string can be set by the - -march option, the elf architecture attributes, and the --with-arch - configure option. */ -static riscv_subset_list_t *riscv_subsets = NULL; +/* The linked list hanging off of .subsets_list records all enabled extensions, + which are parsed from the architecture string. The architecture string can + be set by the -march option, the elf architecture attributes, and the + --with-arch configure option. */ static riscv_parse_subset_t riscv_rps_as = { NULL, /* subset_list, we will set it later once @@ -302,14 +301,13 @@ riscv_set_arch (const char *s) return; } - if (riscv_subsets == NULL) + if (riscv_rps_as.subset_list == NULL) { - riscv_subsets = XNEW (riscv_subset_list_t); - riscv_subsets->head = NULL; - riscv_subsets->tail = NULL; - riscv_rps_as.subset_list = riscv_subsets; + riscv_rps_as.subset_list = XNEW (riscv_subset_list_t); + riscv_rps_as.subset_list->head = NULL; + riscv_rps_as.subset_list->tail = NULL; } - riscv_release_subset_list (riscv_subsets); + riscv_release_subset_list (riscv_rps_as.subset_list); riscv_parse_subset (&riscv_rps_as, s); riscv_set_rvc (false); @@ -3986,10 +3984,9 @@ s_riscv_option (int x ATTRIBUTE_UNUSED) s = XNEW (struct riscv_option_stack); s->next = riscv_opts_stack; s->options = riscv_opts; - s->subset_list = riscv_subsets; + s->subset_list = riscv_rps_as.subset_list; riscv_opts_stack = s; - riscv_subsets = riscv_copy_subset_list (s->subset_list); - riscv_rps_as.subset_list = riscv_subsets; + riscv_rps_as.subset_list = riscv_copy_subset_list (s->subset_list); } else if (strcmp (name, "pop") == 0) { @@ -4000,11 +3997,10 @@ s_riscv_option (int x ATTRIBUTE_UNUSED) as_bad (_(".option pop with no .option push")); else { - riscv_subset_list_t *release_subsets = riscv_subsets; + riscv_subset_list_t *release_subsets = riscv_rps_as.subset_list; riscv_opts_stack = s->next; riscv_opts = s->options; - riscv_subsets = s->subset_list; - riscv_rps_as.subset_list = riscv_subsets; + riscv_rps_as.subset_list = s->subset_list; riscv_release_subset_list (release_subsets); free (s); } @@ -4502,7 +4498,7 @@ riscv_write_out_attrs (void) unsigned int i; /* Re-write architecture elf attribute. */ - arch_str = riscv_arch_str (xlen, riscv_subsets); + arch_str = riscv_arch_str (xlen, riscv_rps_as.subset_list); bfd_elf_add_proc_attr_string (stdoutput, Tag_RISCV_arch, arch_str); xfree ((void *) arch_str);