From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 0EA063857BB2 for ; Tue, 4 Oct 2022 01:34:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0EA063857BB2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id BE838300089; Tue, 4 Oct 2022 01:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1664847277; bh=GDfiRhrTQGxLsTGAeKY9A+kNGqZVM4MKtqaY9OD2aE8=; h=Message-ID:Date:Mime-Version:Subject:To:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=XaaYnwdfGOzXdZ6wy1NLk12ZagdOiGAocCYp6Xav0CADkEa3/ddPbSg++fhBQZZoz kS4Qxv+zafE04dCi367gLwr4zRqXfOYCdDv8tHt72nTNEWsy3P04to8P75HEv1U2gP YNkr0d80sLHJ9Ivpob4rmlqs2pLammwOVLpRPMTE= Message-ID: Date: Tue, 4 Oct 2022 10:34:36 +0900 Mime-Version: 1.0 Subject: Re: [PATCH v2 0/6] RISC-V: Fix disassembler types and styles Content-Language: en-US To: Palmer Dabbelt , Binutils References: From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/10/04 2:40, Palmer Dabbelt wrote: > On Mon, 03 Oct 2022 02:59:18 PDT (-0700), aburgess@redhat.com wrote: >> Tsukasa OI via Binutils writes: >> >>> Hello, >>> >>> This patchset fixes various typing and styling errors on the RISC-V >>> disassembler. >> >> I can't approve binutils patches. >> >> I've taken a look through this series, and other than the minor typo I >> spotted, this all looks good to me. > > My worry with these things is that it's sort of a grey area in terms of > what our stable user interface is: there's definitely folks who try and > parse the text output of tools like objdump and changing anything risks > breaking that.  IMO that's too strict of a stable interface to keep > around as it pretty much prevents us from fixing any disassembly > weirdness, but I'm not sure if that's what other ports do and I don't > want to make a mess by breaking users' expectations here. > > That said, as far as I can tell the only user-visible change here is to > print some bits with the correct syntax coloring in GDB.  Seems pretty > straight-forward to say anything users can't rely on parsing syntax > highlighting colors being a stable interface, so maybe we can just punt > on the grey area for now ;) > >> Thanks for doing this. > > Yep.  These LGTM, but I'm still kind of buried thanks to the a few weeks > of conference->COVID.  They're probably fine, but hopefully Nelson has > the time to chime in -- if not I'll leave them in the queue. > > Thanks! Understood. I hope you get better soon. It seems it looks good to you but no approval yet (I think Nelson will approve it because he approved related patch). For this particular patchset, that's better than just "approval of v2" because "PATCH v3" has minor changes (although no functional changes). PATCH v3: CSR style change by Andrew Burgess (I also spotted it but didn't included in this patchset because it seemed non-obvious as the rest): Nelson's Approval of the patch by Andrew: Thanks, Tsukasa > >> >> Andrew >> >> >> >>> >>> Previous Patchsets: >>> >>> (2022-07-13) >>> >>> (2022-08-03) >>> Tracker on GitHub: >>> >>> >>> >>> [Changes: v1 -> v2] >>> >>> -   Added PATCH 5-6/6 after T-Head extensions are merged. >>> -   Slightly improved the commit messages? >>> >>> >>> [Styling] >>> -   Print real immediates with the `immediate' style         (PATCH 1/6) >>> -   Print comma and tabs with the `text' style               (PATCH 4/6) >>> -   Print T-Head literal operand with `immediate' style      (PATCH 6/6) >>> [Typing on printf] >>> -   Fix wrong type for "%x" format specifier                 (PATCH 2/6) >>> -   Fix minor but various typing issues on T-Head immediates (PATCH 5/6) >>> [Small Optimization] >>> -   Use smallest portable types possible to print            (PATCH 3/6) >>> >>> Thanks, >>> Tsukasa >>> >>> >>> >>> >>> Tsukasa OI (6): >>>   RISC-V: Fix immediates to have "immediate" style >>>   RISC-V: Fix printf argument types corresponding %x >>>   RISC-V: Optimize riscv_disassemble_data printf >>>   RISC-V: Print comma and tabs as the "text" style >>>   RISC-V: Fix T-Head immediate types on printing >>>   RISC-V: Print XTheadMemPair literal as "immediate" >>> >>>  opcodes/riscv-dis.c | 71 +++++++++++++++++++++++++-------------------- >>>  1 file changed, 39 insertions(+), 32 deletions(-) >>> >>> >>> base-commit: c21736aed1d4877e090df60362413669dbdc391d >>> -- >>> 2.34.1 >