From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 154523858C39 for ; Tue, 9 Jan 2024 11:07:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 154523858C39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 154523858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704798456; cv=none; b=TMTC+HxpvXMgPuMcTDU+U4fouHhe67moSAsRI70e1SC1ydoZx8rfYTWtTpiloOdP8oa/khp1Ig5AwIba7BkSeWQt9YAwgVEHwt/cO/NI/nJpkHIj5x0IWjPCZgwlnHY0rrRgUNA9Nw5EhAkkdyjSzNERdPEBmH21opeZl5OpcwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704798456; c=relaxed/simple; bh=ccAlD4oTijdmnTcuA0xM9VgEmKI0nA040YdiXEzSjzM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UzY+tgyv1DcoVywxrIaCpwUhk83x+bDaAKPGuZHyhV2Ob+AOW4dFOYP+USrEYuqNMLSsIP4ebhcuF6M+q413mXoL1OpTF8zE9V88IbBZJ2oeeDGURiJ6a4Wpv66LU98KMUNmXGaatFIHvxt/XKXoVJAXu4LWbgXZNxzTIOd8kUE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2cc9fa5e8e1so32167521fa.3 for ; Tue, 09 Jan 2024 03:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704798452; x=1705403252; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ccAlD4oTijdmnTcuA0xM9VgEmKI0nA040YdiXEzSjzM=; b=Vx+L4nvjYz6DpBpzcMVW54NGDIu5VsgRpXlH9M+6CjyfwjKQEhh/SKkwkZOuwoVIIc Qm90aTPN2fFe1kz+ASi+Glen1TrWf0SYya+guayJ70smdMJBVXrRkAHCgW2E/56jyFb5 LfnSyp0K0lBEnUtN6ePmMhmk82nBFPwWaNrpisS9gLYOhSysi4PVJbQJTwjNtlG9+hj+ KRAJqedJq9SeVv2x4YnGYLbqKgVMA74LPl5y4xBFmyxU9DuyAGqrs6svafSVlQvU/ExD NQxsRXKtP3c32bRNahOZHrgJYxs3aIQJ1HHj8/+zMgPzeeSMutS28wu2kM++1lP+yHGL NycQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704798452; x=1705403252; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ccAlD4oTijdmnTcuA0xM9VgEmKI0nA040YdiXEzSjzM=; b=DjDP3guZlW4oz1UXJgkf9qSb667mH2ZzfyKJAvabX7uKjgT7xKpGKvjgAdXfwNfbwn 4SgWgodu2F1N9E4R8n3it0bp7Ojt3IKdOeRBBF6mwSTgNwBois5uNg0SG7Y0+LYK9c4f sR3ulriTcyxmR3xTbmgxBwNUlzs1uSDbdyBN2txDtfFXXbO0nX07KYzy4rnoHFW+SOfK eBq4hyxCdIqW6yvBB00PAprMkpKrdH0vVXD+uaZIfTpWwm8UydGTexL7lu9/yKAk4umE Pra58+qAPRE5yb4zaItcAcPqp+JWDzeOwKKonHNYsE6Z7HDtS+KkyGWkrL0d9WiHbhA3 3S1A== X-Gm-Message-State: AOJu0YyFc8SM+2qawj3jP1kG2awcvcUjawkf9oNFPasBmRDfmHyW4zdr GIF5RGOvi9lSuVRloRTsjPLhxBdIrdan X-Google-Smtp-Source: AGHT+IEQGvRLacJjkX/or0clowNqVa568wpelr1a4tOn+tbJu5sATOZ0+eZAWx1fWH2A3PVgXU7LgA== X-Received: by 2002:a2e:9ccc:0:b0:2cd:23a7:a346 with SMTP id g12-20020a2e9ccc000000b002cd23a7a346mr2330818ljj.83.1704798452498; Tue, 09 Jan 2024 03:07:32 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id fi7-20020a056638630700b0046d177c2504sm566675jab.140.2024.01.09.03.07.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 03:07:32 -0800 (PST) Message-ID: Date: Tue, 9 Jan 2024 12:07:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: add missing APX logic to cpu_flags_match() Content-Language: en-US To: "Cui, Lili" Cc: "H.J. Lu" , Binutils References: <8662338c-e85a-4b84-a941-31170794dfe5@suse.com> <11d23d18-142c-4c32-bab2-6ddfd9257051@suse.com> <10f488d4-3a7b-49f4-b288-6486c42b5433@suse.com> <29e3e221-f23d-4433-8787-40a3f2141760@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09.01.2024 12:00, Cui, Lili wrote: >> Subject: Re: [PATCH] x86: add missing APX logic to cpu_flags_match() >> >> On 09.01.2024 06:36, Cui, Lili wrote: >>> By the way, I have a question about " t->cpu_any", is it specific to dual >> VEX/EVEX templates? >> >> No. And I think it's used elsewhere already - see e.g. SFENCE. >> > Oh, I get it. "any" means that any cpuid supports this instruction. It should be cleared for APX (Daul VEX/EVEX). IOW, "any" doesn't work with "cpuid&(cpuid|APX_F)". Well, in a way it does, as outlined in a comment: &(APX_F) (all.=true, any.apx_f=true, all other bits of any clear) simply is the same as &APX_F (all.=true + all.apx_f=true). The crucial part here is that "any" may not have any other bits set then (after the purging of the one one). And it was only while making the change that I noticed that doing things the way the patch is now doing them is overall more neat (with the same functional effect). As mentioned, we may still want to consider to simplify (or even purge) APX_F() as a result. Jan