From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2043.outbound.protection.outlook.com [40.107.22.43]) by sourceware.org (Postfix) with ESMTPS id A3A013857BAB for ; Thu, 11 Aug 2022 07:31:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3A013857BAB ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nQlsdNWq3peT42JtYXkbkQJj/TptnsxherHK0Wtp+MTa+RnjJAu5bg01WXnajLd180VK9aKbtOw/NQ111kU+T9lX4xkB/OGJB6cx6yUmeBcMMpEyuFv+cyvyyKstpMlxWmCYNJRbVLxGGiXAGBAPwtZc75FuywR4TfTqpcmpoAnuJGpY/bwy++2oBMiTYchjAqBv8a76+/Cg93J7x3MqS+tkyUNYK5kqU0xfa6LyQqqAHw2r9EquMJKM0Pl6hh39Wp6pECaMjTJjYPZmTLhtSKfX1+Iv/Jvo7Vu0ZowpXNuGgdx5yxdoS3nmauzfGPPJy+eZn/Zm8YbmbO73j87xiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqLbSXFJwEQvSxplCmvFUpsJxWibJVnccimIstptai4=; b=a4/zzh1nZBrW2qXvcoaScU/e3BInQnood0X6W9Z5b/hpSTUTuUJ0CYg//Vfah9VF1gkA25NJXDP7G9DMSZH5qH6ukpEjEgrKM0cSIc4Hjpf7dhd8/8hBMNiOVbarXFUZx5cS21k+oayhMhO2/BTRYlE2/7iKm7W3nd8j6KXmuX3Q3C9GfUmirEsDwYUNYLe6zvjAKAMpdgyMQhaF9rob8ielfaa3gyDnkBHsXnpTebBYS+sUzuB0Umt62AFma2hStdDmIGUecHzO5KsdzM28AoWTnVfMsvciTQ0RffdOF7ILI3rmPW3yl9JNBf2tbI4GTSrrJuThlk42cKGByDntTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6980.eurprd04.prod.outlook.com (2603:10a6:208:17e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Thu, 11 Aug 2022 07:31:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Thu, 11 Aug 2022 07:31:51 +0000 Message-ID: Date: Thu, 11 Aug 2022 09:31:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH 3/5] RISC-V: Mapping symbols with ISA string on assembler Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, Nelson Chu , Kito Cheng , Palmer Dabbelt References: <1659692183-5682-1-git-send-email-nelson.chu@sifive.com> <21270977a91ae08292727829cbee7ef230896d2f.1660201178.git.research_trasio@irq.a4lg.com> From: Jan Beulich In-Reply-To: <21270977a91ae08292727829cbee7ef230896d2f.1660201178.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8544e199-6321-49f4-d7a4-08da7b6b8e7e X-MS-TrafficTypeDiagnostic: AM0PR04MB6980:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C9rorquU4NGry8uVwc1Gs/+dA6PonaErqfZ7V2uCueyzNvB/8dGecK521sxx2QyuYEQXqyYPAspJoPbIdsfCO7QGZuw8czTJDEF1Q1xuY7c6eLnxt7yBYoEpwisMs+FWTKS5VXYTMoORs7+8MaNkjGdHtNCU9LlCA9ig8Gkn8dnsUXEtQ2zPeNd1WWSj6Ps9W+TML5ZLyehfWGnCm65CCfpEKs6YrQVZtd6zr2Y+0qnohSTaG4YG6mNRLCPjKncxaHnIfeqWkd3tW3rcupL/VWpZgRk1APmHhuz9EKcUhAy/+w0MSO3a7BxMfqHJ1vFznFtkyfNCp6BvB5dFVEnZ+FhGmlJOMlcGq0s8pboOlTrorSCrh3aRBiEZxc6kLJG3Z/qlYwZ5rnxC0ZkIhW76PXhacgLVtOH33M+NtRjmfssYBg9xHGU8urhYtY2R54Cdryi6K9ZWN0SWtBNg/mZC0TnNH2ogkw/d7onDTpYYMBKd6NcU9trxUXE4TdhMN6sz9J56aPxHB0RJd8vEmdBjAiSyMfJEJYd7/MAkKutYXJQNEL1QabWKe/TL5rW0pPfoBhat7/fPfe2YYAH7CAmaZmX1l7hiJh+y2nZ20FjrIMtTch+jlODTzpsy1CrTydVVSjbjL/ZbTKrtopJkrKDV8GSAhthJoc9HFbsminmPpFj8L/V+zQ/yqlSt5GeWBYnWy9EEtP5TEpYoywh0kTKum0+T0HPdTE5dRGIcbja87sKWNb0Ypzj+SyVXezAtPaUS+8ILfhu3T0NhaecwaQwuljNctXAovZW3d10Webhv79tkmI6mepXJ70MEo4dh96S+9AviEAVPSb5JhDizVaf1xw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(396003)(136003)(366004)(376002)(478600001)(5660300002)(6486002)(2906002)(66476007)(66946007)(66556008)(38100700002)(31686004)(8936002)(8676002)(26005)(6512007)(6506007)(36756003)(2616005)(186003)(86362001)(53546011)(41300700001)(54906003)(6916009)(316002)(4326008)(31696002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qm9ubHlOVklTa0p0SmdIWnRrL2dhckRCU3RSb01uWGpkVUx2RS9NV0lrZFda?= =?utf-8?B?ampUOWFJUFRiN1QwM3p2TUpiZldrdHgxbmRuRXl3YlUxelpTS25vYmhqeThx?= =?utf-8?B?c2YyL3dZOUxDTEZoWmZFNUtzRmNzeFBNaldXTWJEMXlmR1grbHhGTDd6ZXhJ?= =?utf-8?B?OGhJWXluajVnWHk1enRoWXVTVGpVRWlnaDVLcSsxWGZMMnViMFBDU2dVQVVy?= =?utf-8?B?dDdVRjcrS2x6ZzJ1ekZyNTdVZUJRdTdvNlV6Wk5QRHl6NC96dGRFT2NBODNJ?= =?utf-8?B?TGYvUDBXREFvSGZzVFYza3Y3YVRXK2gwUUZlbXJUTmxtWWI4aERBWTBhNXVJ?= =?utf-8?B?VTJXTUNQUVFueG12d2VpVmN2RmFKdWNpVXZoTG9VQjh2RXhGL0R2cWNFcGpj?= =?utf-8?B?cXIvcC9uSDF2OGRjZ1JjcnhPcGlUZVFCcUZ5NWlJb21Ra05pWWoyemRaWUkx?= =?utf-8?B?U08rbFFlU3NMdDhTeW9YS2lOU3NWWFJJUGRnRU1XSWNkRmNCZysrdmVrcEFP?= =?utf-8?B?RFBTd0dvbWkzMmJldHU5UGNJa3dKUmEyVGE1QmFuaDRidmordXJXKzg4aVh3?= =?utf-8?B?YlF6WVNoeEJTTUN0SmV5Snp0WXdHYmVobFczR1o4SHk2M2lxeGlFdzgvdUR4?= =?utf-8?B?cjdOZ2F5dkpvZXRaaFplSkxTb1ROdktwd25VOEZFMjVESEh0cGJJc0VLcHcr?= =?utf-8?B?YW82cUdpN3pUd3JmbTBFbCtWOVhkZStUUkhSUGdWL2NNZEhyM1RLMEtGZ3NW?= =?utf-8?B?Z3BqY2RNK09OejJNZm9UR21wREZ1VFFzZ0xhRFE2aStVVGJvZ2JpaUxDNThB?= =?utf-8?B?RXRTR1NlMDhsU2dHdmhlRHlsNkh1aU5acDFLd29UL3Rjc0FJaHk2akJQclZm?= =?utf-8?B?V3hQYzZOZFV2RGViUEFRd3phNWJHS3JPb2c4VEFVUFhySWtiWU02cXE5QUhj?= =?utf-8?B?aUplS01IUnVmU01kaVVPTWZqU1BGMU9JZ01xSWwzdkhRQXhXMS9uODBRMXNs?= =?utf-8?B?Q0NPb1ZTa3puV3lycllWVFRYeGdOZ2ZITDRTczRPQUNrNnNGMEM2QzBFSEtH?= =?utf-8?B?ZzRMWHhJVHlRZXk5YWlMV3dLQWdVWHFVOTB0VHd6Rml1cmcyN3psT0k1cHJ2?= =?utf-8?B?ZHcrZlFPU2ozSXd5STNzSGcxcGl6dDExSkJRM0g3UnIxVVl5Z3dGM0hBL1JZ?= =?utf-8?B?TUp6WUJyaU55Mm80WngybVhGYUdzbXlKbjVOdGtIYUt4NnUrb2syQXordTR3?= =?utf-8?B?UkZmRkpMTlZCaVdsSDBTS0F4NFhGM0EvZ3hZZUczSC9oWW9rQ3JyL3ZKMTJy?= =?utf-8?B?UG1TY041eG9JYjRIT3d0a0lzdnJsTTE2RnhLQWFxbFp2Qll4LzM1Q2I5UGJo?= =?utf-8?B?eG55aWNHZnVnMmZWbjhuZEVuSGFyUWpmeDBtRHpKSHluaXVFQTZBWFR2TThu?= =?utf-8?B?eVNaZWNVclgwUzM0RFdBMzlDTE56cEZVQ0RhVU16RUFqVkpSNGxLKzdQU3JK?= =?utf-8?B?bE5vVVh1bjhBWVNSUndrL2s1dm4wRG01ang5TnRtdWRxMzVwTks5OGtwaUpu?= =?utf-8?B?V21ScXRnV0ZoVlhLQTdLZDE5UlFYTVFCU1RtOUJxc0lYUFUra21DbXFqME5W?= =?utf-8?B?MWdpRU5IdEpLS2JFYjQ2ZEpVb2FDdm5NWGZoMUprell5Q1g5Smo2VzRwcGo2?= =?utf-8?B?YWZadE12ZXo3emtTQ3hEYXlyWHFocFhzbCtmb0duYi9NaDE0ZXNyaFd5M0Qw?= =?utf-8?B?ZklZcUJpS2FsM21wRnhSSXd2dGtYU0owbVJ5WEVDNWFMWWthME1tS0EzMk1v?= =?utf-8?B?QnhBZjlhczJXaFd2VHltU1hLWEM1UHBvY1lCZU1xZC9zNWh3OXZMZWcydHV5?= =?utf-8?B?RzBQczFOU0hhMWN6aCtpUzdyVlJjUWxMckxtS0hlRWpJZmlMUVNPQWY2ckli?= =?utf-8?B?RldJdExzaHhRUitiS3lKczB2Qm8rNWpINGNMMzFlcjNYeXpiK1NSS3ZHV2pL?= =?utf-8?B?cTJua21HZjhSS2tRYmZXZCtJSlE5Z0ZkcmExaGxsWkJTNCtTVVFwb3pqb3l1?= =?utf-8?B?Q2YzNDZJbzZZTGptdVgvSHVMTE9EbjIzUFdaaHEvblkvczFhZmVlOFhtM09D?= =?utf-8?Q?r9trdNopp1I8c0DeqvW+MB25d?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8544e199-6321-49f4-d7a4-08da7b6b8e7e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 07:31:50.9990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K1UhNwtIYwDhrS1RIOLM17U7a37BcOLWDrDO5anBPmThxyyH6NMjk+jR46qyz+UyehHSL7nujD+fg4TdE8gRqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6980 X-Spam-Status: No, score=-3030.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 07:31:55 -0000 On 11.08.2022 09:00, Tsukasa OI via Binutils wrote: > @@ -3855,11 +3887,15 @@ s_riscv_option (int x ATTRIBUTE_UNUSED) > if (strcmp (name, "rvc") == 0) > { > riscv_update_subset (&riscv_rps_as, "+c"); > + updated_riscv_subsets = true; > + riscv_opts.arch_is_default = false; > riscv_set_rvc (true); > } > else if (strcmp (name, "norvc") == 0) > { > riscv_update_subset (&riscv_rps_as, "-c"); > + updated_riscv_subsets = true; > + riscv_opts.arch_is_default = false; > riscv_set_rvc (false); > } > else if (strcmp (name, "pic") == 0) > @@ -3880,6 +3916,8 @@ s_riscv_option (int x ATTRIBUTE_UNUSED) > if (ISSPACE (*name) && *name != '\0') > name++; > riscv_update_subset (&riscv_rps_as, name); > + updated_riscv_subsets = true; > + riscv_opts.arch_is_default = false; Seeing that all three call sites of riscv_update_subset() gain the same extra code - wouldn't these assignments better move into that function? (The function living in bfd may make this difficult, but it being used by gas only suggests it might better be moved over. Or otherwise maybe add a local helper function doing all three things?) As to the resulting "suffix" to $x - is this then intended to be in strictly canonical form? > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -750,7 +750,7 @@ riscv_get_map_state (int n, > return false; > > name = bfd_asymbol_name(info->symtab[n]); > - if (strcmp (name, "$x") == 0) > + if (strncmp (name, "$x", 2) == 0) Nit: The assembler was switched to use startswith() in similar cases. Jan