From: Nick Clifton <nickc@redhat.com>
To: Mark Harmstone <mark@harmstone.com>, binutils@sourceware.org
Subject: Re: [PATCH] Add support for COFF secidx relocations
Date: Thu, 7 Apr 2022 14:49:50 +0100 [thread overview]
Message-ID: <c2364c90-eea0-b63e-1572-60efecde64f6@redhat.com> (raw)
In-Reply-To: <20220403220738.23108-1-mark@harmstone.com>
Hi Mark,
> Apologies in advance if I've done anything wrong here, this is my first
> substantive patch to binutils.
Well I am impressed - the patch worked flawlessly and the only thing I had
to change was a couple of very minor code formatting issues.
> I've been working on adding support for Microsoft's PDB debugging format
> to gcc and binutils, and this turned out to be a blocker. This adds
> support for the secidx relocation type in COFF files, which is a two-byte
> index for the section in which a symbol ends up. It also adds support for
> the .secidx pseudo-directive to generate this (the syntax of which is
> cribbed from llvm-mc, which supports this already).
Patch approved and applied.
Cheers
Nick
next prev parent reply other threads:[~2022-04-07 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 22:07 Mark Harmstone
2022-04-07 13:49 ` Nick Clifton [this message]
2022-04-04 11:44 Mark Harmstone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2364c90-eea0-b63e-1572-60efecde64f6@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).