From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C6E703858C50 for ; Thu, 7 Apr 2022 13:49:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C6E703858C50 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-505-0JUJeKNoPQ2SKt8cgdIPYA-1; Thu, 07 Apr 2022 09:49:54 -0400 X-MC-Unique: 0JUJeKNoPQ2SKt8cgdIPYA-1 Received: by mail-wm1-f72.google.com with SMTP id h18-20020a05600c351200b0038e82e6321bso1516934wmq.5 for ; Thu, 07 Apr 2022 06:49:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=eBVM/MYKRqq23OMveFeSHCH8qo++VPvZdXgdqkV5nV0=; b=hSdWpVyHy7fKpPkZIc0BW7FOmfABhp+fn4oLYt4oFFfcc3vnfnqxqGKVsK3ve40GQH 9WRq3n0shlFFukIYmDEYwbw7z2zNdWUQeDbvUM1fGUR/M8Kq47BESiYPHnvcfD/t3+Gh JKTt5U4jLTNieclJj/sAoekcBzM0uxbomI8Yn/VUtYcpLTaN13+DFVy/IfWgDKXz0Q2O KV0m+mwUKzjLQFrvKlPac9uWwSOk3YwXAgYWGcpdjUK1jcMhmx8o7h26wcDHJmrxjO9L 2nY10yH3jkuSOQqXeupQUVyn5QqhxEj2BdIcs6wW15nrJDgc1qjgdmmJSs4ggAqxbB0p Ie4Q== X-Gm-Message-State: AOAM531w0frdd3mXoMAjugaCdaQAdr1OyN1uQ4bz0mDnEf3G5U6EAK/d +emasANdnV6ABaAxhQmpL/PQijMWOLisqVTu0M0GTyqqvY3xruFTGLijf93xf02QFnP/n69ZEQI q+9KGL+xoJr8/To2IYA== X-Received: by 2002:a5d:6a8b:0:b0:206:ab4:7d09 with SMTP id s11-20020a5d6a8b000000b002060ab47d09mr11142759wru.396.1649339392990; Thu, 07 Apr 2022 06:49:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAegFpuQSXNMh5NDiwsGdR6OIgW8/0cJ9UxJ/tFgNdeymX596FXmtPRkRlCkxOUu3wQeAnpg== X-Received: by 2002:a5d:6a8b:0:b0:206:ab4:7d09 with SMTP id s11-20020a5d6a8b000000b002060ab47d09mr11142742wru.396.1649339392758; Thu, 07 Apr 2022 06:49:52 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id r12-20020adfdc8c000000b002060878f735sm13661702wrj.65.2022.04.07.06.49.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 06:49:52 -0700 (PDT) Message-ID: Date: Thu, 7 Apr 2022 14:49:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] Add support for COFF secidx relocations To: Mark Harmstone , binutils@sourceware.org References: <20220403220738.23108-1-mark@harmstone.com> From: Nick Clifton In-Reply-To: <20220403220738.23108-1-mark@harmstone.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 13:49:57 -0000 Hi Mark, > Apologies in advance if I've done anything wrong here, this is my first > substantive patch to binutils. Well I am impressed - the patch worked flawlessly and the only thing I had to change was a couple of very minor code formatting issues. > I've been working on adding support for Microsoft's PDB debugging format > to gcc and binutils, and this turned out to be a blocker. This adds > support for the secidx relocation type in COFF files, which is a two-byte > index for the section in which a symbol ends up. It also adds support for > the .secidx pseudo-directive to generate this (the syntax of which is > cribbed from llvm-mc, which supports this already). Patch approved and applied. Cheers Nick