From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id B9D60386F42C for ; Fri, 26 Apr 2024 10:37:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9D60386F42C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9D60386F42C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714127825; cv=none; b=GCMhZxuwZYSli1z3VosWg0NqX5AQRnIca2yc9asQmp5g9k5du/jWL319KQSQ0vyFfdPNiGj0u0qCYueExV7/6GHVR96C4PEiu9f2fnbijxA+FFYcSENIAPOPyGOXQXn6v/k5V0CZnMlvfc+t59tupWylbrCV/KOhuM15XmddsbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714127825; c=relaxed/simple; bh=UfP9TuXicQu6+htLsVgrbMF3Kq0HmdBlxxxskF77KGE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iiZhkZx1pNlSzq2KxjryCAJQhxao1RphyWCzVBzJHYQ3/t/T6ly14AGOqs/piMljlhJ4Sxyc4WgmMg9CyCzbwMc5zpeL/JuCV6sofroe6mn5ConIZka7TNDWoTMMv9D1U7rAmWnGnAW9z+5ZkKy4r7kLZhYZ4pQlkOv/+0swqFQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-572347c2c16so2506380a12.2 for ; Fri, 26 Apr 2024 03:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1714127822; x=1714732622; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/pggjF9p51d6ocbIcH2gqdntOnbuegvPg+xySpvBtsI=; b=PKQ89WHUAWx/kCQdW9XpqOwaf2buTZKXFs83MYnemIpYtQ0OxeMqkAjBwuYUiJOkyN a2z8R0h2mv0uuJt5Wf4X9mQTiYhQbNbHiCsItz958pAZv1shwA3B4WXfftqaeKwOvino UZMOfhQ3ipTE1zb2X9sE8TVdL2wtsnPb3D2GYKIWFgl6gpavNpWvCsNF8gxl6vbjDfGb /YKF2uoR4DkUBhWXarpb/yRev8T9OW1nIXQmcNkwZY83bvRwMMKa4oFELzwuuy7L7D3+ 6maAKAkce1BezETpZ3z0OZlAfpe5b36GVnGsv47tTFAA+1+qxGetjn5e1LjI5TKAvJhg KUKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714127822; x=1714732622; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/pggjF9p51d6ocbIcH2gqdntOnbuegvPg+xySpvBtsI=; b=J0PwGJXLbTP0lS6Qc1ZBv6n8KU9VTTbFgYCS/xZf9HZ2GWs7AB3+IU38qQz0fTpq0e +Lml9JX+6TwXzC4Ngu4vNIqkparVMrXnHqDvArPq0fOt7yH7meCgflbx2AWeJy2WxKkL H2Cv3xB0ENfFUL+onFOYdXKW/shFkvKJkc2HPRU1/EKkMYmBDuV5DMHbtqO4jZY8M7P1 YtRD3Vp3eL4SUClyOkj3hS5bDHv3r+LRVQrREi5jH4j0rgG3Fu1mnZuGxIhr6q4ACMSs pPxa1XsptrzliQAQWh0oucrGgREjfQRhes0ANKRRwmjwlKrH1IUF+Upif2uG7qZuv69+ MXbg== X-Forwarded-Encrypted: i=1; AJvYcCXScLpRgPXxUyVNJZuMeyQmdJ239b8kW19PxISURoRS05+lmtK0wHQref9oo1qmniCgMUcjAO5UaIj/X4ENaqVIkm2xP9J0sA== X-Gm-Message-State: AOJu0Yxw2cO8TX3kTKtmpj9+1TpF/uoCW5g673E5M8ikYJEPQ8a/AEJ+ icBfwN40KPT6RBiat1zEmjqMkVKxCjh4C4MuJVPqhvJ7nfpzotOdtVYvN+gCD73e0v7H5vvUNVk = X-Google-Smtp-Source: AGHT+IGbxdW+wofFeMMIQU1dwo+R0LI0Ou+horD5z6b/QC9e9OsBueCpChLjy+xLCKO0DJKvrP184A== X-Received: by 2002:a17:906:249b:b0:a52:33b0:fcb1 with SMTP id e27-20020a170906249b00b00a5233b0fcb1mr1609919ejb.32.1714127822305; Fri, 26 Apr 2024 03:37:02 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id c19-20020a170906155300b00a526a99ccecsm10395940ejd.42.2024.04.26.03.37.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 03:37:02 -0700 (PDT) Message-ID: Date: Fri, 26 Apr 2024 12:37:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] x86: Drop SwapSources To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20240424072356.2433122-1-lili.cui@intel.com> <20240424072356.2433122-3-lili.cui@intel.com> <8549a5b2-d8b1-451e-90c1-74ee29dadf3a@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.04.2024 10:14, Cui, Lili wrote: >> On 24.04.2024 09:23, Cui, Lili wrote: >>> --- a/gas/config/tc-i386.c >>> +++ b/gas/config/tc-i386.c >>> @@ -10434,6 +10434,14 @@ build_modrm_byte (void) >>> >>> switch (i.tm.opcode_modifier.vexvvvv) >>> { >>> + case VexVVVV_SRC2: >>> + if (source != op) >>> + { >>> + v = source++; >>> + break; >>> + } >>> + /* For XOP: vpshl* and vpsha*. */ >>> + /* Fall through. */ >>> case VexVVVV_SRC1: >> >> This falling-through is odd and hence needs a better comment (then also >> covering vprot*, which afaict is similarly affected). The reason for this is the >> XOP.W-controlled operand swapping, if I'm not mistaken? In which case >> perhaps instead of the fall-through here the logic swapping the operands >> should replace VexVVVV_SRC2 by VexVVVV_SRC1? >> > > Yes, vprot* should be included, and it is related to XOP.W-controlled operand swapping, the comments says " /* Only the first two register operands need reversing, alongside flipping VEX.W. */ ", But there is actually a memory operand, not two register operands. > > I think VexVVVV_SRC2 makes more sense here, it matches the actual situation, we want to use vvvv to encode the first operand. > > Opcode table: > vprot, 0x90 | , XOP, D|Modrm|Vex128|SpaceXOP09|VexVVVV_Src2|VexW0|NoSuf, { RegXMM, RegXMM|Unspecified|BaseIndex, RegXMM } > > testcase: > vprotb (%rax),%xmm12,%xmm15 > vprotb %xmm15,(%r12),%xmm0 VexVVVV_Src2 is appropriate for the latter, yes, but not for the former. That uses VexVVVV_Src1 layout. Hence my suggestion to replace the attribute when swapping operands. Jan