From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32962 invoked by alias); 13 Feb 2020 14:19:42 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 32943 invoked by uid 89); 13 Feb 2020 14:19:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:83imkbq, H*MI:sk:83imkbq, H*i:sk:83imkbq X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 14:19:39 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 01DEJU5p016245 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2020 09:19:35 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 01DEJU5p016245 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1581603576; bh=F9OW9hgLBsce/YgjxpoAn8j+B+9BhUivu17+0bdwNCk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=bjiVcBCJn7csG4HucMMJbfsOfc8tAXxOhp/YlOzfL7uHX/3A7x5kQdN5vwwHDPg6s urUUKJ+nkslXjPV2yu6xIVsa+Lebi2zQsAddaG87mILEEbjnWEsPT/IMqlwsvP1YdV RhzPQY0SsFIoKCHUjtNIQak3U52jLSYAOsKnBeDE= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4A4141E4C2; Thu, 13 Feb 2020 09:19:29 -0500 (EST) Subject: Re: Using the vcs_to_changelog.py script To: Eli Zaretskii Cc: binutils@sourceware.org, gdb-patches@sourceware.org References: <83imkbqhry.fsf@gnu.org> From: Simon Marchi Message-ID: Date: Thu, 13 Feb 2020 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <83imkbqhry.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00267.txt.bz2 On 2020-02-12 10:37 p.m., Eli Zaretskii wrote: > Several things we'd need to consider if we go this way: > > . AFAIK, the script you mention currently supports only C sources; > we'd need to see how well it supports C++ We'll see. The script is not perfect for C (it would be nearly impossible for a script to be as good as a human to generate these entries), so it won't be for C++ either. We can of course improve it as we go. For simpler changes, it seems fine, but for example we can see that it got confused for this change here: 2020-02-12 Tom Tromey COMMIT: 219823045622bd111d68b984e31aa7b1712d5e10 Remove the objfile backlink from comp_unit * gdb/dwarf2/frame.c: Modified. [GDB_SELF_TEST](execute_cfa_program_test): Modified function. (comp_unit): Modified. (execute_cfa_program): Modified function. (while): Modified function. (execute_cfa_program): Modified. (execute_cfa_program): Modified. (execute_cfa_program): Modified. (if): Modified function. (execute_cfa_program): Modified. > . Some files in our tree are neither C++ nor C: there are Python > files, Guile files, shell scripts, and Texinfo files, to mention > just a few: what to do about them? I presume glibc is in the same situation... The script just says that the file is modified. If we wanted to get more details for them, we would have to implement new parsers to figure out what changed between two revisions. > . Last, but not least: we'd need detailed instructions for how to > produce the commit log messages under this regime, because the old > conventions will not be valid anymore. What are you specifically referring to? For GDB, I don't really see what would need to change. We already enforce having detailed commit logs that explain: - the rationale for the change - technical details about the fix, if not trivial So the only difference is that we would not provide a manual ChangeLog entry. Simon