From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 432713858401 for ; Wed, 10 Aug 2022 15:32:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 432713858401 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-sYqNFUrzO86tjioTDi8uaw-1; Wed, 10 Aug 2022 11:32:24 -0400 X-MC-Unique: sYqNFUrzO86tjioTDi8uaw-1 Received: by mail-wm1-f69.google.com with SMTP id z11-20020a05600c0a0b00b003a043991610so732662wmp.8 for ; Wed, 10 Aug 2022 08:32:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=lFXNDy46wgHiD4eFEK0BHD193IBGODYPvc1OCc3UPQU=; b=WsKhviYG8w3KpmJwiU1EBsoNUrywVJjjtz9I02a8ZbvhTg34TXrPVzdBMIHzUDGFdO INN1RVWRdfWEO0q5YzO+67n3xuIodi+n2s3oXFgETJbHHCsN4Jm/6FEcuVxAzDXIy/Re DfSjm1EWyWCtBK/6sMybDq/zqDg0jzAvnfYeuXltK4DIjlQMZAjcXysmm8tZBTJ4FPOx lPea8nXVM0cF6mri26hFtd5jGS7kYGW2lHvaW7eRZZXRi+InPB3jzbwlkgfXAQdwyxGn fpXGYNmn3tO8ieLvm1uYqdc0XsyMXgfsOM1HlMonABMJi0/N/KuOUPjBftV/4j2WXR11 i0gg== X-Gm-Message-State: ACgBeo3hwPTPCPPimaM9hyZk/D4h8wCy1xoW5TdYAEcGNEcGLy6JOfa0 P2y1LVp/sG7J4ng9OJaoKIO7eWapWLsvRYCTiq/r8pzpRrK1neHnyoilgev9xbQjvawFhmzIyFR GSp0Fj8n3G6XwYyN1vQ== X-Received: by 2002:a5d:6dc6:0:b0:21e:a87c:91bc with SMTP id d6-20020a5d6dc6000000b0021ea87c91bcmr17385423wrz.165.1660145543555; Wed, 10 Aug 2022 08:32:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR63wceETj1XWxQOUkmvmq8QWEiEEAAHjP60rZwDPiEWDaK6tbo8/gWrORho5Iu9ju7qHrC0VQ== X-Received: by 2002:a5d:6dc6:0:b0:21e:a87c:91bc with SMTP id d6-20020a5d6dc6000000b0021ea87c91bcmr17385395wrz.165.1660145543146; Wed, 10 Aug 2022 08:32:23 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id x17-20020adfec11000000b0021ee0e233d9sm16325928wrn.96.2022.08.10.08.32.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 08:32:22 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 16:32:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/3] objdump: fix extended (256) disassembler colors To: Andrew Burgess , binutils@sourceware.org References: <091335e069804270ba8d9e217285c70743100603.1660139020.git.aburgess@redhat.com> From: Nick Clifton In-Reply-To: <091335e069804270ba8d9e217285c70743100603.1660139020.git.aburgess@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 15:32:27 -0000 Hi Andrew, > PR 29457 > * objdump (objdump_styled_sprintf): Check disassembler_color > against an enum value, don't treat it as a bool. Doh - sorry for missing this. Patch approved - please apply. Cheers Nick