public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Tom de Vries <tdevries@suse.de>, Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] include: Declare getopt function on old GNU libc
Date: Thu, 13 Oct 2022 12:59:19 +0100	[thread overview]
Message-ID: <c4a6ac40-84b3-4b2d-25b9-c5207bfb3f7c@palves.net> (raw)
In-Reply-To: <8ab93d7a617ad480dd786210f46db0e5aa07d1ac.1665655719.git.research_trasio@irq.a4lg.com>

On 2022-10-13 11:11 a.m., Tsukasa OI via Binutils wrote:
> On GNU libc <= 2.25, <unistd.h> includes <getopt.h> with __need_getopt macro
> defined.  That <getopt.h> is intended to be a part of GNU libc but
> <unistd.h> actually includes include/getopt.h in this project.

Messy.

Do we really still need this getopt.h header?

gnulib, at:

 https://www.gnu.org/software/gnulib/manual/html_node/getopt_002eh.html

says:

  "This header file is missing on some platforms: AIX 5.1, HP-UX 11, MSVC 14."

AIX 5.1 is from 2001.
HP-UX 11 is from 1997.
We don't support building with MSVC AFAIK.

Can't we just get rid of it?

  reply	other threads:[~2022-10-13 11:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1664095312.git.research_trasio@irq.a4lg.com>
     [not found] ` <cover.1665038297.git.research_trasio@irq.a4lg.com>
     [not found]   ` <a57b2a3460064a9adc95914ba21214c8dbfc2bbf.1665038297.git.research_trasio@irq.a4lg.com>
     [not found]     ` <7b235ccb-ab2e-cba0-3015-2eae5fe6a8a4@suse.de>
2022-10-13  9:50       ` [PATCH v3 4/5] sim: Check known getopt definition existence Tsukasa OI
2022-10-13 10:11         ` [PATCH] include: Declare getopt function on old GNU libc Tsukasa OI
2022-10-13 11:59           ` Pedro Alves [this message]
2022-10-16 13:12             ` Tsukasa OI
2022-10-17 11:52               ` Pedro Alves
2022-10-18 11:33                 ` Tsukasa OI
2022-10-13 12:05           ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4a6ac40-84b3-4b2d-25b9-c5207bfb3f7c@palves.net \
    --to=pedro@palves.net \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    --cc=research_trasio@irq.a4lg.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).