From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B0BC338582A1 for ; Thu, 28 Sep 2023 15:01:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0BC338582A1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695913292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DnZcP6+6g5XJQSeCWghsxl8zSzbC6ni2ABFIj0iaPHs=; b=RbE7g8NUc5gisRNZmLkFQej8TBXAXoArH3wLEYKNXtEo0iJH3aT7EReTWGcrU0rj6QOTI7 RCG5xl5mMKPbFCEkH9uoWfmv7J8hjaGQxLVqrUQlxnQ8PBcm4kj7/Te5pjBdgyArd6uJ3l 5y0m0SsILwfPXKH6mgdFRDEeb3G3LlQ= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-ubmx2rMHNc-pNv4ha8gWbg-1; Thu, 28 Sep 2023 11:01:31 -0400 X-MC-Unique: ubmx2rMHNc-pNv4ha8gWbg-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-77407e21d49so2148778685a.0 for ; Thu, 28 Sep 2023 08:01:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695913289; x=1696518089; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DnZcP6+6g5XJQSeCWghsxl8zSzbC6ni2ABFIj0iaPHs=; b=fWyXVlZ0ZhymZgduF6FvhfwN9gk9j8Gaoq78soMtEk/0it58MNZKEB7e9/ZRg2sVUC iaKEUa47uPHycJilUy0dpHW+ScctLoV+Gokej+0Zt1uMBNE4StKQbmBAQXZ98GPWR4hp kmu9qpVIMNqzNahDGabUsA/1A2oX8VFVFQ4cB+EiXdZK0roSd6yZiNwBuPYsEqRvCBKq OMjev+ZQ6YhOufV1QDItbbjEXk3GeLNcWMi6Qmwv99lQjGb9cQvxktMRySm7gaVa25Km Zo+tE9eV2SpKkj9EWV/6hcPkau4gzNQOT/6YOEaPOTOtAVBQ+ccQ4BHjSP4cyXJKgRPj PzpQ== X-Gm-Message-State: AOJu0YxeE8hlW670hYcuiDvJkkjSH35vxqgrdswirL40Mc+bDKRGallj YOIn1lUGMiYWGhDPKQLA7QiYyZ+GjULfIXJGLjWNGNjQKKTsK0eNZtpOgqww9o2wTDJDJf63YUz MuLlZ54WFo/PVuQsZYnYTexXRjQ== X-Received: by 2002:a05:620a:a96:b0:774:19cf:f3e3 with SMTP id v22-20020a05620a0a9600b0077419cff3e3mr1349340qkg.76.1695913289157; Thu, 28 Sep 2023 08:01:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaAX3QyL8Ub3OcFuRpLkd8VDCTQob4Jq+BkmE1r8qNWeUHs5BveBTNrrNA2qFX8IPz5HFmVA== X-Received: by 2002:a05:620a:a96:b0:774:19cf:f3e3 with SMTP id v22-20020a05620a0a9600b0077419cff3e3mr1349286qkg.76.1695913288447; Thu, 28 Sep 2023 08:01:28 -0700 (PDT) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id o14-20020a05620a110e00b0077402573fb4sm6218479qkk.124.2023.09.28.08.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 08:01:28 -0700 (PDT) Message-ID: Date: Thu, 28 Sep 2023 16:01:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH,RFC 0/9] SCFI implementation in GNU assembler To: Indu Bhagat , binutils@sourceware.org References: <20230920230401.1739139-1-indu.bhagat@oracle.com> From: Nick Clifton In-Reply-To: <20230920230401.1739139-1-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Indu, > This is an RFC patch series for the implementation in GNU assembler to > synthesize CFI, a.k.a. SCFI, for hand-written asm. Overall I would say that this patch series is excellent. I have posted a few minor comments about specific items in the series, but as a whole I would be happy to accept the patch series as-is. I would recommend holding off on adding the support for inline assembler for now. Get the basic framework into the source tree, wait for any fallout, and then when everything is settled, start extending the code. Cheers Nick