From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 0C7313858D20 for ; Thu, 28 Mar 2024 16:26:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C7313858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C7313858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711643172; cv=pass; b=cE9JmN2HZLo2jbgirxbZneR+Q92nRUJqFwexjPlr1QtTXgGZMNz0MWyiytbGaus1Fs2Y3soB9eZQbqlK6yjyuUd85AqEFLau6jbaGkEMKdCejmygwrbZTzAo/x+FzqFURcJi51D48sH9aScHZQEVpCUPaOJ0xZfFsjLc0J90tV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711643172; c=relaxed/simple; bh=MzzZdVPpUlqQq5LipZsKeUTnHtS2wGTEaxx9H9Dt99s=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=F2e0c2CTXJCDjv9N3nzZ5iyanO57uQzgGSPcJAR0verVgm+lipA4v5PN8+SoqlxUY9+U60uWOvjp2oAVJY8QYqelWJJPKGXzPFH+BM0eBDTm8HgCrnvpBEUY7ZzgWmNyIHrnSS/g8kIWrLNi5WTKZDmYMy97u00nBhY1VB3Ifbs= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42SFP5Aq010488; Thu, 28 Mar 2024 16:26:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=JZpVk81iiNSjNKQWOSWM0SHG1i5FYNYq4E6O8P3H/7k=; b=CICUM1F9LHIAmst047EuIk8BR2cgr2OZorqrcXb7bsaqsPB1ex0qRqIdJ9hFdlUJpXqq RpNyBrTfwhcC4u2pL3sToATpNj9SqZPiCfKBSb8Pgq+6G+OCLMEImpR0jJHE94DdhRTd 1MSulfhcB0gef/o/xM27G2SaAJHN4ZpjwkmCMOacUPLvvhg3hhSJObgjDdE5XfWmuEUx ZtsTMrbgeQD6Q5nb+M7OXXKmRSqxKlFACRyCRLFBYD5VoPIRz2lXl/Hi10nzp/UZm5sw +CrNy06FBMNEZWJcIt6CUCYhTvXvLdCPpgriN2vLHYnQtwtPIUjVdBbvdfms3ZA6QhCV Lw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3x2f6h8wfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2024 16:26:10 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42SGNmkn014479; Thu, 28 Mar 2024 16:26:09 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3x1nha7ys1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Mar 2024 16:26:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6STGFB+SZ9Uh7rFdp2xdNVsD9gd3rx96lgRIG2HevZDOgrq/jEAcfe7FGrdrJ7CEhSOMoYZbG7Ie3nUYC1wL17f/1cyfBxgwHi0qED3f2/VI8SOortahD/gwvuMLyDrpKGYCJ2XrDyxRmRW30vRmN0nBpYMEreHp2O0xM9pZZSLouhWlrEZwnLsPxD+oJSISwLCb1vZ8rIySdiuYcj3/TWscyZ4zPZPMCpxNEgHCNjya5sm4lBQHFf3+vvOqU+jZaLazhgXPeiK47zeM0ijg5lO0IwyadWPCUAL8l3F1rzcYct5Fh7mPzgjQO5udw5JIRTxJoDOftL+ilXSSP2prg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JZpVk81iiNSjNKQWOSWM0SHG1i5FYNYq4E6O8P3H/7k=; b=WK8JAzo2Ec/6OtIL7lbt7eHMdla5XATyozmjGMmYIdqRVfgduBB5wthNl8uJdhip7SUps5d1TMxaHrQz9JMjwRFWLhnHrGpPPAaeiTDA/rTLwAZfpfhhgOLyf3ghwFIeYtPa0fKB8Q1UrRQp5H4w5u/g3FMxYpNRCGbG2yVu7Mqb3Jn27Mvv04fFJ95oPZ9DLUQ9eCI6yT15W6ebZTXXFi0FKSYFG+oakxjqHDowU6kFYSOZj2WIWDecFZupyyy6pNmrgo3/3wOhcVPM0ATStfWx1+NoaH0P/PSi/qD24ggZjWnaMtS31sqoL61PAoSrqiyCvMM3wD4KoOn/JAEQtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JZpVk81iiNSjNKQWOSWM0SHG1i5FYNYq4E6O8P3H/7k=; b=OadDsXM9IwSVzkTNHgmgaqx1lBDmkPZjrxrHk9WU81YP9C39b84QnCzyzgrE2//OYkXfyAaZj2UHL6N0qP1fP6rFM9JNAkTnwDFGM7Kza1Rb38XyslI3FgoLiUoGHdlrq30rKgqdTIY+xAaBsMrB0S7kv/Fy9alBs+Ms6tF0KXg= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB7025.namprd10.prod.outlook.com (2603:10b6:510:283::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.39; Thu, 28 Mar 2024 16:26:08 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6ae9:dd4d:17bc:4f2]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6ae9:dd4d:17bc:4f2%7]) with mapi id 15.20.7409.031; Thu, 28 Mar 2024 16:26:08 +0000 Message-ID: Date: Thu, 28 Mar 2024 09:26:05 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V2] gas: gcfg: fix handling of non-local direct jmps in gcfg Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20240328075909.4134867-1-indu.bhagat@oracle.com> <4d4ea89d-09b4-487d-8507-4a7ed3a6fdf4@suse.com> From: Indu Bhagat In-Reply-To: <4d4ea89d-09b4-487d-8507-4a7ed3a6fdf4@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P221CA0027.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::32) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB7025:EE_ X-MS-Office365-Filtering-Correlation-Id: 78d2552d-da4d-489c-2399-08dc4f43c5b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k/+oU+H4n+ltIMqgpHFa5T0LrahvaFRv4U6cJ3/IG9+AaofDCkK5LQkZIEN8UDx72m84Hsz6+/zTXj56UsdqsSkVP1l0vwhuddwykxIk75GIE/yfEjOeAwPxsiFikkteh0XVQrLTZwh3dXHM6fGfziEMWaqjSozXKdOWCVuAgjTIPW6dv8Ynwk841IVEASwV9TlgUMF/pSnBlmuFOY4AJMtjFy8tXWHPXVUiEsxEhPMkVOr4qJ4ak8SCUG+nmSwjIDvMayEMnvWoKFllQTxe0R4h2IBI2/8dY5z/2uOESC3g6lDzh7QG/bgtkRRbZiocl6LC+Y3TXvE/FgI33FOGbLSLMT74UEtojpXhf2rHWW0J6u0ot4UUvHXTmYHRS3KKbpSlzCgiZMb7UZ3Dztn7JurNiJ1RCGGQEpsf/SMKQkBwMIY7qmfF3xIRDHfe8V/B/ZIywmFRjFoo59hg4OoafWtu9nlzV61tXjI1UUqbDf9xoqhcLVFDdpmeori1yvCWlQkFgBoD3ri0LO3d/3HLT2lNfVBIdYtLdOuDmBMXTa0GFGHnvfRSyrQ3mxPN5C87ZApE3loAtT2EVDYaDynPAfwpvb0rPOQ0JAaGn0xisc/9ltA4zVflWY2MudFMorR1ESHcYbSAcxVCbxYfgrndQCXUrbfPgviB+xv6Tyq9jGA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDBSazQrV1cyR2RuUExEdEs3TncybzBvQkFuVWRSV1Q2bEY1OHZ3djZ3L01K?= =?utf-8?B?NnhQTDRTTXR5Q3h3cWJCZ2p4bFFVQjJIdzlCaXVmZGFlOVlLUVN2S1FKZ28w?= =?utf-8?B?T215R0VJNk1mRnJCQVdLMTBvS05adTAvZ1ZDVU1sdnRoR0hsTWF2dnltUlF1?= =?utf-8?B?UmUrNzh0eTBHWnBYd1ArbzVnVzRCQXA4Ykl1SWcwb3N1N2ZmTFNqUENBVjFS?= =?utf-8?B?NFlUVmdkZUxMelRWYkgra0k4d2pza2swRVJwVWZNVmtQaGovL05qb1ZBT3dw?= =?utf-8?B?MFZlODJjQ2VLc0puVVdham1aZUp3elAvc0l0UGZUUkFFUVRBU1J0Qjh1bkZG?= =?utf-8?B?aEhVRjJNbG9XV0Yxa05YVzlWNkVKRHpWSU8wV080czVTQ0hWM3dxRkV1NDdu?= =?utf-8?B?UHo3Q3A1WkVoa3h4M2pJVWFhZGdUdXRGWVBScWNtR3ZZa1hidHd3bHltUWhX?= =?utf-8?B?NzNxenNIUEsyelEwY0pJSWlWMmUyd1ZBSE9ZcmRsT3p3YmxLY2lmOVJGb2wx?= =?utf-8?B?Wnk5V2poWGRmOEZIT3IrcythRkR2RFBHbGkwdWlITFVDQ3FaR3FLTHpaRkFJ?= =?utf-8?B?WitvVHFwWmUyZnFYUE1XTzJHL2V0STJWOGVzaWZVcCsvK3RtYTAySlRkQ1Nz?= =?utf-8?B?ZnV5NmxNN2dZalJLREdSWjIrL2tkdS9CUmttR2M2NEZvckRsbjhWelVYYjla?= =?utf-8?B?TVR4TjVCQURCYjNLWG0zdHo3eEQrWWdrek9UZHcxdHVhOEtGdCtIOFdsZk9T?= =?utf-8?B?VG1CeHdNdjhmSGp0WU01WXlraXdDZG1MNWRya2FtYWdDbWswTGpTS3M3VU9s?= =?utf-8?B?YXQ5QlJGMmNxTktwaEd3ellsU2l4VnU2N3FRLzRiVEdjWXVWSVQwTUMvNTFx?= =?utf-8?B?NTZoaDlEZm9PSTJsRTlHR25CMUp6ZDRXZHBRUVlWMlpzT1d2WDluNkYwQ1lr?= =?utf-8?B?ZGFoRGQwRkhpTDU4ZDc5TXhMT0wrblpjS3g1ZWFWMWFBenorcFJyWEVObTdR?= =?utf-8?B?UVlDL2F5RTFEY2xqckhsUzdHTHFTZWlyK1JJN3pNVjNDczhhQzNKYlZWSCty?= =?utf-8?B?WmREUWZBd3BzM1lSNFhlQTY0Qy81bG9kSkR3UUdNdGZFSG4vWHYwbjJsZ1BH?= =?utf-8?B?bStPV21tTFpLOHVxNDg4aEtsMFNPRmNuNzhCcHVtWmJ6Vkc5L3RoMHR6SFF0?= =?utf-8?B?WENLZUpaSnBlZ0NoRFBLRDROQVNsTWpQMFp2TDdzSEp0cGd2VHBLSzBDU2xt?= =?utf-8?B?SDJGbmFqZEQwY1dscjVpeEE2WXg5TWY4WkJMNFhuTHJJeUZ5bUVYZHdwaHNB?= =?utf-8?B?NE5yY2RTaHFuVVpRamw5bWNJbGZOY2NHQ0JleXNVY3NEVTgwbCtBdzRUU1du?= =?utf-8?B?cTlKZkNTNlkwamZPQkE2cUQ3US9RQ3NOQjJBWCtXeHROaDBKa0gwekZQbGNV?= =?utf-8?B?R25lR0lWakNkVS85a0JudnoxaGN2eWtmQ0hndE5ENkFjaTdRalFUTk9yWDFi?= =?utf-8?B?UzBDYVY5aEkvUWxhVDQ5WWxIT2RLNW80NHA0QTdUSnlleCtZbDVHMFkyZ0tk?= =?utf-8?B?cFNOSTZWMmpTQXRZTFVBc09CUXhyMVFMRlFPbWZKRjBDbGRydlpSMk1rRG1l?= =?utf-8?B?ekIxb0lWT0pmcHhma09XTDh0Ukl2YlpkQ3o1NVVBTFpDa21VdHphMnNvTVdH?= =?utf-8?B?Ui9zMzc4ZVo1cjFiSkptaGw5aDdMZGduRmUrWGc4Nmo4d0FrNnMvLzcvT01t?= =?utf-8?B?QTl3bWxKMmVpRVp0VE9aVElUTm1ySGtEM0FicWxMdjJ0eXdPTkZiRWcvYzhO?= =?utf-8?B?OHA0alZwZllTSExlSzkyT21sY1JEc2FiaUo2RmllT1JhMHJoTU5mNmFCSlk2?= =?utf-8?B?UXNKNlljS0E5ckxRbXRnczdubzhiREltbkdpRDh6SWtpSXNmSk9NcE5CYzBi?= =?utf-8?B?K1pKZFk3bjNBdmV4ZGt2S3lnNHg0OWZVNHhUa0piZVVlRlZ6NGQ1cGE3ZjhC?= =?utf-8?B?VXBsU1JYelg4NElFaUV0ZWNubjhONXRaeWtpOVI0dnh2K2F0MnR4d3ZnMWFt?= =?utf-8?B?akoreldZRVJJOVNhSEJsL0hxNVI1Z2xpbFRFNEZZYjVWcERQeGpXVU1LeWlh?= =?utf-8?B?SmYrRFI2d2dQaHV3aTBCYzZzb2UxdUozS2Q3UHljelNqUnZDSUhURFNRY1N0?= =?utf-8?Q?wW0P6uHOPeQILFcXq3DAwBE=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LsjuQYuEgFQEs72SbK51HhFYDodO9nghxpQRxkyxx5eANi+Xums8YSyKofAC31zusIk96D+kkQoprSrQf2lnYAMtirfUurexwdzdmgvLQKSjzBNpakBT0tkRvD8a9YHOr6zSEyuvagV+q9q3QElaX6jrYO9dPO928jGTeJiivJBmCjfktVS7TKjM7hxhDbdEmy2rpKno8KA3rdoF+OuyVIUwvh7U/XYlccRYGwqzYrGtemvXMhcf7ts96VvpRrbKQoSYPahLZ2QdWsg6dKXS4wKf2MmgREfWM7YzkUE0czfIHBN9WXm64ht4O6+Km6a1kM/FM+H9J8Voa9tddal2Q2Oj2iQZr+1rehBU/EQ0EPkW4jagBHT6x1fqae/wH/nm/lwqL3h35ECTDePMDXfRGywJngfqQBefMsOHlN0F4GueBOZH3tXaiZQt9LNEoIrGBSV3/t3ePGxLQwaRxBXRCYa7KaKT5fq3EDc8loioFd4Go0hgNvMAT23lGQ4vBaTLAejvHMztZ3an5SpdZQNc5av2vSDbV3mxbnXPbNgpsYIBNolfBn42Pahc8MaF0eF4k0UB60ZpU6ssRbmPHFqVP+bzhwaYijMkmo3It3FYuEI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78d2552d-da4d-489c-2399-08dc4f43c5b5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 16:26:07.9599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AbBCzZhwObOGfioJHUOSqKKh57nI1rQCJMkbS0mgEuPoagt9M/N9doP6nk8kUUp7jtopTCbMtr9HxzT5ttbAHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7025 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-28_15,2024-03-28_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 phishscore=0 mlxscore=0 mlxlogscore=985 spamscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403210000 definitions=main-2403280112 X-Proofpoint-GUID: aCiU51P4Ht_Bys0iIadtaFP90aE2XiRb X-Proofpoint-ORIG-GUID: aCiU51P4Ht_Bys0iIadtaFP90aE2XiRb X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/28/24 03:10, Jan Beulich wrote: > On 28.03.2024 08:59, Indu Bhagat wrote: >> [Changes in V2] >> - Add function level comments for ginsn_direct_local_jump_p. >> - Add a jmp to locally defined label in the testcase to make it more >> complete. Also, add a jmp to label defined in another function. >> The testcase now generates an additional warning (as expected): >> "Warning: GINSN: found unreachable code in func 'bar'" > > For this - can't you simply omit the unreachable pair of insns? > We do omit those instructions from GCFG and SCFI. GAS does, however, warn for now. Do you mean skip this warning too? > Other than that, looks plausible, so feel free to put in. > >> - Use formatting style consistent with other testcases. >> [End of changes in V2] > > As a minor remark, this entire section would better go ... > Yes, I usually get rid of this before committing. But I agree, its better put below after the separator. >> The ginsn infrastructure in GAS includes the ability to create a GCFG >> (ginsn CFG). A GCFG is currently used for SCFI passes. >> >> This patch fixes the following invalid assumptions / code blocks: >> - The function ginsn_direct_local_jump_p () was erroneously _not_ >> checking whether the symbol is locally defined (i.e., within the >> scope of the code block for which GCFG is desired). Fix the code >> to do so. >> - Similarly, the GCFG creation code, in gcfg_build () itself had an >> assumption that a GINSN_TYPE_JUMP to a non-local symbol will not be >> seen. The latter can indeed be seen, and in fact, needs to be treated >> the same way as an exit from the function in terms of control-flow. >> >> gas/ >> * ginsn.c (ginsn_direct_local_jump_p): Check if the symbol >> is local to the code block or function being assembled. >> (add_bb_at_ginsn): Remove buggy assumption. >> (frch_ginsn_data_append): Direct jmps do not disqualify a stream >> of ginsns from GCFG creation. >> >> gas/testsuite/ >> * gas/scfi/x86_64/scfi-cfg-3.d: New test. >> * gas/scfi/x86_64/scfi-cfg-3.l: New test. >> * gas/scfi/x86_64/scfi-cfg-3.s: New test. >> * gas/scfi/x86_64/scfi-x86-64.exp: Add new test. >> >> gas: gcfg: address review comments for local jump issue >> >> ChangeLog: >> * gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.d >> * gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.l >> * gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.s >> --- >> gas/ginsn.c | 47 +++++++++++-------- >> gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.d | 32 +++++++++++++ >> gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.l | 3 ++ >> gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.s | 43 +++++++++++++++++ >> gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp | 2 + >> 5 files changed, 108 insertions(+), 19 deletions(-) >> create mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.d >> create mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.l >> create mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.s > > ... below here, perhaps with another --- separator. This way it's clear > that the revlog isn't going to be part of the commit message. > > Jan